Your message dated Fri, 10 Jul 2015 09:34:49 +0000
with message-id <[email protected]>
and subject line Bug#787093: fixed in autopkgtest 3.16
has caused the Debian Bug report #787093,
regarding autopkgtest: dpkg-deb chokes with build profiles in Build-Depends:
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
787093: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=787093
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: autopkgtest
Version: 3.14.2
Severity: normal
Tags: patch

gem2deb seems to the first package to use build profiles in the official
Debian  archive, and it started to cause fallout in several places.
autopkgtest is also affected.

The fake package created to encode the test dependencies gets the
Build-Dependencies of the source package, and when it contains build
profiles, dpkg-deb chokes on it. Arguably dpkg-deb could ignore build
profiles, but since build profiles were proposed explicitly as an
extension for the Build-Depends: field, I'd say it makes sense to fix
this in autopkgtest.

The attached patch fixes this by filtering out build profile
specifications from dependencies.

-- System Information:
Debian Release: stretch/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), 
(1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.0.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages autopkgtest depends on:
ii  apt-utils       1.0.9.9
ii  libdpkg-perl    1.18.0
ii  procps          2:3.3.9-9
ii  python3         3.4.2-2
ii  python3-debian  0.1.27

Versions of packages autopkgtest recommends:
ii  autodep8  0.1

Versions of packages autopkgtest suggests:
ii  lxc          1:1.0.7-3terceiro1
ii  qemu-system  1:2.3+dfsg-3
ii  qemu-utils   1:2.3+dfsg-3
ii  schroot      1.6.10-1.1

-- no debconf information

-- 
Antonio Terceiro <[email protected]>
From deed4e980f52e8a1cb259cd3faf2f3206a0c7513 Mon Sep 17 00:00:00 2001
From: Antonio Terceiro <[email protected]>
Date: Thu, 28 May 2015 10:03:09 -0300
Subject: [PATCH] @builddeps@: filter out build profiles syntax

---
 lib/testdesc.py | 10 ++++++++--
 tests/testdesc  | 11 +++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/lib/testdesc.py b/lib/testdesc.py
index 12e4267..2e81c59 100644
--- a/lib/testdesc.py
+++ b/lib/testdesc.py
@@ -230,15 +230,21 @@ def _debian_packages_from_source(srcdir):
 
 def _debian_build_deps_from_source(srcdir):
     deps = []
+    def normalize_build_dependency(dep):
+        """
+        Removes build profiles syntax, plus any leading/trailing whitespace
+        """
+        return re.sub('<[^<>]*>', '', dep).strip()
+
     for st in parse_rfc822(os.path.join(srcdir, 'debian/control')):
         if 'Build-depends' in st:
             for d in st['Build-depends'].split(','):
-                dp = d.strip()
+                dp = normalize_build_dependency(d)
                 if dp:
                     deps.append(dp)
         if 'Build-depends-indep' in st:
             for d in st['Build-depends-indep'].split(','):
-                dp = d.strip()
+                dp = normalize_build_dependency(d)
                 if dp:
                     deps.append(dp)
     # @builddeps@ should always imply build-essential
diff --git a/tests/testdesc b/tests/testdesc
index cf059a0..9665d47 100755
--- a/tests/testdesc
+++ b/tests/testdesc
@@ -326,6 +326,17 @@ class Debian(unittest.TestCase):
                                          'bdi1', 'build-essential', 'foo (>= 7)'])
         self.assertFalse(skipped)
 
+    def test_builddeps_with_build_profiles(self):
+        (ts, skipped) = self.call_parse(
+            'Tests: t\nDepends: @, @builddeps@',
+            'Source: nums\nBuild-Depends: bd1, bd2 <!nocheck>\n'
+            '\n'
+            'Package: one\nArchitecture: any')
+        self.assertEqual(ts[0].depends, ['one (>= 0~)', 'bd1', 'bd2',
+                                         'build-essential'])
+        self.assertFalse(skipped)
+
+
     def test_complex_deps(self):
         '''complex test dependencies'''
 
-- 
2.1.4

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: autopkgtest
Source-Version: 3.16

We believe that the bug you reported is fixed in the latest version of
autopkgtest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <[email protected]> (supplier of updated autopkgtest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 10 Jul 2015 11:26:36 +0200
Source: autopkgtest
Binary: autopkgtest
Architecture: source all
Version: 3.16
Distribution: unstable
Urgency: medium
Maintainer: Autopkgtest team <[email protected]>
Changed-By: Martin Pitt <[email protected]>
Description:
 autopkgtest - automatic as-installed testing for Debian packages
Closes: 787093 790650
Changes:
 autopkgtest (3.16) unstable; urgency=medium
 .
   Behaviour changes and improvements:
   * ssh-setup/nova: Re-try nova boot up to three times if it fails, and sleep
     5 minutes in between. This occasionally fails due to exceeding quota or
     temporary glitches.
   * Drop gpg-signing local archive and mark it as [trusted=yes] instead. This
     gets rid of the requirement to generate a gpg key on first run. Drop
     corresponding --gnupg-home option. (LP: #1472691)
   * Drop long-obsolete --tmp-dir backwards compat option.
   * ssh-setup/snappy: Adjust ubuntu-device-flash arguments to new
     release/channel structure from Ubuntu 15.10, and default to rolling/edge.
     Add new --release option.
 .
   Bug fixes:
   * ssh-setup/nova: Silence "invalid command wait-reboot" warning.
   * setup-commands/cloud-vm-setup: Purge cloud-init too. It sometimes causes
     longer hangs on boot and might interfere with tests in other ways, and we
     only need it for first-time initialization anyway.
   * adt-virt-qemu: adt-buildvm-ubuntu-cloud: Don't use -enable-kvm QEMU option
     if /dev/kvm does not exist. (Closes: #790650)
   * Quiesce warnings from tar. Avoids "time stamp is in the future" log spew.
     (LP: #1468868)
   * Move apt sources setup from setup-commands/cloud-vm-setup to
     ssh-setup/nova. --apt-pocket does not work with the former as that runs
     too late.
   * Use Dpkg::Deps to evaluate/reduce build dependencies for expanding
     "@builddeps@". This handles build profiles. (Closes: #787093)
   * Resolve build profiles when installing build dependencies to build tested
     package.
   * Adjust NullRunner.test_tmp_install_perl test case to use
     libtest-requires-perl instead of libtest-tester-perl; the latter got
     removed from Debian.
Checksums-Sha1:
 2843c5d7a98fa82aaf13e29698888e0775657091 1755 autopkgtest_3.16.dsc
 13793600cdfd775f9c7f2211e58c41e9674818ae 173173 autopkgtest_3.16.tar.gz
 c22c4df37797c59e4bda444e350dc4227bf43e89 147890 autopkgtest_3.16_all.deb
Checksums-Sha256:
 2e587b443c158a764389a1c4a3720b39f92e52f74b800dacd8338e30f88d2a75 1755 
autopkgtest_3.16.dsc
 71f77474ce13651ea381aa97b9ef35aa578c40104aaf5c3f7a80644484c91229 173173 
autopkgtest_3.16.tar.gz
 a704d6b766fdd3dfdeecffa78ed66f9fbc2a573c2ac0e053e4a0aeee44cd67f0 147890 
autopkgtest_3.16_all.deb
Files:
 7f7e229578279e33d6225c04dc80b063 1755 devel optional autopkgtest_3.16.dsc
 2aaa18003dedfac40d3ed7108eed1a89 173173 devel optional autopkgtest_3.16.tar.gz
 5c6c9b729ce76e86c7ccb1ddcd672a6c 147890 devel optional autopkgtest_3.16_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVn5CQAAoJENFO8V2v4RNHGt0QAKfoXEpCRbClFH9GgqbFUmlu
b0YbFJpCTAZx8eyGAEUM2uesrtNrcPVW2B+0giOiSX7XXiTu63PaXrDRjhfXvD9u
O+aw5nr8L76Lhwc0V0SI1/qzwek+XXQkXCCjBw3rKFuHGLE/gMtlRJ1Q/fB48WSU
qpckUoD7rvGM8LKLUxwVg/1Jcjocmt5PEyTjdfRxV3UWZ0M3whkVgVYX3om/KEAG
wGI8EgH4bCBHFr6j9MXqdHarDmNHzbeCh/faJ7D6zuOO9+GPFVJIpiB6Ais8/854
tUw5bowKlTGJqrs4qrj5EbURtUwIJTMYuz2gMScKthxVTVdj5WQbxikvKa7Wy7sN
vSg7X/isqLcIFrKrnSMZoZu60rYtZvOyxOpvEtnIL+8+SQxx7Xu1dWqMOwFXkxXt
wIuvVvsWIelXcPwGoeorsCtFH89N3M+DCUWY0+gjmZIuluBe7NP7oMiXTq6yNcDa
Oc4Q4uYAGPG1007AKMU/S2cUNOvzOfsk5N9lyktVuLABE60u9CV6JGrfS/pPQcFk
SqVp7RFKLbFwZEzCmz+sAGK8wy2fS522glBp605E28bQUsQCNqQCyjFCKg/p+uUx
1QM+YV61hZ3g5kvd6C7ErpMGIGfpqRgVqGENvEcVfqS7oTss2dExugUIxSEYdlQ+
/Yb3Ga8eyEi1Oz4MwtVU
=8TOD
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to