Your message dated Mon, 13 Jul 2015 14:03:51 +0200
with message-id <[email protected]>
and subject line Re: Bug#695307: tcpick thinko and patch
has caused the Debian Bug report #695307,
regarding tcpick thinko and patch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
695307: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695307
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tcpick
Version: 0.2.1-6

This started off as an ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/tcpick/+bug/1086534

There's a thinko/cut-n-paste in time.c:time_ascii where there is
an incorrect length memset; this causes fortify to kill it
in the Ubuntu built versions.

I don't see any upstream activity for years, so I'm not sure
there is really anywhere to report it there.

Dave

Here is my patch:

--- ../../../tcpick-0.2.1/src/time.c    2005-01-09 00:21:44.000000000 +0000
+++ src/time.c  2012-12-06 20:11:10.041288135 +0000
@@ -42,7 +42,7 @@
   tzp = (struct timezone * ) S_malloc( sizeof(struct timezone) );  

   memset(tp,  0, sizeof(struct timeval));  
-  memset(tzp, 0, sizeof(struct timeval));  
+  memset(tzp, 0, sizeof(struct timezone)); 

   if(gettimeofday(tp, tzp)) {


-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\ gro.gilbert @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

--- End Message ---
--- Begin Message ---
Version: 0.2.1-6.1

On Thu, 06 Dec 2012, Dr. David Alan Gilbert wrote:
> This started off as an ubuntu bug:
> https://bugs.launchpad.net/ubuntu/+source/tcpick/+bug/1086534
> 
> There's a thinko/cut-n-paste in time.c:time_ascii where there is
> an incorrect length memset; this causes fortify to kill it
> in the Ubuntu built versions.
> 
> I don't see any upstream activity for years, so I'm not sure
> there is really anywhere to report it there.

I (re)discovered this error by myself today while fixing the
GCC 5 build failure and I fixed it in the 0.2.1-6.1 upload I just
made.

Thanks for the report!

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

--- End Message ---

Reply via email to