Your message dated Sun, 19 Jul 2015 22:12:32 +0200
with message-id <[email protected]>
and subject line Re: Backups broken when "ssh_args" are set
has caused the Debian Bug report #717451,
regarding [rsnapshot] Rsnapshot Cannot Parse ssh_args
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
717451: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717451
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rsnapshot
Version: 1.3.1-4
Severity: normal

I use rsnapshot with a custom setting for ssh_args in order to improve speed as follows (rsnapshot.conf):
backup  [email protected]:/       xen/            ssh_args=-c arcfour

This has worked fine for years. On Aug. 16 I updated
rsnapshot:amd64 1.3.1-3 -> 1.3.1-4

On aug. 17, the daily backup failed with:

rsync: Failed to exec /usr/bin/ssh -c arcfour: No such file or directory (2) rsync error: error in IPC code (code 14) at pipe.c(84) [Receiver=3.0.9]

rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
rsync error: error in IPC code (code 14) at io.c(605) [Receiver=3.0.9]
----------------------------------------------------------------------------
rsnapshot encountered an error! The program was invoked with these options:
/usr/bin/rsnapshot daily
----------------------------------------------------------------------------

On investigation, it looks like the way arguments are passed to the system() call were changed by 10_space_destdir.diff:

--- a/rsnapshot-program.pl      2009/03/09 05:38:23     1.413
+++ b/rsnapshot-program.pl      2009/03/27 21:54:02     1.414
@@ -3692,8 +3692,7 @@
        $result = 1;
        if (0 == $test) {
                while ($tryCount < $rsync_numtries && $result !=0) {
-                       # join is Michael Ashley's fix for some filter/space 
problems           
-                       $result = system(join(' ', @cmd_stack));
+                       $result = system(@cmd_stack);
                        $tryCount += 1;
                }

@@ -4728,8 +4728,7 @@
        print_cmd(@cmd_stack);
        
        if (0 == $test) {
- # join is Michael Ashley's fix for some filter/space problems
-               my $result = system(join(' ', @cmd_stack));
+               my $result = system(@cmd_stack);
                
                if ($result != 0) {
                        # bitmask return value

Reverting this patch fixes the issue. If I have time, I will investigate another method of implementation.







--- System information. ---
Architecture: amd64
Kernel:       Linux 3.10-2-amd64

Debian Release: jessie/sid
  900 testing         security.debian.org
  900 testing         mirror.rackspace.com
  900 testing         mirror.csclub.uwaterloo.ca
  500 stable          dl.google.com

--- Package information. ---
Depends             (Version) | Installed
=============================-+-===========
perl                          | 5.14.2-21
rsync                         | 3.0.9-4
logrotate                     | 3.8.5-1
liblchown-perl                | 1.01-1+b2


Recommends          (Version) | Installed
=============================-+-===========
openssh-client                | 1:6.2p2-6
 OR ssh-client                |


Package's Suggests field is empty.

--- End Message ---
--- Begin Message ---
fixed 717451 1.4.0-1
thanks

On Wed, 15 Jul 2015 19:42:21 -0400 Michel <[email protected]>
wrote:
> Package: rsnapshot
> Version: 1.3.1-7
> Followup-For: Bug #717451
>
>
> Dear Maintainer,
>
> After upgrading rsnapshot to 1.3.1-7, remote backups still fail. Local
> backups work as expected. The upgrade occurred on 06/24/2015, and every
> remote backup since then have failed. Have been extremely busy and have
> not checked local email, until today. To my surprise, have no remote
> backups since 06/24.
>
>

I've pushed the 1.4.0-1 release that fix that kind of problem.
Feel free to reopen if it is not the case.

--
Guillaume Delacour

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---

Reply via email to