Your message dated Fri, 24 Jul 2015 11:05:28 +0000
with message-id <[email protected]>
and subject line Bug#710367: fixed in squeak-vm 1:4.10.2.2614-2
has caused the Debian Bug report #710367,
regarding squeak-vm: ftbs with ld --as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
710367: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710367
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: squeak-vm
Version: 1:4.10.2.2614-1
Severity: wishlist
User: [email protected]
Usertags: ld-as-needed
Tags: patch
squeak-vm fails to build with ld --as-needed.
With --as-needed libraries need to be placed before objects needing
their symbols (including static libraries).
Attached patch adapts the avoid_embedded_libs.patch to order the
commandline correctly.
Description: Link against system shared PCRE and JPEG libraries
Author: Neil Williams <[email protected]>
Bug-Debian: http://bugs.debian.org/634240
--- a/unix/CMakeLists.txt
+++ b/unix/CMakeLists.txt
@@ -117,10 +117,17 @@ MACRO (USE_LIBRARY lib)
LIST (APPEND squeak_libs "${lib}")
ENDMACRO (USE_LIBRARY)
+MACRO (USE_LIBRARY_SHARED lib)
+ LIST (APPEND squeak_libs_shared "${lib}")
+ENDMACRO (USE_LIBRARY_SHARED)
+
MACRO (USE_FRAMEWORK fwk)
USE_LIBRARY ("-framework ${fwk}")
ENDMACRO (USE_FRAMEWORK)
+USE_LIBRARY_SHARED ("-lpcre")
+USE_LIBRARY_SHARED ("-ljpeg")
+
MACRO (CONFIG_DEFINE var)
LIST (APPEND config_vars "${var}")
ENDMACRO (CONFIG_DEFINE var)
--- a/Cross/plugins/JPEGReadWriter2Plugin/JPEGReadWriter2Plugin.h
+++ b/Cross/plugins/JPEGReadWriter2Plugin/JPEGReadWriter2Plugin.h
@@ -12,6 +12,7 @@ struct error_mgr2 {
typedef struct error_mgr2* error_ptr2;
void error_exit (j_common_ptr cinfo);
-GLOBAL(void) jpeg_mem_src (j_decompress_ptr cinfo, char * pSourceData, unsigned sourceDataSize);
+//GLOBAL(void) jpeg_mem_src (j_decompress_ptr cinfo, char * pSourceData, unsigned sourceDataSize);
GLOBAL(int) jpeg_mem_src_newLocationOfData (j_decompress_ptr cinfo, char * pSourceData, unsigned sourceDataSize);
-GLOBAL(void) jpeg_mem_dest (j_compress_ptr cinfo, char * pDestination, unsigned *pDestinationSize);
\ No newline at end of file
+//GLOBAL(void) jpeg_mem_dest (j_compress_ptr cinfo, char * pDestination, unsigned *pDestinationSize);
+
--- a/Cross/plugins/JPEGReadWriter2Plugin/jmemdatasrc.c
+++ b/Cross/plugins/JPEGReadWriter2Plugin/jmemdatasrc.c
@@ -149,7 +149,7 @@ METHODDEF(void) skip_input_data (j_decom
METHODDEF(void) term_source (j_decompress_ptr cinfo) {
/* no work necessary here */
}
-
+#if 0
/*
* Prepare for input from a stdio stream.
* The caller must have already opened the stream, and is responsible
@@ -187,6 +187,7 @@ GLOBAL(void) jpeg_mem_src (j_decompress_
src->pub.bytes_in_buffer = 0; /* forces fill_input_buffer on first read */
src->pub.next_input_byte = NULL; /* until buffer loaded */
}
+#endif
/* This function allows data to be moved if necessary */
GLOBAL(int) jpeg_mem_src_newLocationOfData (j_decompress_ptr cinfo, char * pSourceData, unsigned sourceDataSize) {
my_src_ptr src;
@@ -198,4 +199,4 @@ GLOBAL(int) jpeg_mem_src_newLocationOfDa
src->actualPos = pSourceData + offset;
return((src->actualPos + src->bytesLeft) == (pSourceData + sourceDataSize));
-}
\ No newline at end of file
+}
--- a/Cross/plugins/JPEGReadWriter2Plugin/jmemdatadst.c
+++ b/Cross/plugins/JPEGReadWriter2Plugin/jmemdatadst.c
@@ -113,7 +113,7 @@ METHODDEF(void) term_destination (j_comp
ERREXIT(cinfo, JERR_FILE_WRITE);
}
}
-
+#if 0
/*
* Prepare for output to a stdio stream.
* The caller must have already opened the stream, and is responsible
@@ -143,3 +143,5 @@ GLOBAL(void) jpeg_mem_dest (j_compress_p
dest->pSpaceUsed = pDestinationSize;
*(dest->pSpaceUsed) = 0;
}
+#endif
+
--- a/unix/vm/build.cmake
+++ b/unix/vm/build.cmake
@@ -45,7 +45,7 @@ INCLUDE_DIRECTORIES (
SET_TARGET_PROPERTIES (squeakvm${scriptsuffix} PROPERTIES LINK_FLAGS "${CMAKE_EXE_EXPORTS_C_FLAG}")
-TARGET_LINK_LIBRARIES (squeakvm${scriptsuffix} m ${squeak_libs} ${vm_link_libraries})
+TARGET_LINK_LIBRARIES (squeakvm${scriptsuffix} m ${squeak_libs} ${vm_link_libraries} ${squeak_libs_shared})
INSTALL (PROGRAMS ${bld}/squeakvm${scriptsuffix} DESTINATION ${plgdir})
--- End Message ---
--- Begin Message ---
Source: squeak-vm
Source-Version: 1:4.10.2.2614-2
We believe that the bug you reported is fixed in the latest version of
squeak-vm, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jonas Smedegaard <[email protected]> (supplier of updated squeak-vm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 21 Jul 2015 20:02:34 +0200
Source: squeak-vm
Binary: squeak-vm
Architecture: source amd64
Version: 1:4.10.2.2614-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Squeak Team <[email protected]>
Changed-By: Jonas Smedegaard <[email protected]>
Description:
squeak-vm - Unix Squeak virtual machine
Closes: 603797 611115 658108 693633 696606 710367 740972
Changes:
squeak-vm (1:4.10.2.2614-2) unstable; urgency=medium
.
* Update README.source to emphasize that control.in file is *not* a
show-stopper for contributions.
* Move packaging to pkg-squeak team governance.
* Declare compliance with Debian Policy 3.9.6.
* Improve short and long description, avoiding article in short
description, and referencing Debian packages (not web pages) for
Squeak images.
* Modernize CDBS use:
+ Have utils.mk put aside cruft during build.
Tighten to build-depend on recent cdbs.
+ Stop needlessly relax upstream-tarball.mk inclusion.
+ Include cmake.mk (bypassing upstream configure script): Enables
fortifying options.
* Fix menu file.
* Recommend scratch with etoys as fallback (and stop suggest etoys).
Closes: bug#603797. Thanks to Ronny Standtke.
* Remove /usr/share/squeak dir when purging package.
Closes: Bug#658108. Thanks to Andreas Beckmann.
* Fix drop Education tag from desktop file.
Closes: Bug#611115. Thanks to Chris Wilson.
* Fix FTBFS with build-flag --as-needed.
Closes: Bug#710367. Thanks to Julian Taylor.
* Fix build-depend on libasound2-dev only on Linux archs, and
build-exclude it elsewhere.
Closes: Bug#696606. Thanks to Steven Chamberlain.
* Fix disable FFIPrims plugin on powerpcspe.
Closes: Bug#693633. Thanks to Roland Stigge.
* Add patch to fix FTBFS with clang.
Closes: bug#740972. Thanks to Nicolas Sévelin-Radiguet.
Checksums-Sha1:
37b4dec32203ebab61b1c535db004a3c3bd29a41 2367 squeak-vm_4.10.2.2614-2.dsc
01e508d0bfe4520c4bb54f3567733af47949329d 78624
squeak-vm_4.10.2.2614-2.debian.tar.xz
af83cee120fb09b855971c959c2b7d429d8ce071 529884
squeak-vm_4.10.2.2614-2_amd64.deb
Checksums-Sha256:
0d6d75e3640746cadea8a1c0827b46feba956b555458994be43d3b3a667e8144 2367
squeak-vm_4.10.2.2614-2.dsc
b1ebf95a7f5f30a6597c042ddd1574461caf922a3390ae9499837e9db32140d8 78624
squeak-vm_4.10.2.2614-2.debian.tar.xz
a5ca1d3ee3e56fd0ebb55c855b9a4c86df31ef074774f581feaf051e0851023b 529884
squeak-vm_4.10.2.2614-2_amd64.deb
Files:
eac36db3e1e11f3c18a20747b8f4bac0 2367 interpreters optional
squeak-vm_4.10.2.2614-2.dsc
07e722bb42f0988a111fc1235849f127 78624 interpreters optional
squeak-vm_4.10.2.2614-2.debian.tar.xz
85f6cbe96e41246f3ea74c01d2181935 529884 interpreters optional
squeak-vm_4.10.2.2614-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJVrpVIAAoJECx8MUbBoAEhPu4P/0sVxk2nGwyv5kcUop58OcGe
U0biUbv+/rcJqq6MkhcEBoMEP7EgaIq3I/p3bcCu0MfAideyr6cUmPfBySWKBsof
PZISdGFw4rt5LmjsX82ZgxMlSkSSs7jgZe5wRzOsv3VhssBSC8691ffDTjScSbof
1/9k6SC+TpvT5ruEWPl8Nm63L456+YmD7HK5i3MJUmmlAKHrNpFQMCB4ioYnr25S
yRfILU5rZu20Xh931fBwc9WgBzYXveV+pmAO/iSse4vts1cvK/8X16firpj3ed3u
FElcjVx8uwPjeFjtX3lj0G4vQeTceX9/bh9u6VeZwJ1tFLRYKObUjNOkH/w8IkmW
qovOvOSHJJr8ljuIOQGtHwWOTzuJmrkA6YfP3yhBxdQOp9yie5u7z3rN9sp5yTqe
JHEayumAQJPpYqmOYXc1IAVu3NYTv71s0ZVnzGSg4iRvvN1qBzyd/1AQDWasr9ON
+U1Nh2LWMCjjtfeJdh7sAMN+aIItHLqpoC72wxj6JktMoCd8i3CdKpuUecGHzQbp
U9lB7DUOPPWwchZIMd2Bsslzwch6189ThWkbz1NO2kB1Y+dEzN8Z84RCx5VsIK6z
/pEn4csuWxrS0JI9n5Mwa6FRq71/ZhpvgVgMBk6pm7+A1SmJq//hz50KpPlCAoJH
+fxbEpdwBA0MbZcCLYDo
=8vqK
-----END PGP SIGNATURE-----
--- End Message ---
