Your message dated Sun, 09 Aug 2015 16:22:20 +0000
with message-id <[email protected]>
and subject line Bug#686825: fixed in rrdtool 1.5.4-1
has caused the Debian Bug report #686825,
regarding rrdtool: invalid JSON output from "rrdtool xport --json"
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
686825: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686825
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rrdtool
Version: 1.4.7-2
Severity: normal
Tags: upstream patch
Dear Maintainer,
the JSON output from "rrdtool xport --json" is not valid according to the JSON
specification found at http://www.json.org/
I have tested the output on http://jsonlint.org/ and it is missing double
quotes on all strings, which is mandatory in JSON.
Example of output:
{ about: 'RRDtool xport JSON output',
meta: {
start: 1333111500,
step: 10,
end: 1333111500,
legend: [
''
]
},
data: [
[ 8.7720000000e+00 ],
[ 8.7720000000e+00 ]
]
}
Valid output would be:
{ "about": "RRDtool xport JSON output",
"meta": {
"start": 1333111500,
"step": 10,
"end": 1333111500,
"legend": [
""
]
},
"data": [
[ 8.7720000000e+00 ],
[ 8.7720000000e+00 ]
]
}
I have already contacted the developer and sent the simple patch upstream.
Regards,
Thomas Mainka
-- System Information:
Debian Release: wheezy/sid
APT prefers testing-proposed-updates
APT policy: (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages rrdtool depends on:
ii libc6 2.13-35
ii libcairo2 1.12.2-2
ii libdbi1 0.8.4-6
ii libglib2.0-0 2.32.3-1
ii libpango1.0-0 1.30.0-1
ii libpng12-0 1.2.49-1
ii librrd4 1.4.7-2
ii libxml2 2.8.0+dfsg1-5
rrdtool recommends no packages.
Versions of packages rrdtool suggests:
pn librrds-perl <none>
-- no debconf information
--- ../rrdtool-1.4.7.orig/src/rrd_tool.c 2012-01-24 11:08:48.000000000 +0100
+++ src/rrd_tool.c 2012-09-05 17:11:34.471626553 +0200
@@ -737,13 +737,13 @@
printf(" <%s>\n", META_TAG);
}
else {
- printf("{ about: 'RRDtool xport JSON output',\n meta: {\n");
+ printf("{ \"about\": \"RRDtool xport JSON output\",\n \"meta\": {\n");
}
#define pXJV(indent,fmt,tag,value) \
if (json) { \
- printf(indent "%s: " fmt ",\n",tag,value); \
+ printf(indent "\"%s\": " fmt ",\n",tag,value); \
} else { \
printf(indent "<%s>" fmt "</%s>\n",tag,value,tag); \
}
@@ -757,7 +757,7 @@
}
if (json){
- printf(" %s: [\n", LEGEND_TAG);
+ printf(" \"%s\": [\n", LEGEND_TAG);
}
else {
printf(" <%s>\n", LEGEND_TAG);
@@ -766,7 +766,7 @@
char *entry = NULL;
entry = legend_v[j];
if (json){
- printf(" '%s'", entry);
+ printf(" \"%s\"", entry);
if (j < col_cnt -1){
printf(",");
}
@@ -788,7 +788,7 @@
}
if (json){
- printf(" %s: [\n",DATA_TAG);
+ printf(" \"%s\": [\n",DATA_TAG);
} else {
printf(" <%s>\n", DATA_TAG);
}
--- End Message ---
--- Begin Message ---
Source: rrdtool
Source-Version: 1.5.4-1
We believe that the bug you reported is fixed in the latest version of
rrdtool, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jean-Michel Vourgère <[email protected]> (supplier of updated rrdtool package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 09 Aug 2015 17:43:02 +0200
Source: rrdtool
Binary: rrdtool rrdcached rrdtool-dbg librrd4 librrd-dev librrds-perl
librrdp-perl rrdtool-tcl python-rrdtool ruby-rrd liblua5.1-rrd0
liblua5.1-rrd-dev
Architecture: source amd64 all
Version: 1.5.4-1
Distribution: unstable
Urgency: low
Maintainer: Debian RRDtool Team <[email protected]>
Changed-By: Jean-Michel Vourgère <[email protected]>
Description:
liblua5.1-rrd-dev - time-series data storage and display system (Lua 5.1
development)
liblua5.1-rrd0 - time-series data storage and display system (Lua 5.1
interface)
librrd-dev - time-series data storage and display system (development)
librrd4 - time-series data storage and display system (runtime library)
librrdp-perl - time-series data storage and display system (Perl interface,
pipe
librrds-perl - time-series data storage and display system (Perl interface,
shar
python-rrdtool - time-series data storage and display system (Python interface)
rrdcached - data caching daemon for RRDtool
rrdtool - time-series data storage and display system (programs)
rrdtool-dbg - time-series data storage and display system (debugging symbols)
rrdtool-tcl - time-series data storage and display system (Tcl interface)
ruby-rrd - time-series data storage and display system (Ruby interface)
Closes: 467342 543631 603507 686825 717248 721975 729007 748656
Changes:
rrdtool (1.5.4-1) unstable; urgency=low
.
* Added myself in uploaders.
* Update d/watch to look dirrectly at github.
* New upstream version:
- Fixes json output (Closes: #686825)
- Fixes rrdupdate duplicate paragraph in man (Closes: #603507)
- Adds support for floating point values with DERIVE, COUNTER with new
datasource types: DCOUNTER and DDERIVE. (Closes: #543631)
- Fixes compilation on hurd. (Closes: #721975)
- Provide a python example with locale setup. (Closes: #729007).
- Drop all patches but no-rpath-for-ruby: Applied upstream.
- Added build-dependency on dc.
- Ignoring new systemd files that would change the socket location and
many options. Using upstream lsb files from github. (Closes: #717248,
#748656)
* Moved project to alioth: Updated maintainer address and Vcs-* fields.
* Dropped transitional packages librrd-ruby*.
* Bumped standards to 3.9.6: No change required.
* Switch copyright to DEP5 format.
* Bumped source format to 3.0 (quilt):
- Dropped d/README.source;
- Dropped quilt has a dependency.
* Minimized d/rules:
- Using dh_auto_configure fixes all hardening but for ruby.
- Uses /usr/lib/arch-triplet.
- Clean using d/clean.
* Enabled verbose build.
* Re-enabled optimisations on arm. (Closes: #467342)
* Disable rpn2 unittest that fails.
* Made the builds reproducible:
- Set up fake BUILD_DATE and BUILD_TIME in d/rules from changelog.
- New patch reproducible-builds to use these.
* Added patch breaks-long-man-lines to fix "Cant break line" warnings.
* Added librrd4.lintian-overrides for false positive.
Checksums-Sha1:
5b0c62eb148e5443e58361fea492a347fe8d304d 2995 rrdtool_1.5.4-1.dsc
800f480e473f888abef144f2886fc570c9e6adfb 1109628 rrdtool_1.5.4.orig.tar.gz
3c3ceabea1232ed467fc50456d2804f58e5634dd 26748 rrdtool_1.5.4-1.debian.tar.xz
842fdae7a883e8117af1308fd4c474411213d244 112518 librrdp-perl_1.5.4-1_all.deb
Checksums-Sha256:
09d80149c5f70fa013d30ed723f9cb877374b2103e7915d82d9f3307f0907968 2995
rrdtool_1.5.4-1.dsc
fd4ae88c8a5846b88ee2429b4a688654bfee4f1363cc35dbab5560a208368f93 1109628
rrdtool_1.5.4.orig.tar.gz
995949404f5bc2dac503ddee2ebcb647415aa7bb8d1b98e4c8953fd2798c4a3c 26748
rrdtool_1.5.4-1.debian.tar.xz
41f4de0718547c5721da1fe92f673e9787dabfd1d961c2c0ae193c7bea720fee 112518
librrdp-perl_1.5.4-1_all.deb
Files:
545a37fb9554db13fdcc63699d3226a6 2995 utils optional rrdtool_1.5.4-1.dsc
d5158c2ed7bb7f2c33049a736a7399dc 1109628 utils optional
rrdtool_1.5.4.orig.tar.gz
94afc4d49caaf35b121fde5038ad6edd 26748 utils optional
rrdtool_1.5.4-1.debian.tar.xz
3a5c94e8da93f211ca8732500f0f337b 112518 perl optional
librrdp-perl_1.5.4-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVx3oDAAoJEDtcLHGiGNg8F64QAK+Ea3x2QJWS06JIvuVnnZrD
SqoQ7WDuM4HiKrJDjKvQvTMVUG6r62XTLFS2/6Ik15TM2R4f0OBysRGiSgywpEol
gG6pPukvR0Xd6OoUTZmgOTdSJ1gsyUPrjkeooLuYFlXibVRM7S59NPrrhMnFk+ln
sxx8bYrHd95IxEiHFmI/Em1mkoJivb46z/0pgVbPXMx52vYxG+/bVtsXYNbDRccQ
/hlkKgrDNdUYLvVouLWi69LeduEVxBRr5/K6YBGfdcTRe0qsVe9KVgoTLDc28ykM
2nRSTQv7ZQq98+nLgIcel0IC2o2Q5svZpGEm57M07rw/Yir7jnsIpm0oDk44pjvS
ffPphieCKg3kF56IUXdmcq6Bkw7VfeLwTJ2Jo9tRQ5cNDp9veK38CmtJe03ztBDn
S5bU8j5/82BkuAlcyK1/GpDxt9f63+orPtmQwKDjtUU1Y4XYLnGx0e0UTMqKpTS/
mBO4aPkY5tBI6LUX/a51iOpAiEgIPPB37WcN0jKBiV1MOUOBZSqgVUqzGEdpmFPn
AE7MmG4t/Lj8V6MNvX3vopfcxokZHhXEXrpx2NaWumyLus/EA5Juo/MltOFJIrhX
usj8Nm4SYvGbvaIlAexrljh/w7COQr3LSRdIjfsUCvfV72hhCG53AheCI3x0CW2s
wDgNQmDe/RQHyGeqe9n3
=DEiJ
-----END PGP SIGNATURE-----
--- End Message ---
