Your message dated Fri, 09 Oct 2015 07:19:08 +0000
with message-id <[email protected]>
and subject line Bug#790407: fixed in rott 1.1.2+svn287-2
has caused the Debian Bug report #790407,
regarding rott: please show a dialog box if files are missing
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
790407: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790407
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rott
Version: 1.1.2+svn287-1
Severity: normal
Tags: patch
Hi,
If someone has installed rott without providing some data in
/usr/share/games/rott; when the game is selected from a desktop environment,
nothing happens. (well something is printed to stderr, but user never sees it)
Here is a patch that forward the message to a dialog box.
Much simpler function "SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR,"
is only available for SDL2+.
Screenshot of basicaly the same patch for OpenTyrian:
http://users.teledisnet.be/ade15809/tyrian/
----
Step 2 is appending a Debian-specific wording to "W_InitFiles: no files found"
to let the user known he can automaticaly install the data with game-data-
packager.
Alexandre
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.19.0-trunk-amd64 (SMP w/6 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages rott depends on:
ii libc6 2.19-18
ii libsdl-mixer1.2 1.2.12-11+b1
ii libsdl1.2debian 1.2.15-11
Versions of packages rott recommends:
ii freepats 20060219-1
ii game-data-packager 42
ii musescore-soundfont-gm 1.3+dfsg1-0.1
rott suggests no packages.
-- no debconf information
diff --git a/rott/rt_util.c b/rott/rt_util.c
index e455b5f..f912cb7 100644
--- a/rott/rt_util.c
+++ b/rott/rt_util.c
@@ -446,6 +446,34 @@ void Error (char *error, ...)
#if USE_SDL
SDL_Quit();
#endif
+ #ifdef PLATFORM_UNIX
+ char* argv[6];
+ char zenity_buf[300] = "--text=\0";
+ strncat(zenity_buf,msgbuf,sizeof(zenity_buf)-8);
+ pid_t child_pid;
+ child_pid = fork();
+ if(child_pid == 0) {
+ argv[0] = "zenity";
+ argv[1] = "--error";
+ argv[2] = zenity_buf;
+ argv[3] = "--title=ROTT";
+ argv[4] = NULL;
+ execvp(argv[0], argv);
+ argv[0] = "kdialog";
+ argv[2] = msgbuf;
+ execvp(argv[0], argv);
+ argv[0] = "xmessage";
+ argv[1] = "-center";
+ argv[3] = NULL;
+ execvp(argv[0], argv);
+ argv[0] = "notify-send";
+ argv[1] = "ROTT";
+ argv[3] = "-i";
+ argv[4] = "dialog-error";
+ argv[5] = NULL;
+ execvp(argv[0], argv);
+ }
+ #endif
exit (1);
}
--- End Message ---
--- Begin Message ---
Source: rott
Source-Version: 1.1.2+svn287-2
We believe that the bug you reported is fixed in the latest version of
rott, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Fabian Greffrath <[email protected]> (supplier of updated rott package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 09 Oct 2015 09:09:40 +0200
Source: rott
Binary: rott
Architecture: source amd64
Version: 1.1.2+svn287-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Fabian Greffrath <[email protected]>
Description:
rott - SDL-Port of Rise of the Triad
Closes: 790407
Changes:
rott (1.1.2+svn287-2) unstable; urgency=medium
.
* Show a dialog box if files are missing. Based on patches and
wordings by Alexandre Detiste, thank you very much (Closes: #790407).
+ Replace the unhelpful "W_InitFiles: no files found" error message
with instructions to read README.Debian.
+ Improve README.Debian with clear instructions on how to use
game-data-packager to locate/download the game data, build the
possible rott-*-data Debian package(s), and install it/them.
+ Add "Suggests: zenity | kde-baseapps-bin | x11-utils | libnotify-bin"
for the supported dialog box applications.
* Do not recommend any soundfont at all, leave this to the
libsdl-mixer1.2 package.
* Update Uploaders field and Debian packaging copyright with my
<[email protected]> address.
* Remove rott.menu file and icons in XPM and PNG formats, install upstream's
SVG icon.
* Fix the rott.desktop file.
+ Remove hard-coded fullscreen mode and resolution.
+ Add keywords.
Checksums-Sha1:
f0b556a2c6e2e493a8a373cf922dc96fc71afed3 2019 rott_1.1.2+svn287-2.dsc
dabf915850621320af45ac8d595ff43d17a401a0 10552
rott_1.1.2+svn287-2.debian.tar.xz
9326e40b1d32f81177b889762dee25eeb7696f5c 434810 rott_1.1.2+svn287-2_amd64.deb
Checksums-Sha256:
3f890640d1385c60f78648e5b3318545eafc140b1181de100aa8a889b4050c9b 2019
rott_1.1.2+svn287-2.dsc
e62fd77111ed07761475f7238200273a3445a7505ecf98838144efab60bb992f 10552
rott_1.1.2+svn287-2.debian.tar.xz
569a22d35794e95b81adba7a783d9b27959573a07d3c3b7f30579aea7873601f 434810
rott_1.1.2+svn287-2_amd64.deb
Files:
40bd5449c77925e4b0291ccca459671c 2019 contrib/games optional
rott_1.1.2+svn287-2.dsc
bc38e74b9b365bc0e595b263c470cf45 10552 contrib/games optional
rott_1.1.2+svn287-2.debian.tar.xz
b490971410f658b2f3aaa420e1a5dd51 434810 contrib/games optional
rott_1.1.2+svn287-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJWF2k9AAoJEMvqjpcMzVnfkhkQAM3oZWmhpVDmtOZIrX1M7oPV
UABK7L5OOEwECf24d+U2o8tfC4xXgTgDrbY2B487cHXEAjG47AJ2vRIM1YuqUPA0
aDQf0QmXIlQFfI9sHNEv2TQLxFyqi7+MewjWD+OLDCqfSfO8VIjPUebgCM7k5k8n
7mWTrXRWhZjwHY7EFHNqDf5dLOHTy236ga2poP6rAjEklPxe7qFVWOujkKFxbrkt
TCGVJVWUtp6IWNcTIUsp4AbCeqxt9cNRh03/SC4fG1cz4P8su1FIdbTl6ZeMxiVN
/0ntiSLLpIvMng4ZxRGdA6M8W64t6TIF5VtlqjAEfRu2XbITHnu2uLI9brDbHNCh
eNX4PRjSLYQzK93diV0p+BqslbF8hGs4DnEW/ntdu5AsTuKeaf9ma6hWejGf/mHj
FUtGOwuiFTC3d3vxSx4Bys6VoWOgsZkBgW8bywGvendMHJHU30CqpSVy+182hm9p
iiiQJMGhip5oSq9HzRgtas1gHshRVO0niGcsGEn172d5qoCmamXsq5aPAozHeo2l
nTbx0wdRlXozM50VA+qsBeF1m62drYLMm7varib3OFKrnW1PbeXxrna/3lpDZ65o
595Tr+Z7UgHd7F5Sdh5QPthelUy3iA6PnjplAoC6CmZqdTnejo+IkbCAmio559+6
CmCYH5AwKVwNyPBqlpny
=jhgD
-----END PGP SIGNATURE-----
--- End Message ---
