Your message dated Wed, 23 Dec 2015 18:49:26 +0000
with message-id <[email protected]>
and subject line Bug#778874: fixed in terminator 0.98-1
has caused the Debian Bug report #778874,
regarding terminator: Moving between terminals buggy
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
778874: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778874
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: terminator
Version: 0.97-4
Severity: minor
Tags: patch

Hi,

After having split the window a few times horizontally and vertically,
switching to a window ABOVE using Alt+Up sometimes chooses a terminal far away
from the obvious (unique) one which is directly above.

To reproduce: open a new terminator window, split vertically (Ctrl+Shift+E)
into A and B, split A and B both horizontally (Ctrl+Shift+O) into A1/A2 and
B1/B2. Make A1 a bit smaller, i.e., reduce its height so that it is smaller
than B1. Go to B2, press Alt+Up. You should obviously end up in B1, but you
end up in A1.

This has bugged me for quite a while, today I wrote a fix which you find
attached. The problem is in the function computing distance of other terminals
to the current one. It has an obvious typo for direction == 'up'. The patch
also fixes the return values for 'right' and 'left' even though they didn't
result in bugs.

Thanks for considering.

Regards,
Martin


-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages terminator depends on:
ii  gconf2          3.2.6-3
ii  python-dbus     1.2.0-2+b3
ii  python-gobject  3.14.0-1
ii  python-gtk2     2.24.0-4
ii  python-vte      1:0.28.2-5
pn  python:any      <none>

Versions of packages terminator recommends:
ii  python-gnome2     2.28.1+dfsg-1.1
ii  python-keybinder  0.3.0-3
ii  python-notify     0.1.1-4
ii  xdg-utils         1.1.0~rc1+git20111210-7.3

terminator suggests no packages.

-- no debconf information
diff --git a/terminatorlib/util.py b/terminatorlib/util.py
index b8ad5ab..d1311ca 100755
--- a/terminatorlib/util.py
+++ b/terminatorlib/util.py
@@ -223,11 +223,11 @@ def get_nav_offset(edge, allocation, direction):
     if direction == 'left':
         return(edge - (allocation.x + allocation.width))
     elif direction == 'right':
-        return(edge + allocation.x)
+        return(allocation.x - edge)
     elif direction == 'up':
-        return(edge - (allocation.y - allocation.height))
+        return(edge - (allocation.y + allocation.height))
     elif direction == 'down':
-        return(edge + allocation.y)
+        return(allocation.y - edge)
     else:
         raise ValueError('Unknown direction: %s' % direction)
 

--- End Message ---
--- Begin Message ---
Source: terminator
Source-Version: 0.98-1

We believe that the bug you reported is fixed in the latest version of
terminator, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julián Moreno Patiño <[email protected]> (supplier of updated terminator 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 23 Dec 2015 11:40:07 -0500
Source: terminator
Binary: terminator
Architecture: source
Version: 0.98-1
Distribution: unstable
Urgency: medium
Maintainer: Nicolas Valcárcel Scerpella <[email protected]>
Changed-By: Julián Moreno Patiño <[email protected]>
Description:
 terminator - multiple GNOME terminals in one window
Closes: 648446 778874 803666
Changes:
 terminator (0.98-1) unstable; urgency=medium
 .
   * New upstream release. (Closes: #778874, #803666)
   * Remove patches, merge with upstream.
     + es-po.diff
     + fi-po.diff
     + fix-maximize.diff
     + fix-split-multiple-tabs.diff
     + fix-tab-with-multiple-terminals-not-closing.diff
     + fix-unfocused-font-brightness.diff
     + x-terminal-emulator-fix.diff, better aproach from upstream.
   * d/watch, Add support for signing tarballs.
   * Add force_xdg-open.diff patch to force open default
     web browser. (Closes: #648446)
     + Thanks to Eduard Bloch for it.
   * Add not-install-doc.diff patch to avoid to install
     documentation, a lot of prebuilt javascript object
     that aren't in the GNU Debian archive.
   * Add not-install-terminator-wrapper.diff patch to
     avoid to install terminator.wrapper file.
   * Bump Standards-Version to 3.9.6 (no changes).
   * Add dh-python to B-D.
   * Use pybuild to build the package.
Checksums-Sha1:
 f201a6d4bfd3a53423eea050cee8a3ae0fe71aec 2143 terminator_0.98-1.dsc
 a35561ef4fec3d2f34e909bb7284f0b770a4e607 6007243 terminator_0.98.orig.tar.gz
 36beaba78799d19655ab167ca9a07560144c8fa1 7600 terminator_0.98-1.debian.tar.xz
Checksums-Sha256:
 ad6a3e8bb48678151532c8b114f12670bff33bd0e2478c1ac985fa757d1634d1 2143 
terminator_0.98-1.dsc
 0a6d8c9ffe36d67e60968fbf2752c521e5d498ceda42ef171ad3e966c02f26c1 6007243 
terminator_0.98.orig.tar.gz
 f449fd63a73b064d107c0a0cca5435a8b327379153b10142ac8e08c371fbedd1 7600 
terminator_0.98-1.debian.tar.xz
Files:
 3a1171dd66ec4edce3f56499f798b6d3 2143 misc optional terminator_0.98-1.dsc
 241af292fe16bed290052b86adb30b80 6007243 misc optional 
terminator_0.98.orig.tar.gz
 b64ada554ac35fc2a394f993c9ad1aaa 7600 misc optional 
terminator_0.98-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJWeugvAAoJENX9/BVhaL9gAXsP/3jLf65X2ngGl0emidNpyRNL
zchFIcEQ6/U3iN1gwm+zJ14SiAIEMSa0T4I5YHMbTz7i738J6aRQHBFtrJPsYdwE
VvnHaEzx7y5jfMeFqYbli7PSByWUUh27AIMDbRyOpCMS0+MRpB9Pqm7PggsqP06f
YnkVBZ3tcVw3lnsB4foVoN72maN65n4RgPzKn0S2DJivm80am7g2O5Bf/as4cthG
JYrpFrksXz0ixxerGJNEFPHPVavKT/I0aGZaJhFVGXpWMNZ9sNnOM5owvCei9p9v
CD1NkbqkxcKcQFStG33EK3J4/JbsvWGNyofYi4Oa45onGUsOxpg1LplhwNQ7eYMe
K0sipZM4uvAjv78ZsytiFi7OWcZoOgPAIRO4tXvKP84uBue6vA/QbXYIQDwLZIJH
WkdFSIMVZmfh95g+2KEoQX9OapG1mpHKGjK5k8+Hn54TPdQmd0JXdbv4tGNY0S5r
EmLA6x2n/OjmBbKWrykQOM9lBH0kFxD+jDI9VVHLiYrKthk2DpJXO+RP7xrMLdpM
S16Xo1/qH600Tb2HHM8uQHkHy2LlmQNUUBQlWpJ2T6btpRt2I5BYmWxO6y0edSD5
o4mkEwAANi3XCpg7jtyNaBQ8ooCW/OAfuHXE7or6/T5rFinIJ7iyZV3fUC7oDLvC
GmlYPGiYo6p4qSkaVm6A
=rQb5
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to