Your message dated Mon, 04 Jan 2016 11:35:18 +0000
with message-id <[email protected]>
and subject line Bug#805980: fixed in needrestart 2.4-1
has caused the Debian Bug report #805980,
regarding needrestart: "consider to login" grammar fix
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
805980: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805980
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: needrestart
Version: 2.3-2
Severity: wishlist
Tags: patch

There are two grammar errors in the prompts produced by needrestart:

> Please consider to relogin or restart the affected processes!

The first problem is that "consider" cannot be followed by "to $VERB".
It has to be either "consider $VERBing" or "consider a $NOUN".

The second problem is that there's no such verb as "to relogin".
Indeed, there's no such one-word verb as "to login" - it's separable,
"to log (somebody) in".  "A login" is okay, and you can just about get
away with the noun "a relogin" when it's standing next to "a restart",
but there certainly isn't a gerund form "relogin-ing".

The only option we're left with is:

  Please consider a relogin or restart of the affected processes!

In the process of correcting this message I've made it consistent;
really this string ought to be defined in one place and made
translatable, but that sort of major surgery is a bit more than I can
justify for a grammar nitpick.

Please consider to checkin these changes.

-- Package-specific info:
needrestart output:

checkrestart output:

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (50, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 4.3.0-trunk-686-pae (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages needrestart depends on:
ii  dpkg                       1.18.3
ii  libfile-slurp-perl         9999.19-4
ii  libmodule-find-perl        0.13-1
ii  libmodule-scandeps-perl    1.20-1
ii  libproc-processtable-perl  0.53-1
ii  libsort-naturally-perl     1.03-1
ii  libterm-readkey-perl       2.33-1
ii  perl                       5.20.2-6

needrestart recommends no packages.

Versions of packages needrestart suggests:
pn  needrestart-session | libnotify-bin  <none>

-- no debconf information
-- 
JBR     with qualifications in linguistics, experience as a Debian
        sysadmin, and probably no clue about this particular package
diff -ru needrestart-2.3.pristine/ex/notify.d/200-write needrestart-2.3/ex/notify.d/200-write
--- needrestart-2.3.pristine/ex/notify.d/200-write	2015-09-19 19:38:36.000000000 +0100
+++ needrestart-2.3/ex/notify.d/200-write	2015-11-24 13:10:31.678994711 +0000
@@ -23,7 +23,7 @@
 	{
 	    echo
 	    echo "Your session is running obsolete binaries or libraries as listed below."
-	    echo "Please consider to relogin or restart them!"
+	    echo "Please consider a relogin or restart of the affected processes!"
 	    echo
 	    cat
 	    echo
diff -ru needrestart-2.3.pristine/ex/notify.d/400-notify-send needrestart-2.3/ex/notify.d/400-notify-send
--- needrestart-2.3.pristine/ex/notify.d/400-notify-send	2015-09-19 19:38:36.000000000 +0100
+++ needrestart-2.3/ex/notify.d/400-notify-send	2015-11-24 13:39:49.549460507 +0000
@@ -35,7 +35,7 @@
  	echo "[$0] notify user $NR_USERNAME on $DISPLAY" 1>&2
 
 	MSGTITLE='Relogin or restarts required!'
-	MSGBODY="Your session is running obsolete binaries or libraries as listed below.\n<i><b>Please consider to relogin or restart the affected programs!</b></i>\n\n$(cat)"
+	MSGBODY="Your session is running obsolete binaries or libraries as listed below.\n<i><b>Please consider a relogin or restart of the affected processes!</b></i>\n\n$(cat)"
 
 	su -p -s /bin/sh -c "$NSEND -u critical -i dialog-warning \"$MSGTITLE\" \"$MSGBODY\"" "$NR_USERNAME"
 	;;
diff -ru needrestart-2.3.pristine/ex/notify.d/600-mail needrestart-2.3/ex/notify.d/600-mail
--- needrestart-2.3.pristine/ex/notify.d/600-mail	2015-09-19 19:38:36.000000000 +0100
+++ needrestart-2.3/ex/notify.d/600-mail	2015-11-24 13:07:25.200700726 +0000
@@ -25,7 +25,7 @@
 {
     echo "Your session on host $(hostname -f) ($NR_SESSION) is running obsolete binaries or libraries as listed below."
     echo
-    echo "Please consider to relogin or restart the affected processes!"
+    echo "Please consider a relogin or restart of the affected processes!"
     echo
     cat
 } | fold -s -w 72 | "$MAILX" -s "Relogin or restarts on host $(hostname) required!" "$NR_USERNAME"

--- End Message ---
--- Begin Message ---
Source: needrestart
Source-Version: 2.4-1

We believe that the bug you reported is fixed in the latest version of
needrestart, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Matthäi <[email protected]> (supplier of updated needrestart package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 04 Jan 2016 12:00:42 +0100
Source: needrestart
Binary: needrestart
Architecture: source all
Version: 2.4-1
Distribution: unstable
Urgency: medium
Maintainer: Patrick Matthäi <[email protected]>
Changed-By: Patrick Matthäi <[email protected]>
Description:
 needrestart - check which daemons need to be restarted after library upgrades
Closes: 799898 800718 800720 805980
Changes:
 needrestart (2.4-1) unstable; urgency=medium
 .
   * New upstream release.
     - Add override for systemd-logind due to another systemd regression.
       Closes: #800718
     - Fix grammar in hook scripts.
       Closes: #805980
   * Fix kernel detection on non x86* arch by adding a new depdency on xz-utils.
     Closes: #800720
   * Remove doubled line in long description.
     Closes: #799898
   * Remove libfile-slurp-perl dependency again. It is not required anymore.
Checksums-Sha1:
 63e516b46292fc8376a06da537e47f034b93aea7 1744 needrestart_2.4-1.dsc
 c75646b136a07c97a87010b134f366ccc0b936d4 39181 needrestart_2.4.orig.tar.gz
 d4d8cd20cd3082f408a1ed9f8b68ddef451bd98e 5560 needrestart_2.4-1.debian.tar.xz
 94c5b57615fc07b05e5f8ae797d4e849eefc5b1a 32298 needrestart_2.4-1_all.deb
Checksums-Sha256:
 70b8297eeadede5c0c07eb18c991735e99e5c04f1082d9ee27ffcf93f78bfc4b 1744 
needrestart_2.4-1.dsc
 4fc685dab7ed76dd4cb1e23f9fce217dc8914d9312863d2b56b581abc4c17646 39181 
needrestart_2.4.orig.tar.gz
 6a8856a863f5d83feb728e868b38b00cab0b198557226adaaddd7b9b33a7734b 5560 
needrestart_2.4-1.debian.tar.xz
 97e09d04121e0b075edf402f5052ba12deef41bd8a4885fcad9f618e2349067d 32298 
needrestart_2.4-1_all.deb
Files:
 8aec03c20195f677b4b892fd6556fbd2 1744 admin optional needrestart_2.4-1.dsc
 1b413cadb29c5708bf6ce57c57a8c81b 39181 admin optional 
needrestart_2.4.orig.tar.gz
 d67f06b243926c4c93bf0532411280c5 5560 admin optional 
needrestart_2.4-1.debian.tar.xz
 637a963e5c14855d0b748b1a09a2e7bb 32298 admin optional needrestart_2.4-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWilK7AAoJEBLZsEqQy9jknYIQAKQ2BMGgcSk19xCgOZmNkPhm
91T5mev1qsGF6jny4KJmzmRi2AuMXcbzxuslj0qrXY1sATTHLBypzJCaDLhQxPCD
f7i0jASb6B9csfDYyAJVUDbwgeyRBw2qbMgqv5Dqh7Iv2pm7uTROBgjNvm2NmuNC
57Z8LB7STU0YfTQGu2FOqmkqbBtLQiengqZi59k/g58Hspz8pu+TjVGrVpMEx4wI
9vE7Ci4Pf4NjMJKA/t9Y7vWBU7073iHKrmUhezMwwsCO/0AHFehM5yxGnmakttyR
Oi8MBazwszPDxNAElgoqKj2KriybITnS6qr3LvqzG3FQpGGH1je6aLX9KixBV6Us
xH86ait5yrIZU2ysYrwiYecARzjyUoqCq+ARJ/kpQJ+F253soC4jGA1aTeQhycyN
DgG18KVkF5i4Qv5e3fvEDMpI2OhTDRGxt0y05ZS8VGb/qACrcnLXiGDnzFYPC9IX
5fMEv8P3Lp9yO9np/zrolOMZzT9irMas3N13uoCd+hf0puurbPjlNwAr9TsxTJ5w
MXEOV76EUIrYRxRGbypo8axS8RPxFCAEka6O7GKG7Y87pDDEnI+PQwHWAHTDCTzS
GDi1ne+S6Q28KbRN2fX4WBWlMPaKpST8F7EI8wmb/AZNQ4yzf7ko4AfWJmYPUHdd
psG7YIVJ05CxNban6PIT
=wHFz
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to