Your message dated Sun, 24 Jan 2016 22:05:13 +0000
with message-id <[email protected]>
and subject line pbuilder-uml has been removed, closing bugs
has caused the Debian Bug report #475004,
regarding Support for --debbuildopts in pbuilder-user-mode-linux
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
475004: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=475004
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pbuilder-uml
Version: 0.179
Severity: wishlist
Tags: patch
Hi,
while trying to switch from pbuilder to pbuilder-uml I lack support
option --debbuildopts in pbuilder-user-mode-linux. I tried to figure
out this a bit and to change some snipets of shell code around to
quote options properly. The attached code is only a first idea to get
support for $subject not tested in other modes of pbuilder operation.
I think, the main point is quoting values with printf -v var "%q".
Maybe it can be useful even it is far from its final form. :)
Best Regards
--
Zito
-- System Information:
Debian Release: 4.0
APT prefers stable
APT policy: (990, 'stable'), (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-xen-686
Locale: LANG=C, LC_CTYPE=cs_CZ.ISO-8859-2 (charmap=ISO-8859-2)
Versions of packages pbuilder-uml depends on:
ii pbuilder 0.179 personal package builder for Debia
ii rootstrap 0.3.24-4 A tool for building complete Linux
ii user-mode-linux 2.6.18-1um-2etch.18etch1 User-mode Linux (kernel)
pbuilder-uml recommends no packages.
-- no debconf information
diff --git a/pbuilder-uml-checkparams b/pbuilder-uml-checkparams
index 99d0920..a6ae5ec 100644
--- a/pbuilder-uml-checkparams
+++ b/pbuilder-uml-checkparams
@@ -117,6 +117,10 @@ while [ -n "$1" ] ; do
exit 1
fi
shift; shift;;
+ --debbuildopts)
+ DEBBUILDOPTS="$2";
+ shift; shift;
+ ;;
--logfile)
exec > "$2";
exec 2>&1
diff --git a/pbuilder-user-mode-linux b/pbuilder-user-mode-linux
index 485b1a8..f89c4e2 100755
--- a/pbuilder-user-mode-linux
+++ b/pbuilder-user-mode-linux
@@ -148,7 +148,11 @@ else
mkdir -p ${UML_CHROOT_BUILDRESULTMOUNTDIR} || true
mount -t hostfs none "${UML_CHROOT_BUILDRESULTMOUNTDIR}" -o "${UML_BUILDRESULT}"
fi
-pbuilder "$1" ${UML_EXTRAOPT} \${EXTRAOPT[@]} --buildresult "\${BUILDRESULT}" --buildplace "${UML_CHROOT_MOUNTPOINT}" --internal-build-uml ${UML_DEBUGMODE:+--debug} ${BUILDING_DSC_FILE} ${UML_EXECUTE_EXTRAOPT}
+DEBBUILDOPTS=$(printf %q "${DEBBUILDOPTS}")
+if [ -n "$DEBBUILDOPTS" ]; then
+ echo " -> DEBBUILDOPTS=$DEBBUILDOPTS"
+fi
+pbuilder "$1" ${UML_EXTRAOPT} \${EXTRAOPT[@]} --buildresult "\${BUILDRESULT}" \${DEBBUILDOPTS:+--debbuildopts} \${DEBBUILDOPTS:+"\$DEBBUILDOPTS"} --buildplace "${UML_CHROOT_MOUNTPOINT}" --internal-build-uml ${UML_DEBUGMODE:+--debug} ${BUILDING_DSC_FILE} ${UML_EXECUTE_EXTRAOPT}
echo \$? > /proc/exitcode
if [ -n "\${kernel_modules}" ] ; then
@@ -211,7 +215,10 @@ case "${OPERATION}" in
EXTRACLEANUP=cleancow
fi
shift;
- UML_EXECUTE_EXTRAOPT="${UML_EXECUTE_EXTRAOPT} $@"
+ for arg
+ do
+ printf -v UML_EXECUTE_EXTRAOPT "${UML_EXECUTE_EXTRAOPT} %q" "$arg"
+ done
operate_uml execute
;;
dumpconfig)
diff --git a/pdebuild-user-mode-linux b/pdebuild-user-mode-linux
index 3e441df..a7fcb59 100644
--- a/pdebuild-user-mode-linux
+++ b/pdebuild-user-mode-linux
@@ -37,17 +37,18 @@ ARCHITECTURE=$(dpkg-architecture -qDEB_HOST_ARCH)
if [ "${USE_PDEBUILD_INTERNAL}" = 'yes' ]; then
- if [ ! readlink -f .. ]; then
+ updir=$(readlink -f ..)
+ if [ ! -d "$updir" ]; then
echo "E: Cannot find .. dir from PWD=$(pwd)" >&2
exit 1
fi
- pbuilder-user-mode-linux execute "$@" --bindmounts $(readlink -f ..) /usr/lib/pbuilder/pdebuild-internal ${PWD} --debbuildopts "${DEBBUILDOPTS}"
+ pbuilder-user-mode-linux execute "$@" --bindmounts "$updir" /usr/lib/pbuilder/pdebuild-internal ${PWD} --debbuildopts "${DEBBUILDOPTS}"
else
if ! dpkg-checkbuilddeps -B; then
echo "W: Unmet build-dependency in source" >&2
fi
echo "dpkg-buildpackage -S -us -uc -r${BUILDSOURCEROOTCMD} $DEBBUILDOPTS" | /bin/bash
- pbuilder-user-mode-linux build "$@" --buildresult "${UML_BUILDRESULT}" ../"${PKG_SOURCENAME}_${PKG_VERSION}".dsc
+ pbuilder-user-mode-linux build "$@" --buildresult "${UML_BUILDRESULT}" ${DEBBUILDOPTS:+--debbuildopts} ${DEBBUILDOPTS:+"$DEBBUILDOPTS"} ../"${PKG_SOURCENAME}_${PKG_VERSION}".dsc
fi
# do signing with optional key specifier
--- End Message ---
--- Begin Message ---
Version: 0.222+rm
pbuilder-uml is really not widely used. u-m-l is itself badly
maintained, and broken most of the time, at the point this afternoon I
filed RM bugs to have it completely removed from the archive.
After some consideration I came to the point removing pbuilder-uml was
the right choice. Since pbuilder-uml is not anymore a thing, I'm
closing related bugs.
Thanks for watching, and sorry if this somehow disrupted your workflow
or something.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
--- End Message ---
