Your message dated Fri, 29 Jan 2016 15:38:48 +0100
with message-id <[email protected]>
and subject line Re: Bug#813072: Remove broken ExecStopPost in vboxweb.service
has caused the Debian Bug report #813072,
regarding Remove broken ExecStopPost in vboxweb.service
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
813072: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813072
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: virtualbox
Version: 5.0.14-dfsg-1+b1
Severity: important
File: /lib/systemd/system/vboxweb.service
Tags: patch

Hi,

vboxweb.service contains the following:
ExecStopPost=/usr/bin/rm /run/vboxweb.pid

This is broken in Debian:
$ type rm
rm is /bin/rm


And leads to a failure if you try to stop vboxweb.service:

# systemctl status vboxweb.service 
โ— vboxweb.service - VirtualBox Web Service
   Loaded: loaded (/lib/systemd/system/vboxweb.service; enabled; vendor preset: 
enabled)
   Active: failed (Result: exit-code) since Fr 2016-01-29 05:28:55 CET; 3s ago
  Process: 5499 ExecStopPost=/usr/bin/rm /run/vboxweb.pid (code=exited, 
status=203/EXEC)
  Process: 829 ExecStart=/usr/bin/vboxwebsrv --pidfile /run/vboxweb.pid 
--background (code=exited, status=0/SUCCESS)
 Main PID: 902 (code=killed, signal=TERM)
   CGroup: /system.slice/vboxweb.service
           โ””โ”€944 /usr/lib/virtualbox/VBoxSVC --auto-shutdown

Jan 29 04:09:03 pluto vboxwebsrv[829]: 00:00:00.002146 main     Executable: 
/usr/lib/virtualbox/vboxwebsrv
Jan 29 04:09:03 pluto vboxwebsrv[829]: 00:00:00.002147 main     Process ID: 829
Jan 29 04:09:03 pluto vboxwebsrv[829]: 00:00:00.002148 main     Package type: 
LINUX_64BITS_GENERIC (OSE)
Jan 29 04:09:03 pluto systemd[1]: Started VirtualBox Web Service.
Jan 29 05:28:55 pluto systemd[1]: Stopping VirtualBox Web Service...
Jan 29 05:28:55 pluto systemd[5499]: vboxweb.service: Failed at step EXEC 
spawning /usr/bin/rm: No such file or directory
Jan 29 05:28:55 pluto systemd[1]: vboxweb.service: Control process exited, 
code=exited status=203
Jan 29 05:28:55 pluto systemd[1]: Stopped VirtualBox Web Service.
Jan 29 05:28:55 pluto systemd[1]: vboxweb.service: Unit entered failed state.
Jan 29 05:28:55 pluto systemd[1]: vboxweb.service: Failed with result 
'exit-code'.


The fix is rather simple: Simply drop the ExecStopPost line.
As you can see in the documentation [ยน], systemd will automatically
clean up stale pid files, so there is no need to do that manually.

Trivial patch attached.

Btw, it would be great if /etc/init.d/virtualbox would have an
equivalent systemd service file. Most of the script seems to be about
loading kernel modules. Maybe that can be dropped completely due to
kernel auto-loading or could be replaced by a simple
/usr/lib/modules-load.d/ snippet.

Regards,
Michael


[1] 
http://www.freedesktop.org/software/systemd/man/systemd.service.html#PIDFile=


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages virtualbox depends on:
ii  adduser                               3.113+nmu3
ii  init-system-helpers                   1.27
ii  libc6                                 2.21-7
ii  libcurl3-gnutls                       7.47.0-1
ii  libgcc1                               1:5.3.1-7
ii  libgsoap7                             2.8.22-2
ii  libpng12-0                            1.2.54-1
ii  libpython2.7                          2.7.11-3
ii  libsdl1.2debian                       1.2.15-12
ii  libssl1.0.2                           1.0.2f-2
ii  libstdc++6                            5.3.1-7
ii  libvncserver1                         0.9.10+dfsg-3+b1
ii  libvpx3                               1.5.0-2
ii  libx11-6                              2:1.6.3-1
ii  libxcursor1                           1:1.1.14-1+b1
ii  libxext6                              2:1.3.3-1
ii  libxml2                               2.9.3+dfsg1-1
ii  libxmu6                               2:1.1.2-2
ii  libxt6                                1:1.1.5-1
ii  procps                                2:3.3.11-3
ii  python                                2.7.11-1
ii  python2.7                             2.7.11-3
pn  python:any                            <none>
ii  virtualbox-dkms [virtualbox-modules]  5.0.14-dfsg-1
ii  zlib1g                                1:1.2.8.dfsg-2+b1

Versions of packages virtualbox recommends:
ii  libgl1-mesa-glx [libgl1]  11.1.1-2
ii  libqt4-opengl             4:4.8.7+dfsg-5
ii  libqtcore4                4:4.8.7+dfsg-5
ii  libqtgui4                 4:4.8.7+dfsg-5
ii  virtualbox-qt             5.0.14-dfsg-1+b1

Versions of packages virtualbox suggests:
pn  vde2                            <none>
ii  virtualbox-guest-additions-iso  5.0.14-1

-- no debconf information

--- End Message ---
--- Begin Message ---
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Version: 5.0.14-dfsg-2

I'll try to poke upstream about providing them, and use them in Debian!

thanks a lot :)

Gianfranco
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWq3l1AAoJEPNPCXROn13ZGmwP/17U9c4FckiI5102nbr38ML0
ODsmVypSRDYabyhW8IRWZwuzG7Mj/+c8Wn6RqHlYDHyr/4GYBCUocpfDdllYZgOE
cwyT6aal3P//+FJhnEKgpwsj6qZoRnNznXKKQKWqV34hBviEnijxlYA4zJHl/mlK
5xeFuGPQCrZVaAYxCY/OiwcSDabQH5lZccbft/W15DjcmS9dGmM+p4LnkWA6QQ/+
RCBfgMN+h8kxSS55x8lpvn4VfTVSZcsttyMaMF8Du+1dgqsOJ6+YHGNZ0pgQWMd4
2al/PHF+mvpbG6jDuC/ehKX2GJ/GOLCv0tL/buJ8/v1DTzWuuFBLyYOy19+PQ5tZ
7LbLVQfTUvsFANdzLAEMUhyh+lQpWdZ2qeNwgUHiNbVgoH7zHGP/S402rcbj9NL2
sq2NHFBQk5Wvgq4qUuYpaqbUJVvEbe+vUTRy4xHh/zS0i4JhHpVCSoWTeQx0+rsa
a4Zxw1s0TaW0vD/Bvn2nb6u0RnY2OzcycjwQGUsXtpeKo0IvCOMdy1uCi0JX4XPe
+sUk4OlKbEhG3WQoGCUv5mINIyFnPpjzD89M1xbiJf5zkyFbfXov38EgytMDhyqH
1LU+fgnXwCHNRYZ5qgPEBsY5jT2S1UXM8WwnQ+qf/muSJIT8mTISGl9elQgayTeq
o2J+wBBPM9fdq8YYNE5I
=RNWc
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to