Your message dated Tue, 02 Feb 2016 04:00:32 +0000
with message-id <[email protected]>
and subject line Bug#813254: Removed package(s) from unstable
has caused the Debian Bug report #696278,
regarding gst-plugins-bad0.10: Sets FD_CLOEXEC incorrectly with F_SETFL instead
of F_SETFD
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
696278: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696278
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: gst-plugins-bad0.10
Version: 0.10.23-7
Severity: important
Tags: patch
User: [email protected]
Usertags: fcntl-fd-cloexec
Hi!
This package contains code that tries to set the FD_CLOEXEC flag for a
file descriptor, but it does using F_SETFL instead of F_SETFD.
Using that value on F_SETFL is just wrong, and might make the call fail
on some systems, as it's requesting to set an undetermined flag. For
example on GNU/* FD_CLOEXEC has value 1, which matches with O_WRONLY.
This might cause the code to at least leak file descriptors, and at
worst to terminate execution.
Attached a patch fixing this.
Thanks,
Guillem
From 748201b0b25ee15e8e84c94fce17ff3ec85ab21d Mon Sep 17 00:00:00 2001
From: Guillem Jover <[email protected]>
Date: Tue, 18 Dec 2012 18:22:39 +0100
Subject: [PATCH] gst-plugins-bad0.10: Set FD_CLOEXEC correctly using F_SETFD
not F_SETFL
Using that value on F_SETFL is just wrong, and might make the call fail
on some systems, as it's requesting to set an undetermined flag. For
example on GNU/* FD_CLOEXEC has value 1, which matches with O_WRONLY.
This might cause the code to at least leak file descriptors, and at worst
to terminate execution.
---
sys/shm/shmpipe.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/sys/shm/shmpipe.c b/sys/shm/shmpipe.c
index 583aa38..65f50f2 100644
--- a/sys/shm/shmpipe.c
+++ b/sys/shm/shmpipe.c
@@ -209,9 +209,16 @@ sp_writer_create (const char *path, size_t size, mode_t perms)
if (flags < 0)
RETURN_ERROR ("fcntl(F_GETFL) failed (%d): %s\n", errno, strerror (errno));
- if (fcntl (self->main_socket, F_SETFL, flags | O_NONBLOCK | FD_CLOEXEC) < 0)
+ if (fcntl (self->main_socket, F_SETFL, flags | O_NONBLOCK) < 0)
RETURN_ERROR ("fcntl(F_SETFL) failed (%d): %s\n", errno, strerror (errno));
+ flags = fcntl (self->main_socket, F_GETFD, 0);
+ if (flags < 0)
+ RETURN_ERROR ("fcntl(F_GETFD) failed (%d): %s\n", errno, strerror (errno));
+
+ if (fcntl (self->main_socket, F_SETFD, flags | FD_CLOEXEC) < 0)
+ RETURN_ERROR ("fcntl(F_SETFD) failed (%d): %s\n", errno, strerror (errno));
+
sock_un.sun_family = AF_UNIX;
strncpy (sock_un.sun_path, path, sizeof (sock_un.sun_path) - 1);
--
1.8.1.rc0
--- End Message ---
--- Begin Message ---
Version: 0.10.23-8.1+rm
Dear submitter,
as the package gst-plugins-bad0.10 has just been removed from the Debian archive
unstable we hereby close the associated bug reports. We are sorry
that we couldn't deal with your issue properly.
For details on the removal, please see https://bugs.debian.org/813254
The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.
This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].
Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)
--- End Message ---
