Your message dated Mon, 7 Mar 2016 19:42:21 -0500
with message-id <20160308004221.GA27498@jasmine>
and subject line Re: [Reproducible-builds] Bug#815844: diffoscope won't build
without python-magic from PyPi
has caused the Debian Bug report #815844,
regarding diffoscope won't build without python-magic from PyPi
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
815844: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815844
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: diffoscope
Dear Maintainer,
I am maintaining the diffoscope package in GNU Guix [0].
I recently updated from version 34 to 49, and found that I could not
build diffoscope from source without the python-magic package from PyPi
[1].
However, diffoscope's README [2] says that:
``Magic-file-extension`` can be used instead of
``python-magic``. It is built from `file
<http://www.darwinsys.com/file/>`_.
Available on Debian and Fedora as ``python3-magic``.
I removed the requirement of python-magic from setup.py and built
against the Python bindings distributed with `file`, as packaged in Guix
[3]. Diffoscope seems to work just fine this way.
I even confirmed, with strace, that diffoscope was using libmagic from
`file`.
Will you consider making python-magic an optional dependency of
diffoscope, so that downstream packagers don't have to package
python-magic from PyPi or work around this issue by patching setup.py?
[0]
https://www.gnu.org/software/guix/package-list.html#diffoscope
[1]
https://pypi.python.org/pypi/python-magic/
[2]
https://anonscm.debian.org/cgit/reproducible/diffoscope.git/tree/README.rst#n58
[3]
https://www.gnu.org/software/guix/package-list.html#python-file
--- End Message ---
--- Begin Message ---
On Thu, Feb 25, 2016 at 01:49:24PM +0100, Jérémy Bobbio wrote:
> Leo Famulari:
> > However, diffoscope's README [2] says that:
> >
> > ``Magic-file-extension`` can be used instead of
> > ``python-magic``. It is built from `file
> > <http://www.darwinsys.com/file/>`_.
> > Available on Debian and Fedora as ``python3-magic``.
> >
> > I removed the requirement of python-magic from setup.py and built
> > against the Python bindings distributed with `file`, as packaged in Guix
> > [3]. Diffoscope seems to work just fine this way.
>
> Indeed. That's how it works in Debian.
>
> > Will you consider making python-magic an optional dependency of
> > diffoscope, so that downstream packagers don't have to package
> > python-magic from PyPi or work around this issue by patching setup.py?
>
> I have no idea how you can specify alternate dependencies in setup.py or
> if that's possible. If you find a solution I guess someone could apply a
> patch.
I spent some time researching this and didn't find a satisfactory
solution.
>
> If that's not possible, I believe that carrying a one-liner in Guix is
> not unreasonable.
Yes, it seems to be working fine for us.
It would be helpful to add a comment explaining that python-magic is
actually not required if you have built the Python bindings of file.
--- End Message ---
