Your message dated Wed, 23 Mar 2016 21:51:55 +0000 with message-id <[email protected]> and subject line Bug#818051: fixed in nethack 3.6.0-2 has caused the Debian Bug report #818051, regarding nethack-console: abnormal behavior of HP monitor to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 818051: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818051 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: nethack-console Version: 3.6.0-1 Severity: minor Tags: patch Dear Maintainer, Two problems with HP monitor. 1. In a game with "hpmon" option enabled, if the bottom line look like below Dlvl:1 $:0 HP:14(16) Pw:2(2) AC:8 Exp:1 then "14(16)" should be green; further lower the HP, the color should turn to yellow, then red and finally orange. However in 3.6.0-1, in this case, the "(" in the "Pw:2(2)" have color and change its color when HP changes. In some other case, the "(" may also lose color; in some other case, the number between "Pw" and "(" may have color too. I have recorded a case using script(1); if it is needed, I can send the typescript file and timing file here. After applied the attached patch and rebuilded the package, this problem disappeared. Possible cause: In 3.6.0 the gold symbol in the bottom line may be a encoded glyph, so putmixed() is used to write the bottom line. But the code in the HP monitor patch still use putstr() so that may cause the output incorrect. 2. In the options list displayed by the "O" command, "hpmon" option is between "extmenu" and "fixinv". Since the option list is sorted, the correct position of "hpmon" should be between "hilite_pile" and "ignintr". The attached patch also contains a fix of this problem. Regards, Jun MO -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.4.0-1-amd64 (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Init: unable to detect Versions of packages nethack-console depends on: ii libc6 2.22-3 ii libncurses5 6.0+20160213-1 ii libtinfo5 6.0+20160213-1 ii nethack-common 3.6.0-1 nethack-console recommends no packages. nethack-console suggests no packages. -- no debconf information--- a/src/botl.c +++ b/src/botl.c @@ -100,7 +100,7 @@ hp, hpmax, u.uen, u.uenmax, u.uac); #else curs(WIN_STATUS, 1, 1); - putstr(WIN_STATUS, 0, newbot2); + putmixed(WIN_STATUS, 0, newbot2); Sprintf(nb = eos(newbot2), "%d(%d)", hp, hpmax); #if defined(TEXTCOLOR) && !defined(LISP_GRAPHICS) @@ -121,7 +121,7 @@ if (hpcolor != NO_COLOR) term_start_color(hpcolor); if(hpattr!=ATR_NONE)term_start_attr(hpattr); - putstr(WIN_STATUS, hpattr, newbot2); + putmixed(WIN_STATUS, hpattr, newbot2); if(hpattr!=ATR_NONE)term_end_attr(hpattr); if (hpcolor != NO_COLOR) term_end_color(); --- a/src/options.c +++ b/src/options.c @@ -112,9 +112,6 @@ #else { "extmenu", (boolean *) 0, FALSE, SET_IN_FILE }, #endif -#if defined(TEXTCOLOR) && defined(HPMON) - { "hpmon", &iflags.use_hpmon, FALSE, SET_IN_GAME}, -#endif #ifdef OPT_DISPMAP { "fast_map", &flags.fast_map, TRUE, SET_IN_GAME }, #else @@ -131,6 +128,9 @@ { "help", &flags.help, TRUE, SET_IN_GAME }, { "hilite_pet", &iflags.wc_hilite_pet, FALSE, SET_IN_GAME }, /*WC*/ { "hilite_pile", &iflags.hilite_pile, FALSE, SET_IN_GAME }, +#if defined(TEXTCOLOR) && defined(HPMON) + { "hpmon", &iflags.use_hpmon, FALSE, SET_IN_GAME}, +#endif #ifndef MAC { "ignintr", &flags.ignintr, FALSE, SET_IN_GAME }, #else
--- End Message ---
--- Begin Message ---Source: nethack Source-Version: 3.6.0-2 We believe that the bug you reported is fixed in the latest version of nethack, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. James Cowgill <[email protected]> (supplier of updated nethack package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Mon, 21 Mar 2016 14:51:35 +0000 Source: nethack Binary: nethack-common nethack-console nethack-lisp nethack-x11 Architecture: source Version: 3.6.0-2 Distribution: unstable Urgency: medium Maintainer: Debian Games Team <[email protected]> Changed-By: James Cowgill <[email protected]> Description: nethack-common - dungeon crawl game - common files nethack-console - dungeon crawl game - text-based interface nethack-lisp - dungeon crawl game - Lisp interface nethack-x11 - dungeon crawl game - X11 interface Closes: 817972 818051 818128 Changes: nethack (3.6.0-2) unstable; urgency=medium . [ James Cowgill ] * Remove more remnants of the curses interface from d/rules. * Remove obsolete $(EXTRA_$1) argument from d/rules. * Install symbols data file. (Closes: #817972) * Add semicolon to the end of lists in the desktop files to fix validation errors. * Add StartupWMClass to nethack-x11.desktop to fix grouping in some DEs. . [ Reiner Herrmann ] * Add patch to enable reproducible building. (Closes: #818128) * Manually build makedefs before the rest of the game to avoid a race confition in the build system. . [ Mo Jun ] * Fix abnormal behavior in the HP monitor patch. (Closes: #818051) Checksums-Sha1: f07e9a35b5bd4f2551470d365773ef786d503aab 2286 nethack_3.6.0-2.dsc c2c1d6b35bd15f768d9a904e23a2508e1c40666a 68432 nethack_3.6.0-2.debian.tar.xz Checksums-Sha256: e586f82e6fb37e526f161d51068e0cffeec7c7f026c34b676504d3cee91289f2 2286 nethack_3.6.0-2.dsc 45ee3e36dc4560e8f4ec2dbeb9c3e485074ab3cb5492fbb680480b4d52f8bcae 68432 nethack_3.6.0-2.debian.tar.xz Files: 1d3d404a8c009544cb690fdf96d7720b 2286 games optional nethack_3.6.0-2.dsc 027ecd1ef61d30a51c1dc236716eb8dc 68432 games optional nethack_3.6.0-2.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW8v93AAoJEMfxZ23qLQHv1gEQAK4zrQ3bZQ7DFlcHJx3uH8MK 1eAZMHSXxdUw8xJ5AATuAgmO5Q9XKrPfqUYkv/CqUXGYm6QGdnKxspDrGSSW4XdJ uviB7rgjks5GoI/NzKClmkiKhMyQZvhz7dmfKBOmgIUhpWkZ3MFIAkiWiFeEm+W8 qwv7NwO+BpQDpULUcKi8HVa1p9pNodhArpYKecuQCplhQVBUupgFnp7lqp/OSDcG a18oXpPWMzXi6CCAVX6wRL92HxUjvtfhgMN9N05bn31si81GPsGucK1rA9K/1KG0 2YHBonRpqhW9Ah7DF48VnR1tOyAkk7QvReucZa2s2kGJ2PKCmzDKy1MfPsX9FQ/K hmPvv7jIHgwUgOYJjGDQRDjtH/GAMGFtyAFF7AXhk3EMaOp2eGJXOG0aFvTCSOpD Ywo0/OLdryo1tzmpPN4DG/StJJydOj/Kar3d3FNquKtFZ/Yt0oWx78s4WvurXNm2 FO+cw+RUIfvvTY4tLkax5EEzSexKtM1j2gX/v+/pke/VuUdirvFNMEGXhGabYcit SSll7Hv6PzLfmvYYsGBKJUPYoRvbDcrilWCgeb7fbbIYifDX6n2VIBg+XupwEBEx p1lfpJGT1b0aGB1nCJcsuYayjJGN47c6SZ+errsN+LI77fsPKjbxpCR6yhbtI6Wo yOmvzyyS5MYKZkQJo9xD =yfZj -----END PGP SIGNATURE-----
--- End Message ---
