Your message dated Mon, 04 Apr 2016 07:35:27 +0000
with message-id <[email protected]>
and subject line Bug#818312: fixed in ukolovnik 1.5-1
has caused the Debian Bug report #818312,
regarding ukolovnik: please don't use "if ! dbc_go" in your maintainer scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
818312: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818312
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ukolovnik
Version: 1.4-2
Severity: wishlist

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear maintainer,

According to codesearch¹ you are using the following construction in one or
more of your maintainer scripts:
if ! dbc_go <package_name> $@ ; then
    echo 'Automatic configuration using dbconfig-common failed!'
fi

I feel that I must explain to you why this is most likely not working as you
intended and additionally caused me quite some debugging time a while ago.

The main point is that maintainer scripts are strongly recommended to "set -e"
at the beginning of the scripts by the Debian Policy². However, if you use
constructions like "if" or "||" than the "set -e" don't propagate to the called
scripts or functions, errors in the scripts or functions are ignored and the
script continues. In the past (before version 2.0.0) dbconfig-common error
handling used to rely on the behavior of "set -e" (which of course can be
questioned, because it may not be set). Ironically that means that before
version 2.0.0 you never observed the text that you included in the echo
statement in your script.

Now, in case of errors, the error handling of dbconfig-common asks the
administrator how to proceed after the error with the
installation/configuration/removal/purging of the package. One of the options
is to abort, which is described as follows:

  * abort - Causes the operation to fail; you will need to downgrade,
    reinstall, reconfigure this package, or otherwise manually intervene
    to continue using it. This will usually also impact your ability to
    install other packages until the installation failure is resolved.

By using the "if !dbc_go" statement you are ignoring the wish of the
administrator, albeit it being the default answer. I kindly request to not use
the construction anymore. If you must, I suggest you change the answer to the
error questions to "ignore" (but please don't set the question as "seen").

Because the dbconfig-common files are sourced, I currently believe it is
incorrect to "set -e" in the dbconfig-common files.

Paul
Current maintainer of dbconfig-common

¹ https://codesearch.debian.net/perpackage-results/!%20dbc_go/2/page_0
² https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s6.1

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJW6Gg9AAoJEJxcmesFvXUKX4sH/2i+soTkPWQ99UlSSTfD/wI1
pqRFqWAsZUaTcy1tPakUxPPKtyrhuUAr8Qen6SyjeeGITJIJ2Dzz83OBr8QizilT
cmE6+aIfN/WCZ0vc9d9j+3YiBiYy3hNL09lJu5kuGiB8vFBZaGsjqk9Q7QRYducO
kdKRwjD8fmHo8vw2syPsnIVk+Paj9dmfJE9Ll90IgOqQX1CoiEogvAjoN8NxWljU
K3USAUcWPeFf8PQjceN+q0dgw3qqs1bzJp/lGAt03IA4DqOHi9OV7wsu2yS4X0Bh
xM0dNIhya1lVRv0tVjQBntH/eeMaphZJT/8AwiVUt3I5if/Z+ggVB9s9pFzPm3k=
=A57U
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message ---
Source: ukolovnik
Source-Version: 1.5-1

We believe that the bug you reported is fixed in the latest version of
ukolovnik, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michal Čihař <[email protected]> (supplier of updated ukolovnik package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 04 Apr 2016 09:24:46 +0200
Source: ukolovnik
Binary: ukolovnik
Architecture: source all
Version: 1.5-1
Distribution: unstable
Urgency: medium
Maintainer: Michal Čihař <[email protected]>
Changed-By: Michal Čihař <[email protected]>
Description:
 ukolovnik  - Simple todo manager using PHP and MySQL
Closes: 669783 818312
Changes:
 ukolovnik (1.5-1) unstable; urgency=medium
 .
   * New upstream release.
   * Update Catalan debconf translation.
   * Bump standards to 3.9.7.
   * Let dbconfig-common handle error states (Closes: #818312).
   * Update Dutch debconf translation.
   * Apache 2.4 compatibility (Closes: #669783).
   * PHP 7.0 compatibility.
   * Update debian/copyright to match upstream change to GPL3 and use machine
     readable format.
Checksums-Sha1:
 e21c3a6ae23b23de5211afcf3d278dc0291f5bcc 1819 ukolovnik_1.5-1.dsc
 a323097b078f30798eecb5cac46be7d7dada6a08 84162 ukolovnik_1.5.orig.tar.gz
 a9bb349cc4cf9d2bb3156be94dabe394f1eb06d2 9512 ukolovnik_1.5-1.debian.tar.xz
 4d0d2e76dfebcb9fc4d1ec372996ce0cd43b8bfa 46280 ukolovnik_1.5-1_all.deb
Checksums-Sha256:
 cf53102d830a549b3c24c23ddb5b6d3816fadfed9231e5f295738bc7575186cd 1819 
ukolovnik_1.5-1.dsc
 0aae96cfb0f1f4bac603f4bd31b4f80f7aa18a7ff93956d93536ce7297d2118e 84162 
ukolovnik_1.5.orig.tar.gz
 0a0589e20b1206ab1bfa153ed6a12f4b0bc5bf7240db9f1c1a518c35e5273a73 9512 
ukolovnik_1.5-1.debian.tar.xz
 c4032ff381272573fb622eccf65114c6f373a41b5bd1a085c6bc8303e2bd7aab 46280 
ukolovnik_1.5-1_all.deb
Files:
 291a9500b9f557641d9315d0bb634058 1819 web extra ukolovnik_1.5-1.dsc
 399d0e0098a0eb13dedf41d4fd7e9bc3 84162 web extra ukolovnik_1.5.orig.tar.gz
 ef4a5443baa1e33065f1b4f121c09eb6 9512 web extra ukolovnik_1.5-1.debian.tar.xz
 0049cb3c212585fcc71cb7fd9efaa113 46280 web extra ukolovnik_1.5-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXAhb3AAoJEJwnsxNCt1Ed75wP/3XIDBhO+dVAIvH5mPc+MUkc
NdV8oG/4KfUr2cJkTGj+AlriL6KC9XGGDsCY+9CaSiqsRMOTF2Q0ndw52nLu6dF9
L/244sZCdpxFImrLxvU8sJinQILwlr64J5U5tbkdkiecQxm++9AeJmJDUxZUPwy8
G8BJ/aUVb84YeqVaQNyqtFdx8iaJzniNTNyFyW31ui/dsKMYaNsN+QqGI/s4IASq
c+Ew20o6u7vKcMfGSkD5x3cKC2mkCiRmtaFo5XBV/FBXXvHYS6Iv5t/ENiwoGR2m
1SO+W9Slgs+jyh9z92SvgZxd1v05p5lGCqRILi3vZc6yY3NdYDIBJBlCHDxQVVlP
nndOxPzEgCboMrMmP+Pi+uIDWe7bauUgiYgQWOXTUf3d7CVUwd31gjbb4AX47rnv
4IPeseVNLDelNTmw+07uO5O7GlHZha2gX00Q2Sde8l7zWK9KeqjNmj4G+XRqUBK1
WUXxaOx0ppFYM/yyj7Xb28Kt5my389jLD5JE6UGfU1cTqLzhz6bVj9SDGJynyG09
g9XIuNlbTydA6w7276Pb8JZHqLRhRMVkOiS2zPVarfb0dMEXA+OyDYR63C2PWA/y
0WkEaLVFGWMiAAe87cYzOu5zZUClb5yWTuZ0alaNyntJ4i/tpLg7/6j4VGzLs+kO
xzbPG3zQ75j9lZL9XmBT
=+YLD
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to