Your message dated Thu, 14 Apr 2016 07:19:05 +0000
with message-id <[email protected]>
and subject line Bug#819596: fixed in dh-golang 1.13
has caused the Debian Bug report #819596,
regarding dh-golang: fails when golang-go:native is included in Build-Depends
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
819596: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819596
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-golang
Version: 1.12
Severity: important
Tags: patch
Building the git-lfs debian package I have found a bug in dh-golang
1.12. The build depends line for the package
(https://github.com/github/git-lfs) is:
Build-Depends: debhelper (>= 9), dh-golang, golang-go:native (>= 1.3.0),
git (>= 1.8.2), ruby-ronn
This causes the following error when building the package:
dh_golang -O--buildsystem=golang
Can't call method "get_deps" on an undefined value at /usr/bin/dh_golang
line 114.
debian/rules:18: recipe for target 'binary' failed
make: *** [binary] Error 255
dpkg-buildpackage: error: debian/rules binary gave error exit status 2
When running dh-golang by hand the error is:
-e: warning: can't parse dependency golang-go:native (>= 1.3.0)
The error occurs because dh_golang calls deps_parse in Dpkg::Deps which
fails on the "native" architecture. This happens because that arch is
only allowed on build-depends lines, not depends. In the manpage for
Dpkg::Deps, one of the flags listed for deps_parse is:
build_dep (defaults to 0)
If set to 1, allow build-dep only arch qualifiers, that is
“:native”. This should be set whenever working with build-deps.
Setting this flag on the deps_parse command fixes the issue. Patch is
attached.
-- System Information:
Debian Release: 8.2
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages dh-golang depends on:
ii debhelper 9.20150101
ii dpkg 1.17.25
ii libdpkg-perl 1.17.25
ii perl 5.20.2-3+deb8u1
dh-golang recommends no packages.
dh-golang suggests no packages.
-- no debconf information
diff --git a/script/dh_golang b/script/dh_golang
index fad7998..1eb0922 100755
--- a/script/dh_golang
+++ b/script/dh_golang
@@ -106,7 +106,7 @@ if (defined($build_depends) && $build_depends ne '') {
die 'Unexpected object (of type ' . blessed($dep) . '), has the Dpkg::Deps API changed?';
}
- my $deps = deps_parse($build_depends, reduce_restrictions => 1);
+ my $deps = deps_parse($build_depends, reduce_restrictions => 1, build_dep => 1);
my $golang_deps = join(' ', grep { /^golang-/ }
map { flatten($_) }
$deps->get_deps());
--- End Message ---
--- Begin Message ---
Source: dh-golang
Source-Version: 1.13
We believe that the bug you reported is fixed in the latest version of
dh-golang, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Stapelberg <[email protected]> (supplier of updated dh-golang
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 14 Apr 2016 08:51:20 +0200
Source: dh-golang
Binary: dh-golang
Architecture: source all
Version: 1.13
Distribution: unstable
Urgency: medium
Maintainer: Michael Stapelberg <[email protected]>
Changed-By: Michael Stapelberg <[email protected]>
Description:
dh-golang - debhelper add-on for packaging software written in Go (golang)
Closes: 819596
Changes:
dh-golang (1.13) unstable; urgency=medium
.
[ Stephen Gelman ]
* Set build_dep to 1 to support the “native” architecture (Closes: #819596)
Checksums-Sha1:
3e3bfc822ec746c381fa13f1a9cbc00ed5902323 1559 dh-golang_1.13.dsc
5d0a68c989596e6a731eb2c6b0c0ec7985a0e491 6780 dh-golang_1.13.tar.xz
df75591f2a0339699281cd467cb7c0f24bef3fbb 8726 dh-golang_1.13_all.deb
Checksums-Sha256:
ca7933f78275b37bfb5d1196d52a9e17670418e5114ad48d23b9b05af8fc12d3 1559
dh-golang_1.13.dsc
6f535251d78c3ab96bd74270500cdf4dce00b6530e0f12294713e1464d95711f 6780
dh-golang_1.13.tar.xz
f5ae2f1e2c1f327afc8b11f30008e9cc22944edbcd5e77631c58be39b78776f9 8726
dh-golang_1.13_all.deb
Files:
29e6a25843bb861463188f5566667c23 1559 devel extra dh-golang_1.13.dsc
14f0f5e090a90878f29ec9c084250502 6780 devel extra dh-golang_1.13.tar.xz
98f7418e91bcb6dab480413d16376cea 8726 devel extra dh-golang_1.13_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJXDz59AAoJEE5xYO1KyO4dzosQALIGOhtd63ulNZlz2LtPUWDm
0d0Q343ootEY5kXcZ41COXJ2Cs2HKJUpZ1/2N6wWC4Y9VAl8fiFMqjk0vlnjHAUi
8Ygt48CYYZzB9GI9qAeVyXY9suIX7jdBckQrDXyDkWYeZ9d6Kb+R22Mxnsc9dbd5
jjn0w67mDZ4dctN1vSeYYnlBU2sDwHKuBPtx5bCFyIJdcytCxg7OdQmqUdqR5S0u
uZfGYj45+2E/RClf8yEkvq2HJCcW01u8tRrhzmanq8CgDV9NBQED7IM1Qq1xHt5X
CFjV5LbJnwxjbji19smU4oSmIP7wLS7p24mTSbb+1bN/D5ClKVDoi3C/wtKizgp2
LX28yRqFHRVYtd4RRgyKWeelKghEQBL0KyylSWyEeB17UjYDOn23islGfcXO7j+I
aQ/UDgSwH5n+KX1WmmBBXrjyL5Ty4vvUrG6YpMmpu7fAfdGkVdIZA4CotNYm7NZA
0efkmLWYt5IHFYwx+Z7IU36XwTkqqohs/k4Uwk+fdNZv9RW3GMNcSLcQ4tnfE9H5
tDM9+dq+s06ZYEBL/Eydl6ZyNrN+6k81dVXQYkpDMF0zmwJOjTGPECGOeoNkN50F
yI8kkRtJUiFGay0I+NnYLOh1UvcPvhdH8VYfOq8wOsdsd975bdSmsW2Nk7wFXpvq
OfbuxazkIDFkO7rqC4C3
=gmKl
-----END PGP SIGNATURE-----
--- End Message ---
