Your message dated Mon, 25 Apr 2016 17:52:44 +0200 with message-id <[email protected]> and subject line Re: btrfs-tools: command line arguments get eaten has caused the Debian Bug report #739246, regarding btrfs-tools: command line arguments get eaten to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 739246: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739246 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: btrfs-tools Version: 0.19+20120328-7.1 Severity: important The btrfsck from the Wheezy btrfs-tools package doesn't handle command line arguments properly, e.g. > # btrfsck -f /dev/vdb1 || echo fail btrfsck: invalid option -- 'f' usage: btrfsck dev Btrfs Btrfs v0.19 fail # btrfsck -a -f /dev/vdb1 || echo fail Btrfs Btrfs v0.19 # btrfsck -a dummy /dev/vdb1 || echo fail Btrfs Btrfs v0.19 # < The argument after -a gets obviously eaten. -f should cause an error, as 'dummy' should. (The combination -a -f is used in the /etc/init.d/checkroot.sh and /etc/init.d/checkfs.sh scripts.) Note: The Jessie and later packages moved the code from btrfsck.c code to btrfs.c, along with a very different argument parsing. I haven't checked but those versions are probably not affected. Cheers, Julius -- System Information: Debian Release: 7.4 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---Version: 3.17-1.1 Hi Nicholas, --[ Nicholas D Steeves <[email protected]> 2016-04-25 13:17:10 +0200 ] > Have you had a chance to see if this was fixed in > btrfs-tools-3.17-1.1~bpo70+1? The new command is: btrfs check > /dev/vdb1 The host in question is gone a longer time ago, thus I'm testing on a newly installed VM with Jessie point release 8.4. The used btrfs-tools version is 3.17-1.1, which seems to be equivalent to the wheezy-backports package. Observations: 1) the /etc/init.d/checkroot.sh does no longer try to fsck a btrfs root file system 2) btrfsck is marked as deprecated in the man page 3) btrfsck -f leads an 'invalid option' error 4) btrfsck -a foobar leads an 'too many arguments' error 5) btrfsck -a changes nothing, it simply gets ignored, which is not really documented but in the source code: btrfs-tools-3.17/cmds-check.c:7589 case 'a': /* ignored */ break; 6) btrfs check -f leads an 'invalid option' error 7) btrfs check -a foobar leads an 'too many arguments' error 8) btrfs check -a leads an 'too many arguments' error This bug is about 4), which is confirmed to be fixed. 5) is inconsistent, but since btrfsck is deprecated (see 2)) and btrfs check does the thing (see 7)) and it is no longer used wrongly (see 1)), I'd suggest to ignore that point. Regards, Julius
--- End Message ---
