Your message dated Tue, 03 May 2016 10:19:40 +0000
with message-id <[email protected]>
and subject line Bug#822947: fixed in dh-haskell 0.2
has caused the Debian Bug report #822947,
regarding dh-haskell: breaks when dpkg-buildflags returns multiple flags in 
LDFLAGS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
822947: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822947
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-haskell
Version: 0.1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu yakkety ubuntu-patch

On Ubuntu, "dpkg-buildflags --get LDFLAGS" defaults to
"-Wl,-Bsymbolic-functions -Wl,-z,relro".  dh-haskell's handling of the
output of LDFLAGS is buggy in that it only works correctly when a single
flag is returned (I think it probably even breaks if LDFLAGS is empty).
This results in errors such as:

  [1 of 5] Compiling Data.These       ( Data/These.hs, 
dist-ghc/build/Data/These.p_o )
  /usr/bin/ld: unrecognized option '-Bsymbolic-functions -Wl'
  /usr/bin/ld: use the --help option for usage information
  collect2: error: ld returned 1 exit status

Patch follows.

diff --git a/lib/Debian/Debhelper/Buildsystem/haskell.pm 
b/lib/Debian/Debhelper/Buildsystem/haskell.pm
index aabed89..4bc85fa 100644
--- a/lib/Debian/Debhelper/Buildsystem/haskell.pm
+++ b/lib/Debian/Debhelper/Buildsystem/haskell.pm
@@ -321,7 +321,9 @@ ghc, that harden generated binaries and fix corresponding 
lintian warning.
 =cut
 
 sub ghc_linker_flags {
-    my @link_flags = `dpkg-buildflags --get LDFLAGS` or die $!;
+    my $link_flags = `dpkg-buildflags --get LDFLAGS` or die $!;
+    chomp $link_flags;
+    my @link_flags = split " ", $link_flags;
     return map "--ghc-option=-optl$_", @link_flags;
 }
 

Thanks,

-- 
Colin Watson                                       [[email protected]]

--- End Message ---
--- Begin Message ---
Source: dh-haskell
Source-Version: 0.2

We believe that the bug you reported is fixed in the latest version of
dh-haskell, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Bogatov <[email protected]> (supplier of updated dh-haskell package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 08 Apr 2016 12:47:00 +0300
Source: dh-haskell
Binary: dh-haskell
Architecture: source
Version: 0.2
Distribution: unstable
Urgency: medium
Maintainer: Dmitry Bogatov <[email protected]>
Changed-By: Dmitry Bogatov <[email protected]>
Description:
 dh-haskell - debhelper add-on for packaging software written in Haskell
Closes: 820406 822947
Changes:
 dh-haskell (0.2) unstable; urgency=medium
 .
   * Correctly handle packages without library. (Closes: #820406)
     Patch is inspired by one, provided by Neil Mayhew.
   * Fix handling of multiple flags, returned by `dpkg-buildflags'.
     (Closes: #822947) Patch provided by Colin Watson ([email protected]).
   * Bump standards version to 3.9.8 (no changes needed)
   * Fix debian/copyright syntax
   * Use secure uri in Vcs-Git field
   * Fix spelling errors
   * Fix wrong links in debian/control
Checksums-Sha1:
 086fc82db26aed6c3102ac33dcdb639eec84f9aa 1653 dh-haskell_0.2.dsc
 8fb38fd0a4ee5ee0b61c0622087f332a4e32e985 10240 dh-haskell_0.2.tar.xz
Checksums-Sha256:
 c9d723f74263ab1b0af582fc8417507ff315b13115a0e8bd5262ee1b5ea09e01 1653 
dh-haskell_0.2.dsc
 a1dcb8ffcb79bd6440917af6ff0fb0dce783c2d8657134a60a98edf315ff66ca 10240 
dh-haskell_0.2.tar.xz
Files:
 72ef17f9727167247be3d126c578bf4a 1653 devel optional dh-haskell_0.2.dsc
 06d9f7a35c480749129f0cca17088e22 10240 devel optional dh-haskell_0.2.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKF2xAAoJEPNPCXROn13Z2nwP/RF8VzXS+tUIYXBtcvxzlPd9
vXKz5PW0hkOWawm0/P3jFuYFI4J6GpOaXB1tDTx1bTu2o5g+sti2CgpYWTtbK+za
TtyMiX+uLY3WJ/I3TAvVSOc1XHY9ybS+8WeUuFj+ufgq6GEnHUz4BpBzmaqX/6yu
eyJqGX0BzRdsHD5a6dKO2Hbm2WWHNXrPeZ5xI5eNZC37ZLzuqEiDp3GUWtspcpR3
muFvH0Y2ai+ggmY23fBdL5A/z2j2IDm4n2iZflnxKAqj5b/CWodp0Ul+mthF2kZu
Z2gRyhmOmokOUIGt9BAoAymQt2XxqeLvJMwId19KDdpy/T9FPqo18jY7UbWnw+EM
Eu1Wn2btVBRBNkB9wEhQriJDkhYa7evEBOHWSO96EFTygvNgKGK2MgG/JAdn9jm6
Zuo4ZzGi+iicYHHAIchqCwR9HymXhxz4x72y87OM6rXUG/+DPdYVE8LJSaLFoIU+
gs9XY6VnhxP9I13SWJICZpo1RgeU0PcbW5I5bV1dGq0KLE7DOU5dfv0TqyIpXa3K
W9bhLC2aCtIqUP2ZLZMWQPnKAuChOaPLJ43kBCfEzIqVS8UVKTsilvfhfQaMkGY3
xX8p2fuOPA3bPuh8dyJk4aY2RJk4GP8MPeXuDA37S6Ilm9ceEA1JAyyQ6iJCOBG5
dsAGi1u5pXgMoQT6VbJX
=jLhF
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to