Your message dated Tue, 05 Jul 2016 15:09:30 +0200
with message-id <[email protected]>
and subject line Re: Bug#829667: License headers
has caused the Debian Bug report #829667,
regarding License headers
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
829667: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829667
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: licensecheck
Version: 3.0.1
The following issue was raised during review of the Fedora package [1]:
These source files are without license headers:
App-Licensecheck-v3.0.1/bin/licensecheck
App-Licensecheck-v3.0.1/lib/App/Licensecheck.pm
Please, ask to upstream to confirm the
licensing of code and/or content/s, and ask to add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification
COPYRIGHT states clearly that bin/licensecheck and lib/App/Licensecheck.pm are
GPL-3.0, but it would not harm to add license headers also?
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1352667#c5
--- End Message ---
--- Begin Message ---
Quoting Sandro Mani (2016-07-05 14:15:26)
> On 05.07.2016 12:56, Jonas Smedegaard wrote:
> > Thanks for elaborating on how Fedora uses licensecheck for quality
> > assurance. I appreciate your contacting upstreams to ensure that
> > licensing statements are unambiguous and embedded in each file where
> > copyright is claimed. But instead of suggesting upstreams to
> > conform to the more strict principle of putting licensing statements
> > at the top of each file, I recommend that instead Fedora considers
> > adjusting its quality assureance process to scan whole files instead
> > of only the header.
> Well, I suppose it is licensecheck itself which only scans the
> headers?
> It is not a Fedora policy of any sort to only scan the headers of the
> files, but we are actually relying on the licensecheck script to
> detect the license of the various files in the source tarball. And in
> this particular case:
>
> $ licensecheck App-Licensecheck-v3.0.1/bin/licensecheck
> App-Licensecheck-v3.0.1/lib/App/Licensecheck.pm
> App-Licensecheck-v3.0.1/bin/licensecheck: UNKNOWN
> App-Licensecheck-v3.0.1/lib/App/Licensecheck.pm: UNKNOWN
>
>
> (But I don't want to be annyoing or anything, just following our
> guidelines ;) )
You are not annoying, not at all!
If you do "licensecheck --help" you will see that there are options to
either check the whole file (--lines 0) or bottom in addition to top
(--tail N).
I recommend to scan the whole file.
I believe the issue raised here is no bug in licensecheck but instead a
misunderstanding of how to use licensecheck (i.e. how to not rely too
much on its default fast-but-sloppy scanning only header of sources),
and therefore mark this bug as closed.
NB! Closing a bugreport does not mean closing this discussion: You are
still quite welcome to continue our conversation here! :-)
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
--- End Message ---
