Your message dated Thu, 28 Jul 2016 23:30:29 +0200
with message-id <[email protected]>
and subject line Re: Bug#803163: collectd: Please run autoreconf
has caused the Debian Bug report #803163,
regarding collectd: Please run autoreconf
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
803163: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803163
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: collectd
Version: 5.5.0-3
Severity: normal
Hi,
To make it easier to patch Makefile.am after applying patches [1],
please run autoreconf when building collectd.
[1] For example: https://github.com/collectd/collectd/pull/1324
--
Benjamin Drung
System Developer
Debian & Ubuntu Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Email: [email protected]
URL: http://www.profitbricks.com
Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506B.
Geschäftsführer: Andreas Gauger, Achim Weiss.
--- End Message ---
--- Begin Message ---
Source: collectd
Source-Version: 5.5.1-4
On Mon, Jun 06, 2016 at 12:28:25PM +0200, Guillem Jover wrote:
> On Wed, 2016-06-01 at 17:58:35 +0200, Marc Fournier wrote:
> > On Mon, May 30, 2016 at 11:06:32AM +0200, Marc Fournier wrote:
> > > On Sat, May 28, 2016 at 12:43:21PM +0200, Guillem Jover wrote:
> > > > On Tue, 2015-10-27 at 16:27:24 +0100, Benjamin Drung wrote:
> > > > > To make it easier to patch Makefile.am after applying patches [1],
> > > > > please run autoreconf when building collectd.
> > > >
> > > > It seems part of this got fixed when fixing #823012, but it still
> > > > needs some minor changes, otherwise this fails when doing a second
> > > > build in a row. Attached the needed change to solves this.
> > >
> > > I must admit I was initially a bit reluctant to run autoreconf: I ran into
> > > numerous problems when doing this while setting up the CI pipeline at
> > > https://ci.collectd.org/. Admittedly mostly when combining ancient
> > > autoconf
> > > versions from legacy distros with the latest collectd code.
> >
> > So unfortunately your patch introduces one of these issues: dh_autoreconf
> > is now run only if "configure" is not found, but as we're patching
> > "configure.ac", running autoreconf is mandatory.
> >
> > What happens then is that it triggers automake by itself, which fails if
> > there's a version mismatch with the version used to generate the orig
> > tarball (collectd 5.5.1 was released using 1.14, sid currently comes with
> > 1.15).
> >
> > I have only little time for this this week, so I'm going to upload 5.5.1-4
> > without your patch (to fix a lintian error I introduced in -3) in a couple
> > of minutes.
> >
> > Let me know if you come up with a patch solving this problem, else I'll
> > take a look at this again in a few days.
>
> I think the attached updated patch should cover this too.
Thanks! Turns out that 5.5.1-4 was actually uploaded with dh_autoreconf
enabled. I fixed the second build in a row in -5 but without noticing
this bug -- I dropped the separate configure target entirely as we don't
actually need it.
Cheers,
Sebastian
--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x2F1FFCC7 +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
--- End Message ---
