Your message dated Mon, 01 Aug 2016 22:00:10 +0000 with message-id <[email protected]> and subject line Bug#832350: fixed in mini-buildd 1.0.16 has caused the Debian Bug report #832350, regarding please honor ca-certificates when connecting to sources to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 832350: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832350 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Subject: please honor ca-certificates when connecting to sources Source: mini-buildd Severity: wishlist Tags: patch When connecting via https, mini-buildd does not validate certificates and instead generates an error. The attached patch uses ca- certificates to validate the source. It might be even better if it were possible to specify the certificates for a source explicitly. But this patch seems like a simple and good start. Thanks for your work on mini-buildd! -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (1001, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)--- /usr/lib/python2.7/dist-packages/mini_buildd/models/source.py~ 2015-04-30 16:51:56.000000000 -0400 +++ /usr/lib/python2.7/dist-packages/mini_buildd/models/source.py 2015-07-04 22:36:23.634922230 -0400 @@ -22,6 +22,8 @@ from mini_buildd.models.msglog import MsgLog LOG = logging.getLogger(__name__) +def urlopen(s): + return urllib2.urlopen(s, None, None, '/etc/ssl/certs/ca-certificates.crt') class Archive(mini_buildd.models.base.Model): url = django.db.models.URLField(primary_key=True, max_length=512, @@ -92,7 +94,7 @@ with tempfile.NamedTemporaryFile() as release_file: MsgLog(LOG, request).debug("Downloading '{u}' to '{t}'".format(u=url, t=release_file.name)) try: - release_file.write(urllib2.urlopen(url).read()) + release_file.write(urlopen(url).read()) except urllib2.HTTPError as e: if e.code == 404: MsgLog(LOG, request).debug("{a}: '404 Not Found' on '{u}'".format(a=self, u=url)) @@ -110,7 +112,7 @@ # Check signature with tempfile.NamedTemporaryFile() as signature: MsgLog(LOG, request).debug("Downloading '{u}.gpg' to '{t}'".format(u=url, t=signature.name)) - signature.write(urllib2.urlopen(url + ".gpg").read()) + signature.write(urlopen(url + ".gpg").read()) signature.flush() gnupg.verify(signature.name, release_file.name) @@ -125,7 +127,7 @@ # just fine, but not allow to access to base URL # (like ourselves ;). Any archive _must_ have dists/ anyway. try: - urllib2.urlopen("{u}/dists/".format(u=self.url)) + urlopen("{u}/dists/".format(u=self.url)) except urllib2.HTTPError as e: # Allow HTTP 4xx client errors through; these might be valid use cases like: # 404 Usage Information: apt-cacher-ng
--- End Message ---
--- Begin Message ---Source: mini-buildd Source-Version: 1.0.16 We believe that the bug you reported is fixed in the latest version of mini-buildd, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Stephan Sürken <[email protected]> (supplier of updated mini-buildd package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 31 Jul 2016 08:57:07 +0000 Source: mini-buildd Binary: python-mini-buildd mini-buildd mini-buildd-common Architecture: source all Version: 1.0.16 Distribution: unstable Urgency: medium Maintainer: Stephan Sürken <[email protected]> Changed-By: Stephan Sürken <[email protected]> Description: mini-buildd - minimal build daemon - daemon mini-buildd-common - minimal build daemon - 08x upgrade dummy package python-mini-buildd - minimal build daemon - python library and user tool Closes: 832350 Changes: mini-buildd (1.0.16) unstable; urgency=medium . * [9614fc9] wizards: Add support for Ubuntu "xenial". * [dbe0307] control: b-d: Add gnupg (build needs it for automatic tests) (Fixes FTBFS in reproducible build chroots). * [78c157d] models/source.py: Use ca-certificates if installed when checking sources. Thanks to Klee Dienes (Closes: 832350) Checksums-Sha1: 8e85a76a58da7b668d7624bdb55d42e6d085712e 2144 mini-buildd_1.0.16.dsc 24a7a1d22b154c438180e7403ed365b94bee5ae8 859076 mini-buildd_1.0.16.tar.xz 6694b893d3b62ad38f5e27175ac298fd76cddbca 76882 mini-buildd-common_1.0.16_all.deb 43df03bbcba8bfa74d3c1e4f99a7f1ede7fc38cc 706828 mini-buildd_1.0.16_all.deb 1ea5380109ad1b5f321fdc4ed4c37a5d431193fe 380018 python-mini-buildd_1.0.16_all.deb Checksums-Sha256: 809bb8f7b167bd225cf69340ed4f5465db42c0bd1f2545ae38d28ab606c7fb8b 2144 mini-buildd_1.0.16.dsc 56e234fee7a3ecaa1c46d7dd334f88bdb3a72a319a80981062e41ac17d9f83d9 859076 mini-buildd_1.0.16.tar.xz 6fd397b48f31e928d1cae993084912fd986778dc9d0a7585abb82831388c48b6 76882 mini-buildd-common_1.0.16_all.deb d3055d145fc3f0b368a7fea4eeb2fffd4a8595d9e79f6e0541f35f997d53f59c 706828 mini-buildd_1.0.16_all.deb 3f4694d9addd39bf8664abd90a791e29ab2301cc584205109279744e713a1f8b 380018 python-mini-buildd_1.0.16_all.deb Files: a9efacf5d06fb578450bec39be5d5048 2144 devel extra mini-buildd_1.0.16.dsc 813db4ed1aad6f6b32e8e059ddea9dd2 859076 devel extra mini-buildd_1.0.16.tar.xz 89d8e1a447bf47d5b17d77fa6f5a6b06 76882 devel extra mini-buildd-common_1.0.16_all.deb 7c7430d2649d0972b56dd969975e5ef7 706828 devel extra mini-buildd_1.0.16_all.deb 8ad49c7eec6fdf0609608bc098fdca7d 380018 python extra python-mini-buildd_1.0.16_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJXnc68AAoJEAZt6AF+K2HZhXYP/0T8Abt/ZMr/1m82rrV92VVK v3S4V2MYizcYFLCo+qJa1zETl2Yc0L8g/OIHLWB9XCR9hNYWr3YOTQuwaWYH7/JK myGl1hBxUReS3RjvtclY/EOI/V2QoQ0vqHw/apf+akAXgORfEelyFdzgCI27xsfR gtkgWpt1hHb5HRoTLIG5qMCkDVmX6wS5SsEQOL2zTJzl2BoE4u3JtVM0bKL6/dWP 8Br//3q+MV44y9e0tQOo4yVGyZHUZn4nem5ZpQ4usp5KURNwYZ5FK/KLhW45zh0R fS3WCz0s7ziitwA7ribdFeIiDS5ztrVj8wggytwQDJ45jzPHm7IK/3auF08wWjOo GNhE8lgbW/6sXTzufWwOlWA8pQ1wtCrzd3mh88e9/I7c06sj8MADuiD9vuF/23ze pTzP9lJG7s7aLnroDS1If8Qx7iD2CiOvkTac4rYo9O3HzWDLQwCyT4glEuH+/HXV xySRV2aCptq5UdTM4t0QaBZ50ya7YDZwzEFU+MY6d9CYGkEGzTDEBX8XKpJccds3 rmiBWCP1ujurnJnBNVh5YVClOlxEDdDug0wAGKmNNL5y+mZ2N0ghOGr8pf4Sge+C z8R0hVu58dUyTc+VwhS/nZ8jKiJjb0Bey4FBroPyWdLTKoOx+05LlqAR4ibpYkje me7ZUZROXUi1dIAnhz2T =YZfz -----END PGP SIGNATURE-----
--- End Message ---
