Your message dated Wed, 03 Aug 2016 10:08:10 +0000
with message-id <[email protected]>
and subject line Bug#792037: fixed in sbuild 0.70.0-1
has caused the Debian Bug report #792037,
regarding Doesn't upgrade to the newest versions of packages in extra 
repositories
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
792037: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792037
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libsbuild-perl
Version: 0.65.2-1
Severity: normal
Tags: patch

Hi, thanks for sbuild!

I noticed that packages in a repository given via --extra-repository
that are preinstalled into the base chroot aren't upgraded to. For
example I was trying to test building with GCC5 from a PPA of doko's and
yet it wasn't being used during the build. It seems like these repos are
added quite late on, just before installing the actual build-deps and
*after* the initial upgrade/dist-upgrade. This means that build-deps are
satisfied from this repo but things already in the chroot are left as
they were.

Attached is a patch to simply dist-upgrade after doing the later update.
Do you think this makes sense? Note that (AFAICT) sbuild has carefully
only updated its indices for the extra repository and its internal one,
so this should avoid accidentally dist-upgrading from the main archive
again if we get a race condition with a mirror pulse or similar. Note
that I only tested the apt resolver and just assume the aptitude one is
the same, sorry...

Cheers,

-- 
Iain Lane                                  [ [email protected] ]
Debian Developer                                   [ [email protected] ]
Ubuntu Developer                                   [ [email protected] ]
>From d417858acbc6474dd96c4dd8250f541b9db18044 Mon Sep 17 00:00:00 2001
From: Iain Lane <[email protected]>
Date: Fri, 10 Jul 2015 15:45:53 +0100
Subject: [PATCH] lib/Sbuild/Apt{,itude}Resolver.pm: dist-upgrade after
 enabling the internal sources

dist-upgrade after enabling our internal sources. This ensures that
packages in a repo passed in via --extra-repository are used for the
build if they are installed in the base chroot and not pulled in via
build-deps (e.g. gcc). Previously there was no dist-upgrade after
enabling the extra repo.
---
 lib/Sbuild/AptResolver.pm      | 4 +++-
 lib/Sbuild/AptitudeResolver.pm | 3 +++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/Sbuild/AptResolver.pm b/lib/Sbuild/AptResolver.pm
index 7485cda..c9d1796 100644
--- a/lib/Sbuild/AptResolver.pm
+++ b/lib/Sbuild/AptResolver.pm
@@ -62,7 +62,9 @@ sub install_deps {
     # Call functions to setup an archive to install dummy package.
     return 0 unless ($self->setup_apt_archive($dummy_pkg_name, @pkgs));
     return 0 unless (!$self->update_archive());
-
+    # Upgrade the base chroot with packages from our dummy archive, which
+    # includes any extra repositories.
+    return 0 unless (!$self->distupgrade());
 
     $self->log_subsection("Install $name build dependencies (apt-based resolver)");
 
diff --git a/lib/Sbuild/AptitudeResolver.pm b/lib/Sbuild/AptitudeResolver.pm
index 4030382..cfba708 100644
--- a/lib/Sbuild/AptitudeResolver.pm
+++ b/lib/Sbuild/AptitudeResolver.pm
@@ -64,6 +64,9 @@ sub install_deps {
     # Call functions to setup an archive to install dummy package.
     return 0 unless ($self->setup_apt_archive($dummy_pkg_name, @pkgs));
     return 0 unless (!$self->update_archive());
+    # Upgrade the base chroot with packages from our dummy archive, which
+    # includes any extra repositories.
+    return 0 unless (!$self->distupgrade());
 
     $self->log_subsection("Install $name build dependencies (aptitude-based resolver)");
 
-- 
2.1.4


--- End Message ---
--- Begin Message ---
Source: sbuild
Source-Version: 0.70.0-1

We believe that the bug you reported is fixed in the latest version of
sbuild, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Johannes Schauer <[email protected]> (supplier of updated sbuild package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 03 Aug 2016 10:58:48 +0200
Source: sbuild
Binary: libsbuild-perl sbuild buildd
Architecture: source
Version: 0.70.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian buildd-tools Developers 
<[email protected]>
Changed-By: Johannes Schauer <[email protected]>
Description:
 buildd     - Daemon for automatically building Debian binary packages from Deb
 libsbuild-perl - Tool for building Debian binary packages from Debian sources
 sbuild     - Tool for building Debian binary packages from Debian sources
Closes: 792037 800593 812361 813895 823993 824165 824582 824935 825359 825991 
826847 826957 831063 831462
Changes:
 sbuild (0.70.0-1) unstable; urgency=medium
 .
   * new upstream version
     - Fix reproducibility issue by not writing the $HOME as set during the
       build into config files and man pages anymore (closes: #825991)
     - Add an EXAMPLE section to the sbuild man page (closes: #824582)
     - sbuild-createchroot now has support for SUITE-VARIANT chroot names. This
       is useful to create variants of base suits like jessie-backports or
       unstable-experimental. (closes: #826957)
     - sbuild-createchroot now has the --no-deb-src option which allows one to
       create a chroot without a deb-src entry in its sources.list. This is
       useful to save bandwidth and disk space for chroots that will never be
       used to download source packages as the source indices do not have to
       downloaded, stored and later updated from the mirrors. (closes: #826847)
     - sbuild-createchroot now has the --alias option which is useful to add a
       shorthand alias to a chroot which will be used for chroot selection. This
       is for example useful for a Debian unstable chroot which will be
       automatically selected for package builds that have UNRELEASED in their
       debian/changelog, if the UNRELEASED alias is added to the Debian unstable
       chroot. (closes: #800593)
     - suild-createchroot now has the --extra-repository which works like the
       --extra-repository option for sbuild and permanently adds another line to
       the chroot's sources.list.
     - Private/public key pairs are now stored in armored ASCII format to
       maintain compatibility between different gpg versions on the host and
       within the chroot. Re-running `sbuild-update --keygen` will create the
       new key types.
     - Chroots can now have gpg >= 2.x installed as sbuild will properly clean
       up any remaining gpg-agent processes and "apt-key add" is not used
       anymore (it will leave a gpg-agent process around that cannot properly
       be killed).
     - Add the --source-only-changes option which will create a .changes file
       suitable for a source-only upload alongside the normal binary .changes
       file. (closes: #812361)
     - Do not install debfoster by default in sbuild-createchroot to keep the
       build chroot as minimal as possible. Users that use debfoster can use the
       --include option of sbuild-createchroot.
     - Drop requirement for gpg inside the chroot as external archive keys are
       now processed without gpg and signing of the internal repository is
       entirely optional with helpful warning and error messages in case
       signing failed. (closes: #831462)
     - Allow running autopkgtest after a successful build in the same manner
       that piuparts can be run after a successful build. (closes: #824935)
     - fix uninitialized value problem in loop (closes: #823993)
     - Fix typo in APT::Get::AllowUnauthenticated config setting
       (closes: #824165)
     - Add up correct size when looping over files (closes: #825359)
     - Make sure printed timestamps are in C locale, in UTC and in standard
       formats (closes: #813895)
     - Move addition of extra repositories from the creation of the dummy build
       dependency repository to the initial setup (closes: #792037)
     - Fix execution of man (closes: #831063)
   * Remove patches
     0001-lib-Sbuild-ResolverBase.pm-do-not-produce-non-error-.patch and
     0001-bin-sbuild-createchroot-fix-chown-chmod-error-checks.patch as they
     were merged upstream.
Checksums-Sha1:
 b5047115d16e186360b949f566cd1b33f3decf37 2353 sbuild_0.70.0-1.dsc
 ec8c6196e98789143827e4762d8175ca66eba434 630317 sbuild_0.70.0.orig.tar.gz
 8f7c17c8a5fe1f8dca80abcb52787f3fb4744fe7 54324 sbuild_0.70.0-1.debian.tar.xz
Checksums-Sha256:
 dd70822b01dad9fd764498ad5ea5b5760069311c15c2c014f15751643a9e4b66 2353 
sbuild_0.70.0-1.dsc
 813877e1d7a2c73eaa7b0a1dcc0afe7719ea91975fe7a6bb2d6656cfec260981 630317 
sbuild_0.70.0.orig.tar.gz
 a22135925a5d7a2881b24e76a8e4bb57d418a94bf509f208e5963b605da1b82d 54324 
sbuild_0.70.0-1.debian.tar.xz
Files:
 d1106cb4372bb5df71bdba2f8db2b2b2 2353 devel extra sbuild_0.70.0-1.dsc
 a88eb6118f60453995f93eb365c23fa8 630317 devel extra sbuild_0.70.0.orig.tar.gz
 8e6ea7e11ec15f4a101489c9316af62c 54324 devel extra 
sbuild_0.70.0-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXobMmAAoJEPLLpcePvYPhavEP/2Dfdf5dDU9h7BVIL8gibhpQ
lja9AsYgpAOa1zgIwCN9+YDwy+DWpWiAEN/nu9Qz8y255+w3YuQ4gcx8r9kWyNf2
/Em8SNpBApB1nOyoL6aeViCoHcu5r0sqWoA1t6yUijWmtGO2/N2qHZ9hu/IOskEm
ADVsFDKmPryJxISPLDMPelYjMYnKMJbAWWdXtlk+2gQw95BGS/WDNv31bKZ4MSeJ
MmxAOE5H8ADj5npRs2Rcos2Cg8FdM8Vds4utz/PAsHlG6dCQmRrq9ARLkXtVbyRo
EmQRH4XV6JkcWO8/XTGZG76BdcK9exk/H8ynrKVFXC12A/qFvggdHaDcIt6buzqJ
xE1AR3JO8Uu2CoxFzpi8IGZDMd+Yl2MrgrSpcVYSQXwuDtlxb1FYf1Ypz285BtdO
8VF+la62q5u/7o2Fn60RkUn30zefJu/v5dt0hTTEIX8xgpJwmkm+RHVMHhCVBLIh
uDXXLsU9SqqyH422J5SS50bxChTtDOTZCqEMVFVL4ASTWRliWdo+e7bPKr0jcT29
gYyD0uOir0aA29oAVBxsI9ZXBmiUMzmdSWV6fr9oBAIgrgmPVRGdP6EAAhpyU90S
J1yTsqkc9imTvdRZUSluVIn/yAaUEv688MGtn6nfII6KlDb4qTtTgaqHPiEmFv/I
ieuDo5/OEHFbDZ+9nJ8D
=me9f
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to