Your message dated Sun, 4 Sep 2016 19:16:43 +0200
with message-id <[email protected]>
and subject line Re: Bug#836685: qlandkartegt: [PATCH] Fix build error on archs
where char is unsigned by default
has caused the Debian Bug report #836685,
regarding qlandkartegt: [PATCH] Fix build error on archs where char is unsigned
by default
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
836685: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836685
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: qlandkartegt
Version: 1.8.1+ds-6+b3
Severity: important
Tags: patch
Dear Maintainer,
as you've certainly learned too, qlandkartegt 1.8.1+ds-6+b3 fails to
build on several architectures due to -Wnarrowing in recent gcc
versions. It seems however forcing signed characters makes the build
pass again, and the resulting package works as expected. Tested on
powerpc in the stretch distribution:
--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,8 @@
# Enable hardening build flags
export DEB_BUILD_MAINT_OPTIONS=hardening=+all
+CXXFLAGS += -fsigned-char
+CFLAGS += -fsigned-char
BUILD_DATE=$(shell dpkg-parsechangelog | sed -ne 's/^Date: //p' | LC_ALL=C
date -u "+%d %B %Y" -f -)
It might be sufficient to enhance CXXFLAGS only but given a build time
of more than three hours you'll forgive me for not testing this in
detail.
Besides, "overrid_dh_clean" in debian/rules should probably be
"override_dh_clean"
Regards,
Christoph
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: powerpc (ppc)
Kernel: Linux 4.4.19
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
Versions of packages qlandkartegt depends on:
ii libc6 2.23-4
ii libdmtx0a 0.7.4-2
ii libexif12 0.6.21-2
ii libgcc1 1:6.1.1-11
ii libgdal20 [gdal-abi-2-1-1] 2.1.1+dfsg-1+b1
ii libgl1-mesa-glx [libgl1] 11.2.2-1
ii libglu1-mesa [libglu1] 9.0.0-2.1
ii libgps22 3.16-2
ii libjpeg62-turbo 1:1.5.0-1
ii libproj9 4.9.2-3
ii libqt5core5a 5.6.1+dfsg-3+b1
ii libqt5dbus5 5.6.1+dfsg-3+b1
ii libqt5gui5 5.6.1+dfsg-3+b1
ii libqt5multimedia5 5.6.1-2
ii libqt5network5 5.6.1+dfsg-3+b1
ii libqt5opengl5 5.6.1+dfsg-3+b1
ii libqt5printsupport5 5.6.1+dfsg-3+b1
ii libqt5qml5 5.6.1-5
ii libqt5quick5 5.6.1-5
ii libqt5script5 5.6.1+dfsg-2
ii libqt5serialport5 5.6.1-2
ii libqt5sql5 5.6.1+dfsg-3+b1
ii libqt5webkit5 5.6.1+dfsg-5
ii libqt5widgets5 5.6.1+dfsg-3+b1
ii libqt5xml5 5.6.1+dfsg-3+b1
ii libstdc++6 6.1.1-11
ii zlib1g 1:1.2.8.dfsg-2+b1
Versions of packages qlandkartegt recommends:
pn gdal-bin <none>
pn gpsbabel <none>
Versions of packages qlandkartegt suggests:
pn gpsd <none>
-- no debconf information
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
fixed 836685 qlandkartegt/1.8.1+ds-7
thanks
Hi Christoph,
On 09/04/2016 06:57 PM, Christoph Biedl wrote:
> as you've certainly learned too, qlandkartegt 1.8.1+ds-6+b3 fails to
> build on several architectures due to -Wnarrowing in recent gcc
> versions. It seems however forcing signed characters makes the build
> pass again, and the resulting package works as expected. Tested on
> powerpc in the stretch distribution:
Thanks for your patch.
I have indeed noticed the FTBFS, as discussed in the transition bugreport:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836447#34
qlandkartegt (1.8.1+ds-7) was just uploaded in which I've added
-Wno-narrowing to CXXFLAGS to fix the FTBFS.
Using -fsigned-char may be more appropriate, but since I don't expect
any actual users of qlandkartegt on those architectures, it doesn't
really matter.
QLandkarteGT is no longer developed upstream, and users are strongly
encouraged to switch to QMapShack to which upstream has switched his
attention.
> It might be sufficient to enhance CXXFLAGS only but given a build time
> of more than three hours you'll forgive me for not testing this in
> detail.
I used the s390x porterbox which has more acceptable build times,
especially when using DEB_BUILD_OPTIONS="parallel=2" :-)
> Besides, "overrid_dh_clean" in debian/rules should probably be
> "override_dh_clean"
Thanks for spotting this. I've fixed it in git, and also switch from
-Wno-narrowing to -fsigned-char as per your patch.
The changes will be included in the next upload. For now the changes in
-7 will do.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
signature.asc
Description: OpenPGP digital signature
--- End Message ---
