Your message dated Tue, 27 Sep 2016 12:56:39 +0000
with message-id <[email protected]>
and subject line Bug#838918: fixed in ifenslave 2.8
has caused the Debian Bug report #838918,
regarding [ifenslave] Fix the slave_/lower_ check when detaching an interface.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
838918: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838918
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ifenslave
Version: 2.7
Severity: important
Tags: patch
Hi,
Thanks for writing and maintaining the separate ifenslave tool!
What do you think about the attached patch that makes ifenslave actually
work when detaching a "real" interface from a bonding one? The problem
is that the commit that introduced the handling of lower_ as well as
slave_ had a logic bug in inverting the check: it is correct when adding
an interface to a bonding one, but the reversal needs && instead of ||.
This is trivially reproducible by adding an interface to a bond and
then immediately invoking ifenslave -d with the same interface names.
It was also noted in a Ubuntu bug against ifenslave:
https://bugs.launchpad.net/ubuntu/+source/ifenslave/+bug/1298325
Thanks again for your work on ifenslave and Debian in general!
G'luck,
Peter
-- System Information:
Debian Release: stretch/sid
APT prefers oldoldstable
APT policy: (500, 'oldoldstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.7.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages ifenslave depends on:
ii ifupdown 0.8.13
ii iproute2 4.6.0-4
Versions of packages ifenslave recommends:
ii net-tools 1.60+git20150829.73cef8a-2
ifenslave suggests no packages.
-- no debconf information
From c91cccc1065da92547642676ac02ab0623b16270 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <[email protected]>
Date: Mon, 26 Sep 2016 15:41:24 +0300
Subject: [PATCH 01/17] Fix the slave_*/lower_* logic when detaching.
LP: #1298325
Obtained from:
https://bugs.launchpad.net/ubuntu/+source/ifenslave/+bug/1298325/comments/4
---
ifenslave | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ifenslave b/ifenslave
index 21097aa..2c4428c 100755
--- a/ifenslave
+++ b/ifenslave
@@ -93,7 +93,7 @@ for slave in "$@"; do
[ -d "/sys/class/net/$slave" ] || error "$slave: no such interface"
if [ -z "$DETACH" ]; then
- if [ -h "/sys/class/net/$master/slave_$slave" ] ||
+ if [ -h "/sys/class/net/$master/slave_$slave" ] &&
[ -h "/sys/class/net/$master/lower_$slave" ]; then
echo "$slave: already enslaved to $master" >&2
continue
--
2.9.3
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: ifenslave
Source-Version: 2.8
We believe that the bug you reported is fixed in the latest version of
ifenslave, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guus Sliepen <[email protected]> (supplier of updated ifenslave package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 27 Sep 2016 14:24:35 +0200
Source: ifenslave
Binary: ifenslave ifenslave-2.6
Architecture: source all
Version: 2.8
Distribution: unstable
Urgency: medium
Maintainer: Guus Sliepen <[email protected]>
Changed-By: Guus Sliepen <[email protected]>
Description:
ifenslave - configure network interfaces for parallel routing (bonding)
ifenslave-2.6 - transitional package, use "ifenslave"
Closes: 838918
Changes:
ifenslave (2.8) unstable; urgency=medium
.
[ Peter Pentchev ]
* Fix detaching interfaces after the /slave_ to /lower_ change
(Closes: #838918, LP: #1298325).
* Declare compliance with version 3.9.8 of the Debian Policy Manual.
* Fix some typographical and grammatical errors.
* Switch to the HTTPS scheme for the VCS and copyright format URLs.
* Switch to cgit for the Vcs-Browser field.
* Bump the debhelper compatibility version to 10 with no changes.
* Stop suggesting that bugs be filed against ifenslave-2.6 when
the package name is ifenslave now.
Checksums-Sha1:
9f86b07af8d715df35b9d2a63382cc90e3ffe1be 1598 ifenslave_2.8.dsc
c933037133fa583d9046fa23946324d8b0080b52 13216 ifenslave_2.8.tar.xz
7ea8f6564886dfd7774b67dca69887a0b94bbb07 6206 ifenslave-2.6_2.8_all.deb
71dd33221969a733645e486b2caeccaa1e26a8b8 15876 ifenslave_2.8_all.deb
Checksums-Sha256:
07d0a2ade2c2dc4ec009df56b683d12b8e7ffb1d41cd067f810abf04580ddc26 1598
ifenslave_2.8.dsc
592ba29c03c9736a7c1be41847cf9a2299cc1f7880a7750d11d14b185a464c45 13216
ifenslave_2.8.tar.xz
2a2ce8152424595c45739817056739f07fed9f741648d96745b966e9d4f43fe8 6206
ifenslave-2.6_2.8_all.deb
32ebf0a8c3254a8120cd95799592b6fd8fc9c7e4ca43740e0076db60761a5b1e 15876
ifenslave_2.8_all.deb
Files:
bdd953ee8d5546c3ad683e020db94bac 1598 net optional ifenslave_2.8.dsc
1d2b71ab742c42477fe8177093fa9893 13216 net optional ifenslave_2.8.tar.xz
488b3e5be58ec4ae7633132efd1d9ccb 6206 oldlibs extra ifenslave-2.6_2.8_all.deb
8778511ec0db6b7cc112b949557a3e99 15876 net optional ifenslave_2.8_all.deb
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJX6mV2AAoJED9JDeuHHvn6mT4QAIw12xXJMfSzYABPmWBHqE3z
dkGrfoN+MICPJ5OvUcO5loQZifu+xO87hyxEMhNENS8z9MvgUG1Wlp+jN4aNbK8P
m2xhJZwIabIJ5y6qpirYHu/Mjz9pSJ9PDG4N+n+ucrXtTisEOTOsVX+vhNafVxIQ
Q4uRUHiYA40FqVJnNYQAYV9Py/6/DUxHdrI0iEluopt63NvtbAXVSJxU0t0Sb1ec
FalE77ur3omQVtP0WVzy7/zMb4DfveJUD5J82lWtZFw68j37bSnMsL6veIZv/GLf
j4M/opHg+80yDBqfC8mbNDc2glsVfHef4RwQ91WvCtaktRXbggHmwq+Gc7ctI3Xr
WELcAvUoerOoiWZuzaGKEu8v4CilqPdpKjMjtthx6s5tafmbGo5GK7hg5GMSEn4y
r/itrdG/VCDg7Q88+qe0AYO0rc02246vNaW+ypvCly+DK1FyyNjkSe5hjVhD7cRU
oYlEhKtJXiYZdJuElNgS+wygqIT5JVt//xEciGAjx7ca8xBVSpzY/fzCz+Jog0Rt
fYBdKdcs57w3KrBxnuUx+lZozHtFT0prhp9J2LNh7u7fsa24ig+RALLIz5xk3bDW
Ea+WpKLIX6JfJNb7X+rmEufhnzv2CMVKLMtOo9a/Ay0Wf5NarrCSv+aIOcFOrh5g
d74zxVyG2wO1/Hz5WccQ
=9TPl
-----END PGP SIGNATURE-----
--- End Message ---
