Your message dated Wed, 08 Feb 2006 05:17:11 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#350152: fixed in zynaddsubfx 2.2.1-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: zynaddsubfx
Version: 2.2.1-2.1
Severity: normal

Zynaddsubfx crashes when pressing black keys on the virtual keyboard.
This is because of a missing check in VirKeyboard::presskey() if nk is a
valid key. The attached patch fixes this bug, and also fixes the only
three compiler warnings (using a char as array index, and non-virtual
destructors in classes with virtual functions).

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15
Locale: LANG=nl_NL.UTF-8, LC_CTYPE=nl_NL.UTF-8 (charmap=UTF-8)

Versions of packages zynaddsubfx depends on:
ii  fftw3                     3.0.1-14       library for computing Fast Fourier
ii  libasound2                1.0.10-2       ALSA library
ii  libc6                     2.3.5-12       GNU C Library: Shared libraries an
ii  libfltk1.1                1.1.6-10       Fast Light Toolkit shared librarie
ii  libgcc1                   1:4.1-0exp4    GCC support library
ii  libjack0.100.0-0          0.100.0-4      JACK Audio Connection Kit (librari
ii  libmxml1                  2.2-1          development files for libmlxml
ii  libstdc++6                4.0.2-7        The GNU Standard C++ Library v3
ii  libx11-6                  6.9.0.dfsg.1-4 X Window System protocol client li
ii  libxext6                  6.9.0.dfsg.1-4 X Window System miscellaneous exte
ii  libxft2                   2.1.8.2-2      FreeType-based font drawing librar
ii  xlibs                     6.9.0.dfsg.1-4 X Window System client libraries m
ii  zlib1g                    1:1.2.3-9      compression library - runtime

zynaddsubfx recommends no packages.

-- no debconf information
--- zynaddsubfx-2.2.1.orig/src/Params/EnvelopeParams.C
+++ zynaddsubfx-2.2.1/src/Params/EnvelopeParams.C
@@ -51,7 +51,7 @@
 };
 
 REALTYPE EnvelopeParams::getdt(char i){
-    REALTYPE result=(pow(2.0,Penvdt[i]/127.0*12.0)-1.0)*10.0;//miliseconds
+    REALTYPE result=(pow(2.0,Penvdt[(int)i]/127.0*12.0)-1.0)*10.0;//miliseconds
     return(result);
 };
 
--- zynaddsubfx-2.2.1.orig/src/UI/BankUI.fl
+++ zynaddsubfx-2.2.1/src/UI/BankUI.fl
@@ -35,6 +35,8 @@
   } {}
   decl {Bank *bank;} {public
   }
+  Function {~BankProcess_()} {return_type virtual
+  } {code {} {}}
 } 
 
 class BankSlot {: {public Fl_Button,BankProcess_}
--- zynaddsubfx-2.2.1.orig/src/UI/PartUI.fl
+++ zynaddsubfx-2.2.1/src/UI/PartUI.fl
@@ -86,6 +86,8 @@
 class PartUI_ {} {
   Function {showparameters(int kititem,int engine)} {return_type virtual
   } {}
+  Function {~PartUI_()} {return_type virtual} { code {} {}
+  }
 } 
 
 class PartKitItem {: {public Fl_Group}
--- zynaddsubfx-2.2.1.orig/src/UI/VirKeyboard.fl
+++ zynaddsubfx-2.2.1/src/UI/VirKeyboard.fl
@@ -168,7 +168,8 @@
   }
   Function {presskey(int nk,int exclusive,int type)} {} {
     code {if (nk>=N_OCT*12) return;
-if ((nk<0)&&(exclusive==0)) {
+if ((nk<0)) {
+  if(exclusive==0)
   relaseallkeys(type);
   return;
 };


--- End Message ---
--- Begin Message ---
Source: zynaddsubfx
Source-Version: 2.2.1-3

We believe that the bug you reported is fixed in the latest version of
zynaddsubfx, which is due to be installed in the Debian FTP archive:

zynaddsubfx_2.2.1-3.diff.gz
  to pool/main/z/zynaddsubfx/zynaddsubfx_2.2.1-3.diff.gz
zynaddsubfx_2.2.1-3.dsc
  to pool/main/z/zynaddsubfx/zynaddsubfx_2.2.1-3.dsc
zynaddsubfx_2.2.1-3_i386.deb
  to pool/main/z/zynaddsubfx/zynaddsubfx_2.2.1-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eduardo Marcel Macan <[EMAIL PROTECTED]> (supplier of updated zynaddsubfx 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed,  8 Feb 2006 08:50:06 -0200
Source: zynaddsubfx
Binary: zynaddsubfx
Architecture: source i386
Version: 2.2.1-3
Distribution: unstable
Urgency: low
Maintainer: Eduardo Marcel Macan <[EMAIL PROTECTED]>
Changed-By: Eduardo Marcel Macan <[EMAIL PROTECTED]>
Description: 
 zynaddsubfx - Realtime software synthesizer for Linux
Closes: 313368 314671 350152
Changes: 
 zynaddsubfx (2.2.1-3) unstable; urgency=low
 .
   * Patched zynaddsubfx to connect to the default jack output
   * Fixed some compilation warnings and crashing caused by a bug in virtual 
keyboard, patch by Guus Sliepen (closes: #350152)
   * Updated .desktop file to be XDG compliant. Patch by Free Ekanayaka 
(closes: #313368)
   * Set realtime priority acordingly. Patch by Ben Hutchings (closes: #314671)
Files: 
 2c608a32b52ed864fb67a6388c1cfee2 742 sound extra zynaddsubfx_2.2.1-3.dsc
 185dd8199c8f0501357a91a3883db249 8446 sound extra zynaddsubfx_2.2.1-3.diff.gz
 fcf0b254d09870bd574f4cb0905d1e15 987290 sound extra 
zynaddsubfx_2.2.1-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD6erNoUSye+uc2tURArcjAJ9mYZFB9/m08shtMrGt05zASevtYwCgh5O9
q8qgoziki2EX1X2cpIWEiIY=
=J/ax
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to