Your message dated Sat, 08 Oct 2016 11:21:13 +0000
with message-id <[email protected]>
and subject line Bug#839681: fixed in debhelper 10.2.2
has caused the Debian Bug report #839681,
regarding debhelper: autoconf buildsystem: regression due to cross compilation
improvements in makefile buildsystem
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
839681: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839681
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 10.2.1
User: [email protected]
Usertags: rebootstrap
Hi Niels,
thank you for applying an improved version of my patch in #836988.
Unfortunately, it doesn't quite work as expected. The intention was that
our modification to the makefile buildsystem wouldn't affect packages
that were using other buildsystems (e.g. autoconf). Unfortunately, the
buildsystem is not a per-source package property. Instead, it is a
per-target property. The autoconf buildsystem currently only handles
configure and test and defers all other targets to the makefile
buildsystem. That happens to include the build target, which we changed.
This is very unfortunate as it happens to break cross building icu,
which needs to do a native build before doing the actual cross build.
I'd also expect it to break other packages, so we'll probably need to
change the behaviour again.
I basically see two possible solutions:
* Acknowledge that changing the makefile buildsystem also changes
dh_auto_build for autoconf packages and thus the original change
needs to be reverted.
* Ensure that child classes of makefile.pm take all targets.
I am attaching a patch for the latter (as revert is trivial). I think
the change conceptually makes sense, because using different
buildsystems was unexpected to me (and Paul Wise). I also checked all
other child classes and all of them (including mkcmake) do take over all
targets. This might actually be a regression introduced in commit
758ce0bb1fbb505aa05f2dd3ac85d7d084b94312.
Indeed the icu build is fixed both by applying this patch and by adding
--buildsystem=autoconf to dh_auto_build. I don't consider the latter a
proper fix, because it is too counter-intuitive that this should be
necessary and because it likely breaks other packages as well.
What do you think? If all else fails, I vote for revert.
Helmut
>From 8f6fb0e6229cf6c576077cbce6450433b2e0ce6a Mon Sep 17 00:00:00 2001
From: Helmut Grohne <[email protected]>
Date: Mon, 3 Oct 2016 19:09:58 +0200
Subject: [PATCH] fix autoconf/cross regression from #836988
When adding the makefile buildsystem cross variables, the intention was
that it would not affect non-makefile buildsystems (in particular no
downstream buildsystems). However, the decision which buildsystem to use
is done on a per-target basis. Thus a typical autoconf package will use
the autoconf buildsystem for configure and test, but fall back to the
makefile buildsystem for clean and build. Thus the cross variables were
added for autoconf build as well, which broke the cross build of icu.
The solution chosen here is to have autoconf take over build and clean
from makefile as well by inheriting its methods. Thus the semantics stay
unchanged with the exception of not adding the cross variables for
build.
All other children of the makefile buildsystem (including mkcmake)
already take over all targets, so this issue really only affects
autoconf.
Fixes: 7ea67c9aace4 ("makefile.pm: Set CC+CXX to the host compilers when
cross-building")
Signed-off-by: Helmut Grohne <[email protected]>
---
Debian/Debhelper/Buildsystem/autoconf.pm | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/Debian/Debhelper/Buildsystem/autoconf.pm b/Debian/Debhelper/Buildsystem/autoconf.pm
index 8604152..ec3a9f7 100644
--- a/Debian/Debhelper/Buildsystem/autoconf.pm
+++ b/Debian/Debhelper/Buildsystem/autoconf.pm
@@ -19,15 +19,11 @@ sub check_auto_buildable {
my $this=shift;
my ($step)=@_;
- # Handle configure; the rest - next class (compat with 7.0.x code path)
- if ($step eq "configure") {
- return 1 if -x $this->get_sourcepath("configure");
- }
- if ($step eq "test") {
- return 1 if (-e $this->get_buildpath("Makefile") &&
- -x $this->get_sourcepath("configure"));
- }
- return 0;
+ return 0 unless -x $this->get_sourcepath("configure");
+
+ # Handle configure explicitly; inherit the rest
+ return 1 if $step eq "configure";
+ return $this->SUPER::check_auto_buildable(@_);
}
sub configure {
--
2.9.3
--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 10.2.2
We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <[email protected]> (supplier of updated debhelper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 08 Oct 2016 10:16:23 +0000
Source: debhelper
Binary: debhelper dh-systemd
Architecture: source
Version: 10.2.2
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <[email protected]>
Changed-By: Niels Thykier <[email protected]>
Description:
debhelper - helper programs for debian/rules
dh-systemd - debhelper add-on to handle systemd unit files - transitional pack
Closes: 839681
Changes:
debhelper (10.2.2) unstable; urgency=medium
.
* Fix typo in changelog entry for release 10.2. Thanks to
Peter Pentchev for reporting it.
* Deprecate all compat levels lower than 9.
* dh: Discard override log files before running the override
rather than after.
* dh_compress,dh_fixperms: Remove references to long
obsolete directories such as usr/info, usr/man and
usr/X11*/man.
* autoreconf.pm: Apply patch from Helmut Grohne to fix
autoconf/cross regression from #836988. The autoreconf
build-system is now also used directly for "clean" and
"build" (while still usin the "make" build-system for the
heavy lifting). (Closes: #839681)
* dh_installdirs: In compat 11, avoid creating debian/<pkg>
directories except when required to do so. This fixes a
corner case, where an arch:all build would behave
differently than an arch:all+arch:any when dh_installdir is
optimised out only for the arch:all build.
* Dh_Lib.pm: Fix typo of positive. Thanks to Matthias Klose
for spotting it.
Checksums-Sha1:
6ee7f892f090e936cd374864839e7a3e40334975 1701 debhelper_10.2.2.dsc
2e70b5b72b3b6e08da9285af83b262ca74af1e87 355692 debhelper_10.2.2.tar.xz
Checksums-Sha256:
c26e66f492a17a58d8337a262e38c7d89d1569a7e399a9db237657089b34620a 1701
debhelper_10.2.2.dsc
07f84f415f390bd9573a7abc8078203b3f57a2d4590b97010cf75b596b274075 355692
debhelper_10.2.2.tar.xz
Files:
d3f3f96cca9314517cb89d93e9a52a4f 1701 devel optional debhelper_10.2.2.dsc
fed7c37be88f69691ee208c3fc289bb3 355692 devel optional debhelper_10.2.2.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJX+MoOAAoJEAVLu599gGRCYhwP/1iHVOeVRbaqQu/Dxq2ZhOOp
ev+v5p5gk+2suvV4/kb67FubFVwU+FYvsQiTLOP/Pt2AnDEI39NQjef2vvnjN1ix
HbIRZU9zj56Z6cZjH4fTXIS3z2m0knnQ3XYKyaTXQL4sqzioxwyj2enEmE6oNVZm
zpqS1bLKIrD12RekkxzN7Bym5KNjYsFEez+MEo5erQuufIKGVF56ClhrHvn9rAe0
fuwK9QSbjmz3FvL7dXtVSaIk5h6AHBk9fKoYQEOgXL34GFoFtGtqqI2U+9wkqf2R
pii8wE4UTOR+bH19oLrJWIU5ApGt2kn936AG3i3PmpuKZOb2wZG3wh1usRAppSOo
qOm6UlmTSIuv/YQVSkumUBK2pPCFuu1UafxAPwXUrRLEqEwoEGNbTD9aWmO2TR2k
F010VVWVwP5GsOyGx7aLQrvwcuzYi6UrNJTcCXmYPUkpQ9gln5FpPfMoHnsynuuR
AZY5pZeX52NuOhu5nh1TljxZT8U9nPQ27u21ghF2vIG/uC4BizPJuoihKa+eCPcC
tMilY9aRqsvbQIZ1y96psfK2VMw28oekAFHn0TBMQkzvj351DjDjvRXeV6RWrHbM
c2vjX++KKoiL6rrfdsC7sNiw/754lMYvH3Lj6gqOZz+qOKV2pNnZiuj/F9dDuewd
kmqM2ot2FsgtFA3qr+/T
=8CYj
-----END PGP SIGNATURE-----
--- End Message ---
