Your message dated Thu, 3 Nov 2016 12:22:15 +0100 with message-id <[email protected]> and subject line Re: Bug#833841: kodi: Checks fail at TestSystemInfo.GetOsVersion when building package has caused the Debian Bug report #833841, regarding kodi: Checks fail at TestSystemInfo.GetOsVersion when building package to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 833841: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833841 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: kodi Version: 16.1+dfsg1-1 Severity: normal I tried to create a binary package from the current git source with an additional patch included with dpkg-buildpackage and it fails at target "check" (also without my additional patch). The check fails as g_sysinfo.GetOsVersion returns "testing" while the check assumes it will be a number/dots kind of version. This check is kind of useless, as the tested function g_sysinfo.GetOsVersion is never used in the code. I report this here as I actually encountered it as a debian packaging issue and somehow the maintainer must have circumvented this, but I guess the resolution should happen upstream? An easy but dirty fix is of course to just outcomment this test. Relevant command line output: [ RUN ] TestSystemInfo.Print_System_Info [...] 'GetOsVersion()': "testing" [...] [ RUN ] TestSystemInfo.GetOsVersion TestSystemInfo.cpp:134: Failure Value of: g_sysinfo.GetOsVersion().find_first_of("0123456789") Actual: 18446744073709551615 Expected: 0 'GetOsVersion()' must not return version not starting from digit TestSystemInfo.cpp:135: Failure Value of: g_sysinfo.GetOsVersion().find_first_not_of("0123456789.") Actual: 0 Expected: std::string::npos Which is: 18446744073709551615 'GetOsVersion()' must not return version with not only digits and dots [ FAILED ] TestSystemInfo.GetOsVersion (0 ms) -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (500, 'testing'), (2, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---Control: fixed -1 17.0~alpha3+dfsg1-1 Hi, On Tue, 9 Aug 2016 13:02:39 +0200 Simon Frei <[email protected]> wrote: > In the meantime I realised there is already a patch for the tests, so I > updated it such that it works in my case (see attached patch). Thank you for the report and the patch. The build is not failing now for failing tests thus I think we don't need to patch this failing test out. Cheers, Balint
--- End Message ---
