Your message dated Sun, 27 Nov 2016 22:57:51 +0000
with message-id <[email protected]>
and subject line Bug#750480: fixed in shadow 1:4.2-3.3
has caused the Debian Bug report #750480,
regarding shadow: FTBFS on hurd-i386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
750480: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750480
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: shadow
Version: 4.2-2
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd
Hi,
Currently shadow fails to build from source and is flagged as
out-of-date. This is due to a usage of PATH_MAX, which is not defined
on GNU/Hurd. The attached patch solves this problem by allocating a
fixed number of 32 bytes for the string proc_dir_name in files
src/procuidmap.c and src/procgidmap.c. (In fact only 18 bytes are
needed)
Thanks!
Index: shadow-4.2/src/newuidmap.c
===================================================================
--- shadow-4.2.orig/src/newuidmap.c
+++ shadow-4.2/src/newuidmap.c
@@ -94,7 +94,7 @@ void usage(void)
*/
int main(int argc, char **argv)
{
- char proc_dir_name[PATH_MAX];
+ char proc_dir_name[32];
char *target_str;
pid_t target, parent;
int proc_dir_fd;
@@ -120,6 +120,7 @@ int main(int argc, char **argv)
if (!get_pid(target_str, &target))
usage();
+ /* max string length is 6 + 10 + 1 + 1 = 18, allocate 32 bytes */
written = snprintf(proc_dir_name, sizeof(proc_dir_name), "/proc/%u/",
target);
if ((written <= 0) || (written >= sizeof(proc_dir_name))) {
Index: shadow-4.2/src/newgidmap.c
===================================================================
--- shadow-4.2.orig/src/newgidmap.c
+++ shadow-4.2/src/newgidmap.c
@@ -95,7 +95,7 @@ static void usage(void)
*/
int main(int argc, char **argv)
{
- char proc_dir_name[PATH_MAX];
+ char proc_dir_name[32];
char *target_str;
pid_t target, parent;
int proc_dir_fd;
@@ -121,6 +121,7 @@ int main(int argc, char **argv)
if (!get_pid(target_str, &target))
usage();
+ /* max string length is 6 + 10 + 1 + 1 = 18, allocate 32 bytes */
written = snprintf(proc_dir_name, sizeof(proc_dir_name), "/proc/%u/",
target);
if ((written <= 0) || (written >= sizeof(proc_dir_name))) {
--- End Message ---
--- Begin Message ---
Source: shadow
Source-Version: 1:4.2-3.3
We believe that the bug you reported is fixed in the latest version of
shadow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Samuel Thibault <[email protected]> (supplier of updated shadow package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 22 Nov 2016 18:31:28 +0000
Source: shadow
Binary: passwd login uidmap
Architecture: source amd64
Version: 1:4.2-3.3
Distribution: unstable
Urgency: medium
Maintainer: Shadow package maintainers
<[email protected]>
Changed-By: Samuel Thibault <[email protected]>
Description:
login - system login tools
passwd - change and administer password and group data
uidmap - programs to help use subuids
Closes: 750480
Changes:
shadow (1:4.2-3.3) unstable; urgency=medium
.
* Non-maintainer upload.
* Apply upstream patch to fix build on hurd-i386. (Closes: #750480)
Checksums-Sha1:
cdf5ec1dcd963934f58f19b19370f903eb9915c2 2321 shadow_4.2-3.3.dsc
466342cd79eca7c4faca85a8bf1013a53bb65512 496364 shadow_4.2-3.3.debian.tar.xz
afda34792e9fcc76939d05c999138b89fd7f66f1 179892 login-dbgsym_4.2-3.3_amd64.deb
d60395defb0035f26e6a46985a1b1baa328d7945 718272 login_4.2-3.3_amd64.deb
39b73a303fe4e262e76c77e54bae07b591ce471d 1436866
passwd-dbgsym_4.2-3.3_amd64.deb
b11b1475033ff8b6752c5c89c16a166db1bbb656 966392 passwd_4.2-3.3_amd64.deb
cbee059e535bb4c7cea90fe058ce443c8ae0ea29 6702 shadow_4.2-3.3_amd64.buildinfo
1ad282693263851f95d86b0a0888ae5ef13fbabd 80394 uidmap-dbgsym_4.2-3.3_amd64.deb
e06599a9acf21585123e0c8e7762f0ee126ebb9d 254120 uidmap_4.2-3.3_amd64.deb
Checksums-Sha256:
c190a5aa2280113f6cbb61836e0a2154d6625389fa38d5b009865f2a2e820e8b 2321
shadow_4.2-3.3.dsc
568709f8572974de0363510db93dda224a2e49deac2fa27b8535e0225f72b6b1 496364
shadow_4.2-3.3.debian.tar.xz
064a4bbf69519687ad9ee3d725fad513a5a258e2f397b0186ada71e4b61a2b43 179892
login-dbgsym_4.2-3.3_amd64.deb
8c890811fe5b28fe212fd59db42c45248bf7f5a97185bb49a098416fc3a53562 718272
login_4.2-3.3_amd64.deb
4bd97973307bfa3b180bc20f6f6b612fcb7f24f1ffbaffe6a1e10a9685191234 1436866
passwd-dbgsym_4.2-3.3_amd64.deb
8ec43e5b2f3175b10aa499e04091ce9a315a3c47670c79aaa7beb0b5ea642174 966392
passwd_4.2-3.3_amd64.deb
a58a5b833b77ef24d7b404a1cfb5f69ef5d1669287d3b32ab7408bd05540cea2 6702
shadow_4.2-3.3_amd64.buildinfo
9eba0936cfa2eeaf5738eff8a9bceba4d415beb23c87f89be872e0e96a10af43 80394
uidmap-dbgsym_4.2-3.3_amd64.deb
dd41ca61e85d32af80baa06efbb71b550947ae437a5a8b5122a8f0d2c90bc580 254120
uidmap_4.2-3.3_amd64.deb
Files:
6663af15c1ae3afe4befc249937ccc37 2321 admin required shadow_4.2-3.3.dsc
d2f6e3af5d69c231d51b32001ddef850 496364 admin required
shadow_4.2-3.3.debian.tar.xz
42411c8a773deab3ced8d1f33c68a575 179892 debug extra
login-dbgsym_4.2-3.3_amd64.deb
8814c97ca3846aa467d10797a6e47490 718272 admin required login_4.2-3.3_amd64.deb
608df1069e1f15d7983168364ac7f12f 1436866 debug extra
passwd-dbgsym_4.2-3.3_amd64.deb
04a51a2c51bcd10e40d66f603dfe46f4 966392 admin required passwd_4.2-3.3_amd64.deb
e37f1a68de71c7b8f5ac281e932f380e 6702 admin required
shadow_4.2-3.3_amd64.buildinfo
e0656b24eafc3d444dd36246877eb8d4 80394 debug extra
uidmap-dbgsym_4.2-3.3_amd64.deb
fa198c84e4fde0056e1776ede187a42a 254120 admin optional uidmap_4.2-3.3_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE9jJ0zcYwCHPLPSnZ4+Uc6PtrLx0FAlg0vjYACgkQ4+Uc6Ptr
Lx2VgxAAhpxPJzAtHVb2AUkcKCAlhg+H7F/60c4pKmbCEpaM5u8LIAOOZMQxKvlg
3zM/maeFknV4gDuCRvXySL2c6s8dlDeEF+JmDoPwPeoYjvS3fFiyetyzSHiuqsfi
AcuKRN0lgdxtr7tJA8o4aoHzzX6jd2FBch7PrfOCtnH8GStlREZBzl2LGMBqRrhD
CsUuduxz11N+Up/tXnvwYXDryAWFHxsHnHXv2VMB63u9nubhF1IqOn59jHhASb7H
/HYXiH4JLQFGNCNXjzMGpPpEdzHb3O+q3h/TMgKnPM/NdrrbA+sYUo9TfvMfXi3i
lZwvsmDrsHhXdhdqkgBI+IF0ILcYQakP0mx9IAKN/wYBWVJS3E24Y5z0aDoiZpBY
7NfBjvOEH/27ZgU/Nru75GsRmq0pAeW5qGagPjJbXljjZO5UffQkjCaH4l6to/43
PFLN57P0iTc/F4R1FODwkuLwNqSrCYVoj06xFOS97UUUYsNnv3VC/tkovm7yk9I7
ulCLHN9JvfT6eSiNrTv9N3zyOms007nG+QUKba4PL/HRO56iLGJ4Nn6IqKLMRhvC
5CymWtA09S9JpwgTwToWEnS1wlEGB4q3EoZHU5YfVx8+9D8X7BMdcOGpV1z1PY3F
S3X29cPqVE8jxpCoXwo2RC9ATk7xH2Yher6aM5uCiuiikR3av9Y=
=Ytfl
-----END PGP SIGNATURE-----
--- End Message ---
