Your message dated Wed, 30 Nov 2016 19:24:36 +0000
with message-id <[email protected]>
and subject line Bug#846239: fixed in dh-r 20161130
has caused the Debian Bug report #846239,
regarding dh-r: PLease do not insert ', ,' sequence in d/control
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
846239: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=846239
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-r
Severity: normal
Tags: patch

Hi Gordon,

in case of an empty $rdepends string dh-make-R injects ', ,' into
Build-Depends which is a syntax error in d/control.  This patch

diff --git a/scripts/dh-make-R b/scripts/dh-make-R
index dbd0419..4908e53 100755
--- a/scripts/dh-make-R
+++ b/scripts/dh-make-R
@@ -66,7 +66,12 @@ my $rdepends = 
deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Dep
 my $rrecommends = 
deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Recommends", 
$desc->{Recommends}, \%apthash));
 my $rsuggests = 
deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Suggests", 
$desc->{Suggests}, \%apthash));
 my $rimports = 
deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Imports", 
$desc->{Imports}, \%apthash));
-my $builddeps = deps_concat("debhelper (>= 9)", "dh-r", "r-base-dev", 
$rdepends, $rimports);
+my $builddeps;
+if ( $rdepends ) {
+    $builddeps = deps_concat("debhelper (>= 9)", "dh-r", "r-base-dev", 
$rdepends, $rimports);
+} else {
+    $builddeps = deps_concat("debhelper (>= 9)", "dh-r", "r-base-dev", 
$rimports);
+}
 
 say "I: Package depends: $rdepends";
 say "I: Package imports: $rimports";


fixes it and is just commited to Git.

Kind regards

      Andreas.

-- System Information:
Debian Release: 8.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
Source: dh-r
Source-Version: 20161130

We believe that the bug you reported is fixed in the latest version of
dh-r, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated dh-r package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 30 Nov 2016 15:16:08 +0100
Source: dh-r
Binary: dh-r
Architecture: source all
Version: 20161130
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Andreas Tille <[email protected]>
Description:
 dh-r       - Debian helper tools for packaging R libraries
Closes: 846239
Changes:
 dh-r (20161130) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Dylan Aïssi ]
   * dh-make-R:
     -d/control: Switch to the canonical URL of CRAN and Bioconductor
     -d/copyright: Add the Upstream-Contact and Source fields
     -d/watch: Switch to HTTPS for the Bioconductor link
 .
   [ Andreas Tille ]
   * dh-make-R:
     -d/control: Make sure no empty package is injected inbetween ', ,'
                 in case of empty $rdepends
      Closes: #846239
     -d/control: create debhelper 10 control files
   * debhelper 10
Checksums-Sha1:
 e9796567e559b5d315cb9b418faeb47a71279997 1648 dh-r_20161130.dsc
 c2580debea0ba81874beb0f3906d1b92e31e0b4e 7516 dh-r_20161130.tar.xz
 6d31e80fef6dd6d32b3498b3b548db23c419348c 7740 dh-r_20161130_all.deb
 ce9931ebd2d7f3f127068364d07aa89bb1ce1bc6 4737 dh-r_20161130_amd64.buildinfo
Checksums-Sha256:
 9b46b5d758d73d0ecd3a228e6226a2c3443b73ef9f5b0dec26d4a3c0171763d0 1648 
dh-r_20161130.dsc
 294cd534c7e1933cf9cbc6b1c8478ae163714d8893b5a81dbf53df840700f01b 7516 
dh-r_20161130.tar.xz
 bda6e365b19ae68aae765d25606571a27f0a4126130076b4e5c765f6fe53b772 7740 
dh-r_20161130_all.deb
 a28318ca2299193ce12bf4b4f65f6544b55e65ac16ea1cb1115c1f147eba3974 4737 
dh-r_20161130_amd64.buildinfo
Files:
 b6bc61dc534b49e2184f21a5127d80a4 1648 science optional dh-r_20161130.dsc
 b2bc159c81675d0842f4af2d4aeba331 7516 science optional dh-r_20161130.tar.xz
 db97ea2f78c50a69a16f9c673785d827 7740 science optional dh-r_20161130_all.deb
 9152263d8414fd8d8e873bab9d5a7cd2 4737 science optional 
dh-r_20161130_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlg+340RHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtGGzA//cnb6iGafxPf0np8k9o5ljDZDdXaasBZ6
Mm9KMEdO6j3utZXYwABmUSVoiaCbfIsRCVZfLNumRK1Ytvo/j22gVrdKM4w09DEz
735PpRYHCaKyxQUhrVIFElzVARoOtaH8a/qAyJjZTe+FQU5KbxZFwfndNthDKz1t
R7q8jY9YcTZeWdTOVm8wcx1aYIZz1QnHzLmo4/aXf2k9po9B7Tj5a9wcDg6Pj3Jp
wvqn22JPKm7mdJJMLsdfoKjkb+iQ0LR95oONVuRIp8bY6yIU/Q8Le5ZZShVfSEx7
+/zUmzHnzw6NRwP02dhYXpO2IN4bUHaYQ/9y5Dyk62MeYcHwonhJg5ZyYb9anPTD
c1fNPS6rWMyzOP+ZB40ObN8yNSZiMgytRkt0QK6tJKvBTXN8tFbkFvkCyxhlpQxk
eY8x0cfXKEub/TiZR1dO31P+VdcTnFMsBlj8tFzNZUpTW5lP+Xre7kvFw1uWej3P
oHWaKkZxij40Vz30bGJ1tdQKPa83jDZoTF1HblYmBLR6UJr7Qbs3AaI3Ycn079Nz
ZFUU/6O5binCL6bKC6O/9sXAkpkXQxXWvUQ7DBYQLmsjCmHM9hp+gyWs+mYjOZzu
11vJsAdgIyIdj8VF2GZSYVR12qA5A8vrcLPT1tKeKy8a9J5sYCrbIzXnDvdrHMBi
Jd/cD2xm918=
=J8wR
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to