Your message dated Mon, 05 Dec 2016 06:05:21 +0000
with message-id <[email protected]>
and subject line Bug#819352: fixed in xpdf 3.04-2
has caused the Debian Bug report #819352,
regarding xpdf: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
819352: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819352
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xpdf
Version: 3.04-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: fileordering

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that xpdf could not be built reproducibly.
The linking step in the 'override_dh_auto_build' rules target uses a
file ordering based on wildcards alone, which results in different
binaries for different file orderings.

The attached patch fixes this by making sure objects are linked in sorted
order. Once applied, xpdf can be built reproducibly in our current
experimental framework.

Best regards,
Sascha

[1]: https://wiki.debian.org/ReproducibleBuilds
diff -Nru xpdf-3.04/debian/rules xpdf-3.04/debian/rules
--- xpdf-3.04/debian/rules	2016-02-07 17:59:57.000000000 +0000
+++ xpdf-3.04/debian/rules	2016-03-27 11:21:10.000000000 +0000
@@ -14,8 +14,8 @@
 files+=xpdf/XPDFApp xpdf/XPDFCore xpdf/XPDFTree xpdf/XPDFViewer xpdf/xpdf
 headers=xpdf/config.h xpdf/XPDFTreeP.h xpdf/about-text.h xpdf/*.xbm xpdf/xpdfIcon.xpm
 
-sources=$(shell for file in $(files); do echo $$file.*; done)
-objects=$(shell for file in $(files); do echo build/$$(basename $$file).o; done)
+sources=$(sort $(shell for file in $(files); do echo $$file.*; done))
+objects=$(sort $(shell for file in $(files); do echo build/$$(basename $$file).o; done))
 
 override_dh_clean:
 	dh_clean
@@ -30,7 +30,7 @@
 	mv build/parseargs.c build/parseargs.cc
 
 override_dh_auto_build: $(objects)
-	$(CXX) $(LDFLAGS) -o build/xpdf.real build/*.o $(LIBS)
+	$(CXX) $(LDFLAGS) -o build/xpdf.real $^ $(LIBS)
 
 %:
 	dh ${@}

--- End Message ---
--- Begin Message ---
Source: xpdf
Source-Version: 3.04-2

We believe that the bug you reported is fixed in the latest version of
xpdf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Gilbert <[email protected]> (supplier of updated xpdf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 31 Jul 2016 21:31:54 +0000
Source: xpdf
Binary: xpdf
Architecture: source
Version: 3.04-2
Distribution: experimental
Urgency: medium
Maintainer: Michael Gilbert <[email protected]>
Changed-By: Michael Gilbert <[email protected]>
Description:
 xpdf       - Portable Document Format (PDF) reader
Closes: 617546 737628 739271 796492 819352
Changes:
 xpdf (3.04-2) experimental; urgency=medium
 .
   * Remove menu file.
   * Update standards version.
   * Fix desktop file exec line.
   * Restore key binding support (closes: #739271).
     - Thanks to Adam Sampson.
   * Restore support for initialZoom (closes: #737628).
     - Thanks to Vincent Lefevre.
   * Fix PSOutputDev argument order (closes: #617546).
     - Thanks to Simon Tatham.
   * Handle renaming of Japanese font files (closes: #796492).
     - Thanks to Hideki Yamane.
   * Sort object files during linking (closes: #819352).
   * Refactor XPDFParams to keep it better in sync with upstream's GlobalParams.
Checksums-Sha1:
 5cb3013a588acf7ba7cee0b3303f72bec30b0ac9 2568 xpdf_3.04-2.dsc
 f114ca697e815ab6d11699d67b9bb4b4d3571260 40720 xpdf_3.04-2.debian.tar.xz
Checksums-Sha256:
 0dee012d9a173fddc5a8a2602517513fbff3338cb2ed8fa65f7a480571e3dbc0 2568 
xpdf_3.04-2.dsc
 eddf2364eb4d8d559a452c864a20773c3f4b1693cfa9c91d7a2e1c3294726d73 40720 
xpdf_3.04-2.debian.tar.xz
Files:
 ffadabb8ad58e12f00e3579af3937ad3 2568 text optional xpdf_3.04-2.dsc
 96fd36dc97414e63c29176775886ac34 40720 text optional xpdf_3.04-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQQzBAEBCgAdFiEEluhy7ASCBulP9FUWuNayzQLW9HMFAlhFAT0ACgkQuNayzQLW
9HPbQx/+Osv7n2qhIhNujLOVOIJqIa/rITG0cYLx1P+dHlMNGqaU2+dVLjEI1Ujq
ftr3kB47IrbrIxBVj3b2dDeU2SX8HrXXfnBoFjNoOsmEzqvTfLX9in8JF50qQSn3
jZU74ys26v7SE30WqN3wKJEMI39GXrOTxakit7Lxg9muaXHoNl0J5xAE51J+lqrt
MCYclbBhymIj1xp0968XSzGXVdLgryxjPGoaB+Rz/GDYqWHYSmxOFXebhQyIVqRo
SiVZtS84NwO3pp8l5kMxRuzUTTyagZ/OFhnLcjMzrpUXx/nVhL55cymAcipWF3d5
4iqZWJwaoPFqbPEbXBelHQJ9EGN4jXWpqwdG6cTuYDqTY6qXV6kSl+2TMtalqZGZ
9ShKeAyJMJrAykNKp8SuPou4y130E9oRMOEZsxe5TLfz/srul+Iy8cxb/LzUx8gy
RNk8GQLhZ0eStACuwoxksMkEAHc9pi/e6tMQG6IXJFWqXd45V8H4nA7H7mkkGKEW
AAavax5ae7UmL1FLt88bUYu6hBggzjm341Xt5kLpOBmDbP3GBwVGhgabe3ZONJXG
CY7+e4zw+sSLaHWIk/kCK0Pec7yGtyi394Uv+VZGZy74wp5PsE93ERM2oPv/UH/Z
jwcWGL/6gFvtHj2U5kxgaL9Cq7dTUMkGuyst46etVZXsFk0KNXBT+5D61J89FB9L
Sz9Zny10YShW0BKWUd3jR4KdPwePG8Wk9UIYE87n3xQjlG8kA/FLHWOzNW1Fh8xX
SXtrBmxUFT5mHEUrafq6FXIgigoe/Id3tRalSYPTLi+Hs5Y1/LuFtaWjAi/FaOAy
Mk12jOI7X7H4UW6BhyqAwyn4P6yUgPhFXI6WD5U7INoLYA62QJMBhP+NeDgIxLwV
Qg+QK9hXOPA57zPwy9TD0wyw/JrxDPLS+VRKjwRwl9ucB7S7OgyRNIWPtZetjF9c
0LZglyn/YhnqJP+c8jcrQColJVPjS+hFPAWiUpzOfdARb0RO2CHgZ667sALwIEfI
I367adf15vrvtNWWiIfCijvOO9w2l3bHwm1vhSKjg1p1QoVNUV9qi9CngXkZBVhf
bwYovlSirk0nLnb+Ws5Gw46CaL4Uzf7QT2LVUIhd7ELFK6+i1wcSXtkEaGtDupUq
4kLVtjZNVnyN3bT7Co3l+LoEZrsGVnxvymkQg2G26q5JyI53O9Wg/s5L+rO50jVx
IsKW94ucWbjAsRRd8iKZxVMxwOo6yswu1a1XYJ4Mb0HWpLwfMKWimdGHRjjSt1/1
A6+IhxGtqlirLIRPmmgqscXFWYnxfaltcAwACPq06KgH4B72R7zyPurcQMTO5Q41
VAAbfUeS+dbKYpLejQNG7rvSnHAUrg==
=XX+T
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to