Your message dated Fri, 06 Jan 2017 03:04:27 +0000 with message-id <[email protected]> and subject line Bug#850279: fixed in dictionary-el 1.10-3 has caused the Debian Bug report #850279, regarding dictionary-el: toggle-read-only conflicts with view-read-only and is obsolete since 24.3 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 850279: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850279 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: dictionary-el Version: 1.10-2 Severity: normal Tags: patch Hi, I like to customize the view-read-only variable in order to enable view-mode for read-only files. However, view-mode is also being enabled for dictionary buffers which is probably unintended behaviour since the default view-mode keybindings conflict with the default dictionary-mode keybindings (for instance, when I press 's' in a dictionary buffer, I get isearch-forward instead of dictionary-search). Reading the source code for dictionary-el, I noticed that it uses the function toggle-read-only which, according to documentation, has been rendered obsolete since Emacs 24.3. Setting the buffer-local variable buffer-read-only instead of calling the toggle-read-only function solves the issue. Here is a very simple patch: diff --git a/dictionary.el b/dictionary.el index a5885c3..9c77e8b 100755 --- a/dictionary.el +++ b/dictionary.el @@ -679,7 +679,7 @@ This function knows about the special meaning of quotes (\")" (defun dictionary-pre-buffer () "These commands are executed at the begin of a new buffer" - (toggle-read-only 0) + (setq buffer-read-only nil) (erase-buffer) (if dictionary-create-buttons (progn @@ -722,7 +722,7 @@ This function knows about the special meaning of quotes (\")" (goto-char dictionary-marker) (set-buffer-modified-p nil) - (toggle-read-only 1)) + (setq buffer-read-only t)) (defun dictionary-display-search-result (reply) "This function starts displaying the result starting with the `reply'." -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.8.0-2-amd64 (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages dictionary-el depends on: ii emacs25-lucid [emacsen] 25.1+1-3+b1 ii emacsen-common 2.0.8 dictionary-el recommends no packages. dictionary-el suggests no packages. -- no debconf information -- Hermógenes Oliveira
--- End Message ---
--- Begin Message ---Source: dictionary-el Source-Version: 1.10-3 We believe that the bug you reported is fixed in the latest version of dictionary-el, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Aaron M. Ucko <[email protected]> (supplier of updated dictionary-el package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 05 Jan 2017 21:32:36 -0500 Source: dictionary-el Binary: dictionary-el Architecture: source Version: 1.10-3 Distribution: unstable Urgency: medium Maintainer: Aaron M. Ucko <[email protected]> Changed-By: Aaron M. Ucko <[email protected]> Description: dictionary-el - dictionary client for Emacs Closes: 719041 850279 Changes: dictionary-el (1.10-3) unstable; urgency=medium . * debian/control: Canonicalize per cme. In particular, declare Standards-Version: 3.9.8 (already compliant, in fact). * dictionary.el: - Per Hermógenes Oliveira <[email protected]>, adjust buffer-read-only rather than calling toggle-read-only, which is deprecated and can have unwanted side effects. (Closes: #850279.) - Per the ever-patient Kevin Ryde <[email protected]>, adjust dictionary-tooltip-dictionary's defcustom type to acknowledge that nil (the default value) is in fact valid. (Closes: #719041.) Also, tweak dictionary-display-tooltip (used by GNU Emacs) to proceed even if dictionary-tooltip-dictionary is nil, as already done for XEmacs. Checksums-Sha1: 6f89fc34cc5eb1560e97c62ce53c4d33093289cb 1863 dictionary-el_1.10-3.dsc 7be3875a4fb51db84841699911be367882ea329c 6434 dictionary-el_1.10-3.diff.gz Checksums-Sha256: 68132cb5e94adcb9984a2056d0c10b0176b74710d8b3a9a1cfd9cbdcdbe5ae6b 1863 dictionary-el_1.10-3.dsc 7029b64f833b45662821ad0fa7392d678a4a6355a29f9ea8aa5d50faeed52583 6434 dictionary-el_1.10-3.diff.gz Files: 2c6017a3ebb710b715a774118e2d7740 1863 lisp optional dictionary-el_1.10-3.dsc 097800d28398210de48858a2f5093a80 6434 lisp optional dictionary-el_1.10-3.diff.gz -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEfDq5z9IwvTDdAJxZHnCRsfFKZKIFAlhvBBcACgkQHnCRsfFK ZKL2mA/+IUXda2Dz44yw4EOLfF1hZlRqEuZ0NZTvq80XVq1i8HrpUbZTCWtzxMTE 4XCRRh5PGyvP/qjkRyxSVZhMcKC1CVFUIdvQsrhSloYWeb9AsBhmKetDYBDFQKPy BMqChJCkm/uyPZceYPMoKox+G+xTvkikKlfTXNncrFNbbiug4MBpz04N3AyuTndD JkGuIWvs+NjIFIAJGq7OCtIaPUtRBy1B7rfta+Fv9Bn52PCGp/LXLB80E/0YaSGr yWgeRp4zuii4iIueVHxsb/dJZK63SBVaeOQ8UeUNChKMA3cdQgH6HIzq8uaSKonC nn7Mvhq3/zl/kHWUMmmnlceYNP+5TKH97kA9anXZPFyPWYC5P6PthxQDDLgjbaZl 2fklzFs62w/mv1RfhDe/bcjUJDYi0paTD2CZ9IHlykMer2wqgg7NhXKzO9fvKGEI zIKyw1QCIOE37GkxIItoPZJibjX4GuUfp49Mc/VB1shTPwdhOvzIaCdZYYOx9W3E HPHH9Mjw1KCw/RPmLNRn5BEG69pDzU57+FWjF5Ub67Hs0pO1AGeP/zHjebNP9OXO 2AN9UyBlU8cFD3FnEAOR3eZ/G4subT0K1tIxspkbIZmEqk06RzTUr9l0ycpDbvyN QzMAk2i14vf6cdQD11xI6XP7F6apDFdnH1aQIwyKJ7oDlrFBzJw= =wcgU -----END PGP SIGNATURE-----
--- End Message ---
