Your message dated Fri, 27 Jan 2017 18:03:48 +0000
with message-id <[email protected]>
and subject line Bug#761036: fixed in lilypond 2.18.2-5
has caused the Debian Bug report #761036,
regarding lilypond: Updated hurd patch to fix hurd FTBFS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
761036: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761036
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lilypond
Version: 2.12.3-1
Tags: patch
Severity: wishlist
User: [email protected]
Usertags: hurd

Hi.  The lilypond package do not build on hurd, even with a hurd patch
in place.  The cause seem to be a typo in the file
debian/patches/hurd_file_name_support, checking for _GNU_SOURCE_
instead of _GNU_SOURCE (at least that is what the getcwd() manual page
claim to look for).

Attached is an updated patch, fixing that bug, a memory leak
forgetting to release the memory allocated by get_current_dir_name(),
and adding the same code in the test code.

Please replace the patch in the current source with this new one, and
consider sending it upstream. :)

-- 
Happy hacking
Petter Reinholdtsen
Description: Hurd build without PATH_MAX; currently broken
Forwarded: not-needed
Origin: vendor
Author: Don Armstrong <[email protected]>
Index: lilypond-2.18.2-pere/flower/file-name.cc
===================================================================
--- lilypond-2.18.2-pere.orig/flower/file-name.cc       2014-09-10 
09:25:45.057177512 +0200
+++ lilypond-2.18.2-pere/flower/file-name.cc    2014-09-10 09:30:19.783634883 
+0200
@@ -96,9 +96,16 @@
 string
 get_working_directory ()
 {
+#ifdef _GNU_SOURCE
+  char *cwd = get_current_dir_name();
+  string scwd(cwd);
+  free(cwd);
+  return scwd;
+#else
   char cwd[PATH_MAX];
   // getcwd returns NULL upon a failure, contents of cwd would be undefined!
   return string (getcwd (cwd, PATH_MAX));
+#endif
 }
 
 /* Join components to full file_name. */
Index: lilypond-2.18.2-pere/flower/test-file-path.cc
===================================================================
--- lilypond-2.18.2-pere.orig/flower/test-file-path.cc  2014-09-10 
09:26:15.057445802 +0200
+++ lilypond-2.18.2-pere/flower/test-file-path.cc       2014-09-10 
09:30:05.599507531 +0200
@@ -6,12 +6,26 @@
 #include "yaffut.hh"
 #include "config.hh"
 
+string
+get_working_directory ()
+{
+#ifdef _GNU_SOURCE
+  char *cwd = get_current_dir_name();
+  string scwd(cwd);
+  free(cwd);
+  return scwd;
+#else
+  char cwd[PATH_MAX];
+  // getcwd returns NULL upon a failure, contents of cwd would be undefined!
+  return string (getcwd (cwd, PATH_MAX));
+#endif
+}
+
 TEST (File_path, Find)
 {
   char const *extensions[] = {"ly", "", 0};
   string file = "init";
-  char cwd[PATH_MAX];
-  if (!getcwd (cwd, PATH_MAX))
+  if (get_working_directory().empty())
     {
       cerr << "Could not get current work directory\n";
       exit (1);

--- End Message ---
--- Begin Message ---
Source: lilypond
Source-Version: 2.18.2-5

We believe that the bug you reported is fixed in the latest version of
lilypond, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Anthony Fok <[email protected]> (supplier of updated lilypond package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 27 Jan 2017 05:05:52 -0700
Source: lilypond
Binary: lilypond lilypond-data lilypond-doc lilypond-doc-pdf lilypond-doc-html 
lilypond-doc-html-cs lilypond-doc-html-de lilypond-doc-html-es 
lilypond-doc-html-fr lilypond-doc-html-hu lilypond-doc-html-it 
lilypond-doc-html-ja lilypond-doc-html-nl lilypond-doc-html-zh 
lilypond-doc-pdf-de lilypond-doc-pdf-es lilypond-doc-pdf-fr lilypond-doc-pdf-hu 
lilypond-doc-pdf-it lilypond-doc-pdf-nl
Architecture: source
Version: 2.18.2-5
Distribution: unstable
Urgency: medium
Maintainer: Don Armstrong <[email protected]>
Changed-By: Anthony Fok <[email protected]>
Description:
 lilypond   - program for typesetting sheet music
 lilypond-data - LilyPond music typesetter (data files)
 lilypond-doc - LilyPond Documentation in info format (and meta package)
 lilypond-doc-html - LilyPond HTML Documentation
 lilypond-doc-html-cs - LilyPond HTML Documentation in Czech
 lilypond-doc-html-de - LilyPond HTML Documentation in German
 lilypond-doc-html-es - LilyPond HTML Documentation in Spanish
 lilypond-doc-html-fr - LilyPond HTML Documentation in French
 lilypond-doc-html-hu - LilyPond HTML Documentation in Hungarian
 lilypond-doc-html-it - LilyPond HTML Documentation in Italian
 lilypond-doc-html-ja - LilyPond HTML Documentation in Japanese
 lilypond-doc-html-nl - LilyPond HTML Documentation in Dutch
 lilypond-doc-html-zh - LilyPond HTML Documentation in Chinese
 lilypond-doc-pdf - LilyPond PDF Documentation
 lilypond-doc-pdf-de - LilyPond PDF Documentation in German
 lilypond-doc-pdf-es - LilyPond PDF Documentation in Spanish
 lilypond-doc-pdf-fr - LilyPond PDF Documentation in French
 lilypond-doc-pdf-hu - LilyPond PDF Documentation in Hungarian
 lilypond-doc-pdf-it - LilyPond PDF Documentation in Italian
 lilypond-doc-pdf-nl - LilyPond PDF Documentation in Dutch
Closes: 761036
Changes:
 lilypond (2.18.2-5) unstable; urgency=medium
 .
   [ Dr. Tobias Quathamer ]
   * Fix patch for FTBFS on hurd. Thanks to Petter Reinholdtsen
     for the bug report and patch. (Closes: #761036)
 .
   [ Anthony Fok ]
   * Bundle our own private copy of guile-1.8.  Superceded by guile-2.0,
     the old guile-1.8 was finally removed from Debian in May 2016.
     Unfortunately, LilyPond 2.18.2 still requires Guile 1.8,
     and LilyPond 2.19.x and Guile 2 are just not yet ready for each other.
     So, it would seem that bundling our own private guile-1.8 is the only
     viable option to keep LilyPond 2.18.2 in Debian for the time being.
     Hope this would allow LilyPond to re-enter Debian 9 "stretch"!
     See Bug #746005 for more information.
   * Import guile-1.8 as multiple upstream tarball component,
     originally Debian's own DFSG-compliant guile-1.8_1.8.8+1.orig.tar.bz2,
     recompressed with gzip as lilypond_2.18.2.orig-guile18.tar.gz
     (to work around current gbp limitation).
   * Add debian/gbp.conf for multiple upstream tarball (MUT)
     with special "multiple upstream tarball" (MUT) upstream-mut branch
     branch and upstream-mut/%(version)s tags for Debian 9 "stretch".
   * Cherry-pick set-global-fonts function from upstream to scm/font.scm
   * Refresh debian/control:
     - Add myself to the Uploaders field
     - Bump Standards-Version to 3.9.8 (no change)
     - Use secure https URIs for Vcs-Browser and Vcs-Git fields
   * Add explicit Build-Depends on libfl-dev
     LilyPond needs /usr/include/FlexLexer.h from libfl-dev,
     but flex dependency on libfl-dev has been demoted to Recommends
     since flex (2.6.1-1.1) dated 2016-11-24.
   * Remove bitmap fonts from Build-Depends and use vector fonts only.
     Also, Build-Conflicts with fonts-noto-cjk which contains OpenType
     Collection (OTC) fonts, which unfortunately Ghostscript does not yet
     support and would cause the build to abort.
   * Make lilypond-doc-html Depends on lilypond-doc for its PNG images
   * Add "--no-parallel" to dh_auto_clean in debian/rules.
     The use of a parallel "$(MAKE) -j4 distclean" tends to fail
     after a full build.
   * Fix some minor errors and omissions in debian/copyright.
     Also add Dr. Tobias Quathamer and me as contributors to debian/*.
Checksums-Sha1:
 790f887b7c6b7e1978c9aca410f6a77b14b68549 4073 lilypond_2.18.2-5.dsc
 13b37383e69d96123630fc7519af4cd8b0feadb0 2510038 
lilypond_2.18.2.orig-guile18.tar.gz
 09d3a1e0e9fadeb8ef6e279227a2b30812c7ee9b 16027977 lilypond_2.18.2.orig.tar.gz
 2f4390e4d524af5030825c52c0a141d18bc762a8 55248 lilypond_2.18.2-5.debian.tar.xz
Checksums-Sha256:
 1dbf4a9854c070b814c740329243668c70e69c09bf7cd58aa21d4b61163462c5 4073 
lilypond_2.18.2-5.dsc
 55ff45dd426c58ef7a5530b4e701c2a6a1e54043c2b69c64206fc105ddd247db 2510038 
lilypond_2.18.2.orig-guile18.tar.gz
 329d733765b0ba7be1878ae3f457dbbb875cc2840d2b75af4afc48c9454fba07 16027977 
lilypond_2.18.2.orig.tar.gz
 c25f36cab9c4e5b00dd78d786ab81c816b79eee538a515273a052369c596a2e6 55248 
lilypond_2.18.2-5.debian.tar.xz
Files:
 93ee48915353fd787603e3a08ee5d014 4073 tex optional lilypond_2.18.2-5.dsc
 2863f46023dd38e33ac37978302c078f 2510038 tex optional 
lilypond_2.18.2.orig-guile18.tar.gz
 3c4bcbb708d12644668b32bfe82ebf25 16027977 tex optional 
lilypond_2.18.2.orig.tar.gz
 5a38d6857fdbfb95fb775234a2254497 55248 tex optional 
lilypond_2.18.2-5.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEFCQhsZrUqVmW+VBy6iUAtBLFms8FAliLh/YACgkQ6iUAtBLF
ms8wDw/+J0owh9Ghqeo6fo9+alDdCqGUoZ3Jro91vpwWLh4kZvXBFrnkdHHRKoCB
bjhSOH5iCv2Erqta78sVxqnBOqYUUui5Fg5DyEismrTJYprW3jA0bwPL41piivjl
f1f0fceCnnRUuwJGrnnvTGT2PyIVzPyyVGlefEeNC9KQrETzKahDG/oOy1ksESTk
vESHElQk2E5fvmGzqxSbQlXj4XN57CdXzoWvU4vrXEKIVyV+m0i/dmEYzVQb4RTt
/hejsZmQcbDw1RyVNxHRNp7FPWfoBsmk5VOsZk8aJh2qAlsmun/pmKeiIGzWiPvP
s7A1AunBp6etn4fYBGLM+FbwKfrST8fbsrVusy2NiL4iAYOJgp+Pk+2NMpiOTYV4
iWbxOWeWXDdAmFzOOsesy2vtVSCs1IlE2+Fv7EGzAaOBiXHHX/2wUyb3W1pPsy8i
rUPxPTy0nHQhfyq5W7/kQgVpwEzp8tyhCU31yk+RBC+RHyXLmrZIfbkMYy2QeRWu
X31iXj/hYwlXZpkUwgcQE78O/NcihgUBj1+G24JgvPvhcVSIyQ/zll/+jXpGms3O
aIBYBMSDoDk1ZIz+wi/Z6mZp9QC+PC9WXlA9TQn+ekd7GZXKBxZFk3y54PnUFTYW
3C3KbW0FrF1cbFbEkpbFSjkAyQUWjcaUa4JOfHNRSgBu7ww65lU=
=6Neo
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to