Your message dated Sat, 27 May 2017 09:33:46 +0000
with message-id <[email protected]>
and subject line Bug#863280: fixed in cubemap 1.3.2-1
has caused the Debian Bug report #863280,
regarding streams with paths exactly 7 characters long get broken buffering 
behavior
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
863280: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863280
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cubemap
Version: 1.3.1-3
Severity: important
Tags: patch

Hi,

There's a bug in Cubemap where, if one makes a stream with path exactly
7 characters long (e.g. “/abc.ts”), it would match the check for ?backlog
at the end (since find() returns -1 on not found). This would cause
massively increased latency (depending on the size of the backlog), and also
problems with clients such as VLC which don't properly empty socket buffers.

The following trivial patch fixes the issue:

diff --git a/server.cpp b/server.cpp
index afaab9b..608ed6b 100644
--- a/server.cpp
+++ b/server.cpp
@@ -653,7 +653,7 @@ int Server::parse_request(Client *client)
 
        string url = request_tokens[1];
        client->url = url;
-       if (url.find("?backlog") == url.size() - 8) {
+       if (url.size() > 8 && url.find("?backlog") == url.size() - 8) {
                client->stream_pos = -2;
                url = url.substr(0, url.size() - 8);
        } else {

The patch has been included in Cubemap 1.3.2, which contains no other changes.
Please consider fixing it for stretch, as it's a confusing and potentially
pretty bad bug.

-- System Information:
Debian Release: 9.0
  APT prefers testing-proposed-updates
  APT policy: (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.2 (SMP w/40 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages cubemap depends on:
ii  adduser              3.115
ii  init-system-helpers  1.48
ii  libc6                2.24-10
ii  libgcc1              1:6.3.0-18
pn  libprotobuf7         <none>
ii  libstdc++6           6.3.0-18
ii  lsb-base             9.20161125

cubemap recommends no packages.

Versions of packages cubemap suggests:
ii  logrotate   3.11.0-0.1
ii  munin-node  2.0.33-1

--- End Message ---
--- Begin Message ---
Source: cubemap
Source-Version: 1.3.2-1

We believe that the bug you reported is fixed in the latest version of
cubemap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philipp Kern <[email protected]> (supplier of updated cubemap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 27 May 2017 11:17:45 +0200
Source: cubemap
Binary: cubemap
Architecture: source amd64
Version: 1.3.2-1
Distribution: unstable
Urgency: medium
Maintainer: Philipp Kern <[email protected]>
Changed-By: Philipp Kern <[email protected]>
Description:
 cubemap    - scalable video reflector, designed to be used with VLC
Closes: 863280
Changes:
 cubemap (1.3.2-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #863280)
Checksums-Sha1:
 54b50ac6b6b309da527dfa1571e3324edb45f22e 1654 cubemap_1.3.2-1.dsc
 605308666b95c8fbe1a63f64b9b94c9b0c0bf682 64300 cubemap_1.3.2.orig.tar.gz
 df1255b32886ffaeedede3d3f79cbdff5b4cf2cd 4464 cubemap_1.3.2-1.debian.tar.xz
 c9bc425516df1b009607c8bd476313c88b3a465a 1273832 
cubemap-dbgsym_1.3.2-1_amd64.deb
 2922c58903fc2cb1584cc6b16602725f392c1182 5536 cubemap_1.3.2-1_amd64.buildinfo
 646577be411298dca3315b7061421ec0f96678bc 104708 cubemap_1.3.2-1_amd64.deb
Checksums-Sha256:
 defb8747bdd6c46096b4fd28f32fd2ebd3a0977960b2c0064e452dd0c38cc7e7 1654 
cubemap_1.3.2-1.dsc
 4eefabda7aa48a791e7654a78f442e53c0ff4085e6416e38314a8ae782859516 64300 
cubemap_1.3.2.orig.tar.gz
 25ee82eabda0e84f7e8e899da0caae20805f567e67d8e8b8995a2fb0b18320ac 4464 
cubemap_1.3.2-1.debian.tar.xz
 ffd919a825bedacd46be12ec76ab1efb74150df2d695ca6b86eaf8a9d52b9d72 1273832 
cubemap-dbgsym_1.3.2-1_amd64.deb
 266d0e4d3246baf65f5aa04722fc2cf63753decbcf4a41198a08026e0abba9ab 5536 
cubemap_1.3.2-1_amd64.buildinfo
 5e9c1998e8cfff5daa89ae2a8672899258326af3669aeea1b470c59c207e7551 104708 
cubemap_1.3.2-1_amd64.deb
Files:
 880bc4aa18898b621c5a344d054d066a 1654 net optional cubemap_1.3.2-1.dsc
 f5aa1e35c15957b71f90d89caf659e04 64300 net optional cubemap_1.3.2.orig.tar.gz
 bc19f96281c4a359a4ba2e49c3793182 4464 net optional 
cubemap_1.3.2-1.debian.tar.xz
 06af5c8e9cb423694e41caca1a575944 1273832 debug extra 
cubemap-dbgsym_1.3.2-1_amd64.deb
 b93b9e6e548b0e11c94420de52ed6bd7 5536 net optional 
cubemap_1.3.2-1_amd64.buildinfo
 033f204d355aa704898d95ad4021e816 104708 net optional cubemap_1.3.2-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEPzuChCNsw7gPxr3/RG4lRTXQVuwFAlkpRV0RHHBrZXJuQGRl
Ymlhbi5vcmcACgkQRG4lRTXQVuy+aQf/fQX5kgmdaDaWjnDqKfIfyEafG6k/Auwf
kNdhIqMsud0auqijqbFnxsPLWvc2U70A2RG5n02u7ZAdQOtu5qrEbTsnyvTYCqNT
t47BfF+yqLzKEndilHjYybb3kNeQqwcVCG6xERHjKVywkLxZukc1lqzIN6Q2Uht4
jFVllbIM9UXu37WdM99lAPkASdACdlbifR7O3Er+4CyHvetJl1XV0zfSX9DB88SQ
yRICYWc6mM0TFKYsyAq5NZq8ONqs2soCIW7+HmvM1MeCs2+nuo1BrF38zpr8Y3hv
juZEuWoG0Gbcqa1NxaXuThLYB1VRVI0g+MK2Klv8wQ+IN7tgB9EkcA==
=mPgy
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to