Your message dated Tue, 11 Jul 2017 09:53:22 +0200
with message-id <[email protected]>
and subject line Re: pyephem: please make the build reproducible
has caused the Debian Bug report #842992,
regarding pyephem: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
842992: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842992
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pyephem
Version: 3.7.6.0-6
Severity: wishlist
Tags: patch upstream
User: [email protected]
Usertags: fileordering
X-Debbugs-Cc: [email protected]
Hi!
While working on the "reproducible builds" effort [1], we have noticed
that pyephem could not be built reproducibly.
During build it links object files in non-deterministic order.
The attached patch fixes this by sorting the list of source files.
Regards,
Reiner
[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..72e4a60
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,16 @@
+Author: Reiner Herrmann <[email protected]>
+Description: Sort source files for deterministic linking order
+
+--- a/setup.py
++++ b/setup.py
+@@ -13,8 +13,8 @@
+ # directory plus ...
+
+ libastro_version = '3.7.6'
+-libastro_files = glob('libastro-%s/*.c' % libastro_version)
+-libastro_data = glob('extensions/data/*.c')
++libastro_files = sorted(glob('libastro-%s/*.c' % libastro_version))
++libastro_data = sorted(glob('extensions/data/*.c'))
+
+ def read(*filenames):
+ return open(os.path.join(os.path.dirname(__file__), *filenames)).read()
diff --git a/debian/patches/series b/debian/patches/series
index 94d33e5..df14648 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ fix_tests_unicode.patch
spellfix.patch
disable_failing_tests.patch
fix_string_to_double.patch
+reproducible_build.patch
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: pyephem
Version: 3.7.6.0-7
I applied the patch and uploaded a new version, but just forgot to close
the bug there. Here is the last changelog entry:
pyephem (3.7.6.0-7) unstable; urgency=low
* Update standards-version (no changes), VCS fields; add ASCL Id
* Make build reproducible
* Convert patches to gbp
* Push Standards-Version to 4.0.0. No changes needed.
-- Ole Streicher <[email protected]> Mon, 10 Jul 2017 14:49:53 +0200
Thank you for the patch!
Best regards
Ole
--- End Message ---
