Bug#209327: marked as done (FtpGet write in ASCII mode always)

[Debian Bug Tracking System]

Your message dated Wed, 08 Mar 2006 07:53:18 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Bug#209327: fixed in ftplib 3.1-1-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---

Title: FtpGet write in ASCII mode always

Package: FtpLib

Version: 3.1-1

FtpGet always write the local file in ASCII mode.

Even if I choose do get file in Binary mode (FTPLIB_IMAGE).

The fix is very simple (in FtpXfer function)

Instead of:

local = fopen(localfile, (typ == FTPLIB_FILE_WRITE) ? "r" : "w");

Should be:

local = fopen(localfile, (typ == FTPLIB_FILE_WRITE) ? (mode==FTPLIB_IMAGE?"rb":"r") : (mode==FTPLIB_IMAGE?"wb":"w"));

Best Regards,

Yinon Cohen

--- End Message ---

--- Begin Message ---

Source: ftplib
Source-Version: 3.1-1-1

yinon cohen <[EMAIL PROTECTED]> writes:

> I found out that you already have a patch for this bug.
> Sorry for bothering you.

Yeah, upstream fixed this in 3.1-1-1:

  6) Open local files in binary mode when appropriate.  This is
  necessary on some systems like NT and VMS.

Thanks,

Matej

--- End Message ---