Your message dated Thu, 31 Aug 2017 09:19:12 +0000
with message-id <[email protected]>
and subject line Bug#873714: fixed in virt-manager 1:1.4.2-1
has caused the Debian Bug report #873714,
regarding virt-install --location fails for s390x guests
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
873714: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873714
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: virt-manager
Version: 1:1.4.0-5
Tags: patch, stretch, d-i
X-Debbugs-CC: [email protected]

Dear Maintainer,

when I try to install a s390x KVM guest using the following command

virt-install --name testing --ram 1024 --disk
/var/lib/libvirt/images/testing.qcow2,bus=virtio --location
http://ftp.de.debian.org/debian/dists/testing/main/installer-s390x

I get the following error message:
======================================
ERROR    Error validating install location: Could not find an
installable distribution at
'http://ftp.de.debian.org/debian/dists/testing/main/installer-s390x'

The location must be the root directory of an install tree.
See virt-install man page for various distro examples
=======================================

even though the location URL is correct. This is because the install
files location differs from i386/amd64. The attached patch - also
available upstream - will fix this (for Debian and Ubuntu).

-- 

Kind Regards
   Viktor Mihajlovski

--- a/virtinst/urlfetcher.py
+++ b/virtinst/urlfetcher.py
@@ -1106,6 +1106,12 @@
         kernel_basename = "linux"
         if self._treeArch in ["ppc64el"]:
             kernel_basename = "vmlinux"
+
+        if self._treeArch == "s390x":
+            hvmroot = "%s/generic/" % self._url_prefix
+            kernel_basename = "kernel.%s" % self.name.lower()
+            initrd_basename = "initrd.%s" % self.name.lower()
+
         self._hvm_kernel_paths = [
             (hvmroot + kernel_basename, hvmroot + initrd_basename)]
 
@@ -1124,7 +1130,11 @@
             return False
 
         filename = "%s/MANIFEST" % self._url_prefix
-        regex = ".*%s.*" % self._installer_dirname
+        if self.arch == "s390x":
+            regex = ".*generic/kernel\.%s.*" % self.name.lower()
+        else:
+            regex = ".*%s.*" % self._installer_dirname
+
         if not self._fetchAndMatchRegex(filename, regex):
             logging.debug("Regex didn't match, not a %s distro", self.name)
             return False
@@ -1173,7 +1183,10 @@
         if self.fetcher.hasFile("%s/MANIFEST" % self._url_prefix):
             # For regular trees
             filename = "%s/MANIFEST" % self._url_prefix
-            regex = ".*%s.*" % self._installer_dirname
+            if self.arch == "s390x":
+                regex = ".*generic/kernel\.%s.*" % self.name.lower()
+            else:
+                regex = ".*%s.*" % self._installer_dirname
         elif self.fetcher.hasFile("install/netboot/version.info"):
             # For trees based on ISO's
             self._url_prefix = "install"

--- End Message ---
--- Begin Message ---
Source: virt-manager
Source-Version: 1:1.4.2-1

We believe that the bug you reported is fixed in the latest version of
virt-manager, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated virt-manager package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 31 Aug 2017 09:18:57 +0200
Source: virt-manager
Binary: virt-manager virtinst
Architecture: source
Version: 1:1.4.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Libvirt Maintainers 
<[email protected]>
Changed-By: Guido Günther <[email protected]>
Description:
 virt-manager - desktop application for managing virtual machines
 virtinst   - Programs to create and clone virtual machines
Closes: 873714
Changes:
 virt-manager (1:1.4.2-1) unstable; urgency=medium
 .
   * [194c3e4] New upstream version 1.4.2
   * [4ce9023] Rediff patches
   * [be8dfed] Cherry-pick some ustream patches.
       Add virtinst-connection-Fix-error-caching-new-pool.patch
       Add virtinst-adjust-media-paths-for-s390x.patch (Closes: #873714)
   * [8b6eb23] Re-enable Italian translation.
     This reverts commit 0d743f25dcde50e043b1d4d8a7606125873a5911.
   * [d4a2240] Adjust pygrub path in tests too
   * [f643d51] Run test during build
Checksums-Sha1:
 90931c14528d3cd250061c0fca739c1d8188140b 2329 virt-manager_1.4.2-1.dsc
 c50b246e83b8bc1615e50ce99e6d6d6fae4c88a1 2770982 virt-manager_1.4.2.orig.tar.gz
 12acba3bc16413f8aa12dc5fe59c572b1fcb6491 15192 
virt-manager_1.4.2-1.debian.tar.xz
 0eb4f06fe0dfaa26d00517e82666b769474ab5e6 10229 
virt-manager_1.4.2-1_amd64.buildinfo
Checksums-Sha256:
 f1ac9056283b2a52c0e92666e77a6e0e44fdf79642222767d3522c48a43f68e8 2329 
virt-manager_1.4.2-1.dsc
 43e440bb099facf59b59c27c2fc4eb2c42ef0d4ed8d67d93c9e3d98538b6d574 2770982 
virt-manager_1.4.2.orig.tar.gz
 2a524f382a4d06b76b2ab7719fa1a30f6803b4e17a22336238b320d7095b5aef 15192 
virt-manager_1.4.2-1.debian.tar.xz
 883ad48da97c8756d9c17ac1405ff30bdcbd0e4f509c0d1bbe0a929ac9edb1d8 10229 
virt-manager_1.4.2-1_amd64.buildinfo
Files:
 a6741ac4ae621830d8ae5b16232ef81e 2329 admin optional virt-manager_1.4.2-1.dsc
 e143252290501b21da1a213885c12ed8 2770982 admin optional 
virt-manager_1.4.2.orig.tar.gz
 56e03b3b72af8e99fefa265131656289 15192 admin optional 
virt-manager_1.4.2-1.debian.tar.xz
 be52d1003be5baa5807126a16f584b4d 10229 admin optional 
virt-manager_1.4.2-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEvHzQcjh1660F3xzZB7i3sOqYEgsFAlmnwjQACgkQB7i3sOqY
EgsfaQ//aTIVdfGG0z+ymPAv5CAlljZPYva8CLcpmKsA3+kZCDRzxI/OOgTTt7PT
4Hv87piTP+wEkdd50Ja2sFtck0NAs2Vv29fd0V4A7ez3IHv4rMDrzbteEfyguryy
8TtRwqpKXM4++NriyxI1eDdSyz0IPfeZZuKyk2K+CDJDtwnollBF7D9yEXksVdfm
0zrBrfOj6ty22eEqN4ohl4uTezbUDrlKiUpZFUuOCj+WIFhXE8rNHWJEN0MoiWXD
6ntcgW1AkfuOU+5/CbT57owFGipcodKQzWz5I9uhFpkxCi4UEOoOTsktHHyHKUkf
qhCvhbmyQhHqa+RXs1W8Hv8xZsUSxcvBcLZBWC3uYAVva7Y0KzW4pXxLo478Musu
SOwNkfEqeBOG0ga5X3Fh5nKzB1wes3CD2zrAYhoL4XEzXzpGWP2uTfRytcKTHMv2
d50tsva/7sG3cgF9YpBIA5iVBLpr2andNROnbBYmDS/zOdlqn0vMRBzYWRAYl96J
3qkTKQB2jOq+G4+9A4cWjTsrJDrs4CnMHkfrWfZ7opfDJfsJ22Xpqfxus+HpgeRs
+5CgYsQnpZOfZzeHUfUHY04GOR0VxgQqmqkaLm/2+trJIBa4JCKVWNuIB989Cu/n
L9DRn1Z56dxO3Y+pfAenxWfQOwX5TUA8Dx+NSdf5oFwx++aXJ2k=
=F82b
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to