Your message dated Tue, 05 Sep 2017 15:25:39 +0000 with message-id <[email protected]> and subject line Bug#838288: fixed in mailman 1:2.1.24-1 has caused the Debian Bug report #838288, regarding mailman: SpamAssassin module broken in Testing and Unstable to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 838288: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838288 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: mailman Version: 1:2.1.23-1 Severity: normal Tags: patch Dear Maintainer, * What led up to the situation? Upgraded mailman to the version in testing. We have the SpamAssassin module in use as per instructions: in mm_cfg.py we uncommented the line: GLOBAL_PIPELINE.insert(1, 'SpamAssassin') Mailman produced errors like these in ite error log: Sep 16 19:06:29 2016 (3736) Uncaught runner exception: cannot import name matche s_p Sep 16 19:06:29 2016 (3736) Traceback (most recent call last): File "/var/lib/mailman/Mailman/Queue/Runner.py", line 119, in _oneloop self._onefile(msg, msgdata) File "/var/lib/mailman/Mailman/Queue/Runner.py", line 190, in _onefile keepqueued = self._dispose(mlist, msg, msgdata) File "/var/lib/mailman/Mailman/Queue/IncomingRunner.py", line 130, in _dispose more = self._dopipeline(mlist, msg, msgdata, pipeline) File "/var/lib/mailman/Mailman/Queue/IncomingRunner.py", line 150, in _dopipel ine __import__(modname) File "/var/lib/mailman/Mailman/Handlers/SpamAssassin.py", line 31, in <module> from Mailman.Handlers.Moderate import matches_p ImportError: cannot import name matches_p and all messages were shunted. * What exactly did you do (or not do) that was effective (or ineffective)? Applying the following patch fixes the probelm for us: --- /usr/lib/mailman/Mailman/Handlers/SpamAssassin.py 2016-04-26 03:06:54.000000000 +1000 +++ /backup/usr/lib/mailman/Mailman/Handlers/SpamAssassin.py 2016-05-02 15:21:29.833067102 +1000 @@ -28,7 +28,6 @@ from Mailman import Errors from Mailman.Logging.Syslog import syslog from Mailman.Handlers import Hold -from Mailman.Handlers.Moderate import matches_p SPAMD_HOST = getattr(mm_cfg, 'SPAMASSASSIN_HOST', '') DISCARD_SCORE = getattr(mm_cfg, 'SPAMASSASSIN_DISCARD_SCORE', 10) @@ -78,7 +77,7 @@ if MEMBER_BONUS != 0: for sender in msg.get_senders(): if mlist.isMember(sender) or \ - matches_p(sender, mlist.accept_these_nonmembers, mlist.internal_name()): + mlist.GetPattern(sender, mlist.accept_these_nonmembers, at_list='accept_these_nonmembers'): score -= MEMBER_BONUS break * What was the outcome of this action? mailman works again * What outcome did you expect instead? -------- It appears that the SpamAssasin module is added by the Debian packaging and it used an interface from the main mailman package that was removed. The version of mailman in Stable is fine (1:2.1.18-2+deb8u1) but that in Testing ans Unstable are broken (1:2.1.22-1 and 1:2.1.23-1). -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'stable'), (1, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) Versions of packages mailman depends on: ii apache2 [httpd] 2.4.23-4 ii cron [cron-daemon] 3.0pl1-128 ii debconf [debconf-2.0] 1.5.59 ii libc6 2.23-5 ii logrotate 3.8.7-2 ii lsb-base 9.20160629 ii python-dnspython 1.14.0-3 pn python:any <none> ii ucf 3.0036 Versions of packages mailman recommends: ii postfix [mail-transport-agent] 3.1.0-5+b1 Versions of packages mailman suggests: ii listadmin 2.40-5 ii lynx 2.8.9dev9-1 ii spamassassin 3.4.1-5 -- debconf information: * mailman/create_site_list: * mailman/used_languages: en * mailman/default_server_language: en mailman/gate_news: false * mailman/site_languages: en * mailman/queue_files_present: abort installation -- debsums errors found: debsums: changed file /usr/lib/mailman/Mailman/Handlers/SpamAssassin.py (from mailman package)
--- End Message ---
--- Begin Message ---Source: mailman Source-Version: 1:2.1.24-1 We believe that the bug you reported is fixed in the latest version of mailman, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Thijs Kinkhorst <[email protected]> (supplier of updated mailman package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 05 Sep 2017 14:31:54 +0000 Source: mailman Binary: mailman Architecture: source amd64 Version: 1:2.1.24-1 Distribution: unstable Urgency: medium Maintainer: Mailman for Debian <[email protected]> Changed-By: Thijs Kinkhorst <[email protected]> Description: mailman - Powerful, web-based mailing list manager Closes: 838288 Changes: mailman (1:2.1.24-1) unstable; urgency=medium . * New upstream release. * Fixed broken dependencies in SpamAssassin.py (Closes: #838288). Thanks Stephen Rothwell for the patch. Checksums-Sha1: 2131d461430e91dd918cbe5292b9916476b0af9b 1776 mailman_2.1.24-1.dsc e29534b9d407a835482d4251d0b26ab155175bb5 9251009 mailman_2.1.24.orig.tar.gz fe0126f3f5df4a1594445ed2e1cb7974987cc7c4 102216 mailman_2.1.24-1.debian.tar.xz fe2ec62a55fbb0ffa75047b34231d8ad78f038fc 16434 mailman-dbgsym_2.1.24-1_amd64.deb fb4018b03cf920edc5e61e47e885305138dd1837 5937 mailman_2.1.24-1_amd64.buildinfo f8f092e1d2d6bafbfa855fb52a31dbdfc4fd11da 4472086 mailman_2.1.24-1_amd64.deb Checksums-Sha256: 89df2a0c68428614e5dbfe6084a41d7d9a3ce9c07b968cada5dd443a93d6b193 1776 mailman_2.1.24-1.dsc 89b0cfc13c52915b9cdebd4b772852f1043e7435554050b4f5f7094f9093cd77 9251009 mailman_2.1.24.orig.tar.gz 85d44db839732fa9a5f9455c9bc08ac7be8eaed2c79856340a1548bf2a202898 102216 mailman_2.1.24-1.debian.tar.xz a32005473c08897090f501fa0e61b2a17459f9df88d416d97eb8d45eaf8df983 16434 mailman-dbgsym_2.1.24-1_amd64.deb e44728dc4e4e855c43f400ec2c02984f32a4e7f3f1365773451fd5691d390271 5937 mailman_2.1.24-1_amd64.buildinfo 10c780877695a0b73a14f650e8f90d806ec7cf7e7c89ff22deb06fd7f8c6e1d7 4472086 mailman_2.1.24-1_amd64.deb Files: acbb9dfad62a6a074f74aea51ff929fd 1776 mail optional mailman_2.1.24-1.dsc ba96c5cab41cd6b03fd52b7e7f127819 9251009 mail optional mailman_2.1.24.orig.tar.gz 0fb5bcf6f4c88484279ba259a56e10da 102216 mail optional mailman_2.1.24-1.debian.tar.xz 1e612f7b43d4936e5b1585bcb0224efc 16434 debug extra mailman-dbgsym_2.1.24-1_amd64.deb 160dc463fd755e5fa86e7afb7dfe49a8 5937 mail optional mailman_2.1.24-1_amd64.buildinfo 66f60b7d69836e3f20378971439a249f 4472086 mail optional mailman_2.1.24-1_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJZrrrbAAoJEFb2GnlAHawErFYH/3v/kfsr7TlwKOwZEgZGW7+K 2KX/8I1/XbsSQWE5TFa9KorPf/Ygc5wHvZrKLoLDtRwrNJAtU7phKcYm5Nd7+1uL OZFR9nNv8u8yExCfUzR5tushDVmhEICtl9CtYET4Rktgy2mQi8bjh0z5jrs3PZw9 p3zgY5O8pmNk9Bg23PoWEAup0xsYyZ+50UXTSsc/1GANoHEH+DJVqWilUvh3Ocd8 MKFWZGex6lPYMe0XP+SuQ+GbyhG6ddAZWpd78rM8bn9S6wImIFLwbVYQZ9riDWIv UUMi6aWadFSs/wG6KNkhDYjAznd+UOcmQ7RIquypsgfDiXu8O0HyDHwzqhVjuyM= =PCfv -----END PGP SIGNATURE-----
--- End Message ---
