Your message dated Sun, 26 Nov 2017 21:14:34 +0100
with message-id <[email protected]>
and subject line Re: Bug#882727: libffi-platypus-perl: please make the build
reproducible
has caused the Debian Bug report #882727,
regarding libffi-platypus-perl: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
882727: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882727
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libffi-platypus-perl
Version: 0.47-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: randomness
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that libffi-platypus-perl could not be built reproducibly.
This is because it rendered JSON without calling "canonical" to
ensure determinsitic sorting which ended up in a "config.json"
file.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/0001-reproducible-build.patch 1970-01-01
09:00:00.000000000 +0900
--- b/debian/patches/0001-reproducible-build.patch 2017-11-26
11:25:01.883626576 +0900
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2017-11-26
+
+--- libffi-platypus-perl-0.47.orig/inc/My/ShareConfig.pm
++++ libffi-platypus-perl-0.47/inc/My/ShareConfig.pm
+@@ -34,7 +34,7 @@ sub set
+ my($self, $name, $value) = @_;
+ $self->{$name} = $value;
+ my %data = %$self;
+- my $data = JSON::PP->new->pretty->encode(\%data);
++ my $data = JSON::PP->new->canonical->pretty->encode(\%data);
+ my $fh;
+ open($fh, '>', 'share/config.json');
+ print $fh $data;
--- a/debian/patches/series 1970-01-01 09:00:00.000000000 +0900
--- b/debian/patches/series 2017-11-26 11:24:58.915595536 +0900
@@ -0,0 +1 @@
+0001-reproducible-build.patch
--- End Message ---
--- Begin Message ---
Version: 0.47-3
On Sun, 26 Nov 2017 11:28:41 +0900, Chris Lamb wrote:
> Source: libffi-platypus-perl
> Version: 0.47-1
> Severity: wishlist
> Tags: patch
> User: [email protected]
> Usertags: randomness
> X-Debbugs-Cc: [email protected]
>
> Hi,
>
> Whilst working on the Reproducible Builds effort [0], we noticed
> that libffi-platypus-perl could not be built reproducibly.
>
> This is because it rendered JSON without calling "canonical" to
> ensure determinsitic sorting which ended up in a "config.json"
> file.
>
> Patch attached.
Dam has included the patch in 0.47-3, and tests.reproducible-builds.org
is happy with this version, hence I'm doing a versioned close now.
Thanks Chris & Dam!
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Die Tontauben: jonny
signature.asc
Description: Digital Signature
--- End Message ---
