Your message dated Tue, 02 Jan 2018 00:34:38 +0000
with message-id <[email protected]>
and subject line Bug#886032: fixed in markdown 1.0.1-10
has caused the Debian Bug report #886032,
regarding markdown: Please make /usr/bin/markdown exit with a non-zero exit 
code if cannot open input file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
886032: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886032
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: markdown
Version: 1.0.2~b8-3
Severity: wishlist
Tags: patch

Hi,

  $ markdown does-not-exist 
  Can't open does-not-exist: No such file or directory at /usr/bin/markdown 
line 221.
  Use of uninitialized value $text in substitution (s///) at /usr/bin/markdown 
line 248.
  Use of uninitialized value $text in substitution (s///) at /usr/bin/markdown 
line 249.

  $ echo $?
  0

This would appear to violate UNIX principles, etc. Instead, please make
/usr/bin/markdown exit with a non-zero exit code if cannot open the input
file.

Patch attached.


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
diff --git a/Markdown.pl b/Markdown.pl
index 9f85caa..013cd6c 100755
--- a/Markdown.pl
+++ b/Markdown.pl
@@ -228,7 +228,7 @@ elsif (! $g_perl_module) {
                my $text;
                {
                        local $/;               # Slurp the whole file
-                       $text = <>;
+                       defined($text = <>) or exit 2;
                }
         print Markdown($text);
     }

--- End Message ---
--- Begin Message ---
Source: markdown
Source-Version: 1.0.1-10

We believe that the bug you reported is fixed in the latest version of
markdown, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matt Kraai <[email protected]> (supplier of updated markdown package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 01 Jan 2018 16:09:01 -0800
Source: markdown
Binary: markdown
Architecture: source all
Version: 1.0.1-10
Distribution: unstable
Urgency: medium
Maintainer: Matt Kraai <[email protected]>
Changed-By: Matt Kraai <[email protected]>
Description:
 markdown   - Text-to-HTML conversion tool
Closes: 886032
Changes:
 markdown (1.0.1-10) unstable; urgency=medium
 .
   * Exit with a non-zero exit code if the input file cannot be opened,
     thanks to Chris Lamb, closes: #886032.
Checksums-Sha1:
 2df28943208fa8c3f55b0d234d7e60fb08543b6a 1679 markdown_1.0.1-10.dsc
 9dcebe8149a366c1fd345ee8af466fa7244914ab 3522 markdown_1.0.1-10.diff.gz
 4ca52808d42dc466b0ab5f7e3d03b56959048272 17400 markdown_1.0.1-10_all.deb
 a21a345b7780c07c09c31cea181e2a7d72bcf3d0 4396 markdown_1.0.1-10_amd64.buildinfo
Checksums-Sha256:
 8fba0ecef06402cdc42ed119870138c68ff9a691398d8c9c81edd307cd2d2941 1679 
markdown_1.0.1-10.dsc
 e9f7bdbe9137c07ac59c307e94842d73575f6aebdfe1d1a04843c252be79fd8e 3522 
markdown_1.0.1-10.diff.gz
 b6edda940b633afe5575fc271c0b417e79b0e527bbc0c89ca4fb48ce7eaa1471 17400 
markdown_1.0.1-10_all.deb
 004df58bf4fa286eaa7142873ad0eced181920262a39e93052d6d25cf97c5419 4396 
markdown_1.0.1-10_amd64.buildinfo
Files:
 4e808f888eebbdb782f690eca8451d46 1679 web optional markdown_1.0.1-10.dsc
 76d042b620bcb3a2f84293cd7d4bdf47 3522 web optional markdown_1.0.1-10.diff.gz
 38772c6f06619f9f110a95238d01956b 17400 web optional markdown_1.0.1-10_all.deb
 7d1f239d424e1a206b6dc4c88db2fbfb 4396 web optional 
markdown_1.0.1-10_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEzBhTHFLLFXI6Bu+fHpMQ2a3OYGUFAlpK0DsQHGtyYWFpQGZ0
YmZzLm9yZwAKCRAekxDZrc5gZc9xD/sFqrig3840fqjiUq5Gv1we/QuAEi8LXFzB
a/kowdskt+KbQLraY2z4uB5cD8CpgoxcxFOAEbwkr26PRIM7YMk618Wi4YsAvB/x
3y54m19OQJB0sBF81cQL/XbG3qpdUhsFmHnojZCMQryvgG2AF+AaNjUioesWAwnt
eTf4cytJD5tXs8Xfpl1TVN03CS6ZchAasZ8a/gPr6wQE5s5sYN0WcR7hSGxd4JVl
BMTYhiV8Joe8zai7c97XA5TOYrggkn4uOBdNmkTmYTyPRMSPrWd5ICxZSEdWPQHW
s/OGFydKPZ2wwwlNtuOcosy2U3NqQiCamTrhF7BlZQcRiZ2gG3RD5WJZaHXCIkOK
Wiz4qzpGtGWFCKOe5AnucCI3u72ujhW2VIxn58bRa1UGm05HwUVqwE5WLy5sLmTr
DvN+4mqOO1a5UErTDE6VONKN+TcbNf0HUaP2Ew6CX9NlGufkC1DnIfIqabR/5biT
w/1yGcZP6OKVq4I2NhXv/yUL0im0DsV433Q6K7FKCXEVyJqL0m/L5nt389CV/Q2e
NMHQcK6QBajol4ihvbFCxVINm09jdhQUEzDLEQSAxj2DHAIKE0EWgpSiFe44Feot
U1mIGC6qH81uI2wfex5/4KKSaL9pMhM/kkBL/Lmzm1CSVNFFqIxPxB1Z0JaD19S5
H8AXJ3d8TQ==
=qqTp
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to