Your message dated Sun, 04 Feb 2018 00:34:54 +0000
with message-id <[email protected]>
and subject line Bug#889185: fixed in pps-tools 1.0.2-1
has caused the Debian Bug report #889185,
regarding pps-tools: Please make build compatible with -Wl,--as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
889185: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889185
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pps-tools
Version: 1.0.1-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu bionic ubuntu-patch
Dear Bernd,
The latest version of pps-tools has failed to build in Ubuntu, because one
of the programs uses libm but the Makefile passes -lm in a way that is
incompatible with -Wl,--as-needed, which is a default linker flag in Ubuntu.
The attached patch, which is more strictly correct, fixes the build failure
in Ubuntu. Please consider applying it in Debian.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru pps-tools-1.0.1/debian/patches/linker-flag-order.patch
pps-tools-1.0.1/debian/patches/linker-flag-order.patch
--- pps-tools-1.0.1/debian/patches/linker-flag-order.patch 1969-12-31
16:00:00.000000000 -0800
+++ pps-tools-1.0.1/debian/patches/linker-flag-order.patch 2018-02-02
21:50:06.000000000 -0800
@@ -0,0 +1,20 @@
+Description: fix linking under -Wl,--as-needed
+ Ubuntu's linker uses -Wl,--as-needed by default, which causes ppswatch
+ to fail to link because of the order of options on the commandline. Add
+ -lm to LDLIBS instead of LDFLAGS, which will cause it to be passed in
+ the right order.
+Author: Steve Langasek <[email protected]>
+
+Index: pps-tools-1.0.1/Makefile
+===================================================================
+--- pps-tools-1.0.1.orig/Makefile
++++ pps-tools-1.0.1/Makefile
+@@ -3,7 +3,7 @@
+ CFLAGS += -Wall -O2 -D_GNU_SOURCE
+ CFLAGS += -ggdb
+ CFLAGS += -fPIC
+-LDFLAGS += -lm
++LDLIBS += -lm
+
+ # -- Actions section --
+
diff -Nru pps-tools-1.0.1/debian/patches/series
pps-tools-1.0.1/debian/patches/series
--- pps-tools-1.0.1/debian/patches/series 1969-12-31 16:00:00.000000000
-0800
+++ pps-tools-1.0.1/debian/patches/series 2018-02-02 21:42:30.000000000
-0800
@@ -0,0 +1 @@
+linker-flag-order.patch
--- End Message ---
--- Begin Message ---
Source: pps-tools
Source-Version: 1.0.2-1
We believe that the bug you reported is fixed in the latest version of
pps-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bernd Zeimetz <[email protected]> (supplier of updated pps-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 04 Feb 2018 01:05:11 +0100
Source: pps-tools
Binary: pps-tools
Architecture: source
Version: 1.0.2-1
Distribution: unstable
Urgency: medium
Maintainer: Bernd Zeimetz <[email protected]>
Changed-By: Bernd Zeimetz <[email protected]>
Description:
pps-tools - LinuxPPS support tools and headers
Closes: 889185
Changes:
pps-tools (1.0.2-1) unstable; urgency=medium
.
* [efb1ff7] Merge branch 'master' into debian
Updating to 1.0.2 (Closes: #889185, Thanks to
Steve Langasek and Alexander Gerasiov).
Checksums-Sha1:
5eeb03b08c0e9092a995d53ad0e0d1af5698bd77 1816 pps-tools_1.0.2-1.dsc
8a5b4de079c33390e49248b8bd4eb198d17bdcbd 12701 pps-tools_1.0.2.orig.tar.gz
31ff7841a675705e20c8add1222548595a789ec3 3064 pps-tools_1.0.2-1.debian.tar.xz
9d055f413e2c4ddce1e35b6ffa0ee4736d79c928 5588
pps-tools_1.0.2-1_source.buildinfo
Checksums-Sha256:
f0eefeffda627f2a7955a556e166e307d11c1e6f9f692cf58c01f9bdfb6ab3c2 1816
pps-tools_1.0.2-1.dsc
1a7efd66152e5439b69143f1f380b40ac5decbbbef516b37a017410b8ba7dff4 12701
pps-tools_1.0.2.orig.tar.gz
5a28f0a41b4966287d1dbbce550573ca3f63283b8820a78596b4837e9a5a09d5 3064
pps-tools_1.0.2-1.debian.tar.xz
ce7757114c72011a9268ca254a85171750c7fe3b9ad452061b54075928d42198 5588
pps-tools_1.0.2-1_source.buildinfo
Files:
20ca85bbcfa747752aee2e7f3211c596 1816 devel extra pps-tools_1.0.2-1.dsc
6eddfeb151cffe8751f4766e428b8eb7 12701 devel extra pps-tools_1.0.2.orig.tar.gz
72fe12e1b4aace2e40f5fc628b108a6d 3064 devel extra
pps-tools_1.0.2-1.debian.tar.xz
297f35704276f29a7780cab39e477fcb 5588 devel extra
pps-tools_1.0.2-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE7KHj8o4RJDLUhd2V6zYXGm/5Q18FAlp2T3EACgkQ6zYXGm/5
Q1+u3Q/7BDxYieG66lW01JWp9eJ3GMPIxCimzXqKuPRHiNcvyG5vGlX/hs4le8n7
m9TGhNy8VlOe+um4NMdchanK622DLUVn458HfRKy/aCFDFBRkQZUm4mFyqGBqbQU
zqdaSZ5SiLuSP/7lLD66RRlJQxWwsgP25QcI7PRf4yWHW02qkyPdTa1MUFulXdFZ
L7tkH3fLqpqi3H5Z4qkRejFgGpq1F9qkDujDHBU5xyr6D9OcoIYykzxLvTfpQE+j
4GLHYe4D/wKl7XAm4Tg1k3CjziEFruC8klNLaodDSaYp+BXcaOYy9+J9Hkng0qKt
k6cystMsNOChOqM+WxLA6tLcYTNdJ1Gr01bzJreSjkB0lQa9G9kY9Om5VQDl46Zf
6p+Fkyxsde1RAE76Lxd92+GwFFLLp2bDPtNhcCfrRuIt28qujkhLz4OCEytlFvKw
sjva+CbhGyGCbGf6v6ZSHSxkDUktc7ybaEh+LlNq/k1ojxE4AroB/E7YMhNeusUg
3wNkN4z0rZ5aL38HK+LqbRygr8BeEM34gX/npueGdqAsYj8TjCEDW4D1XcSk1vn8
WCa8FTDxz9UJqn761qUVlSod65q3DezeJthXpOrMu/6T70h6oEXk7tKXBz67ijWB
iAKVhHQfBVntIJKowEn8APfC0c6YFiKNAqOOYgOPGYnLyZpjL0I=
=DCQ8
-----END PGP SIGNATURE-----
--- End Message ---
