Your message dated Fri, 27 Apr 2018 12:51:53 +0000 with message-id <[email protected]> and subject line Bug#888644: fixed in prosody 0.10.0-2 has caused the Debian Bug report #888644, regarding prosody: logrotate error when prosody is not running to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 888644: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888644 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: prosody Version: 0.10.0-1 Severity: normal Tags: patch Dear Maintainer, When prosody is not running, the postrotate script of /etc/logrotate.d/prosody exits with code 1 and causes logrotate to print the following error message: /etc/cron.daily/logrotate: error: error running shared postrotate script for '/var/log/prosody/prosody.log /var/log/prosody/prosody.err ' run-parts: /etc/cron.daily/logrotate exited with return code 1 Since prosody is not running, there is no need to reload its configuration and the postrotate script should exit without error. The attached patch makes this change. Cheers, Kevin -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (990, 'testing'), (500, 'testing-debug'), (500, 'unstable'), (101, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.14.12-kevinoid1 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages prosody depends on: ii adduser 3.116 ii libc6 2.26-4 ii libidn11 1.33-2.1 ii libssl1.1 1.1.0g-2 ii lsb-base 9.20170808 ii lua-bitop [lua5.1-bitop] 1.0.2-4 ii lua-expat [lua5.1-expat] 1.3.0-4 pn lua-filesystem <none> ii lua-socket [lua5.1-socket] 3.0~rc1+git+ac3201d-3 pn lua5.1 <none> pn lua5.1-filesystem <none> pn lua5.1-sec <none> ii ssl-cert 1.0.39 Versions of packages prosody recommends: pn lua5.1-event <none> Versions of packages prosody suggests: pn lua-dbi-mysql <none> pn lua-dbi-postgresql <none> pn lua-dbi-sqlite3 <none> pn lua-zlib <none>>From fa736e4f89990d0fb5055bbfe34a5efe6df207d5 Mon Sep 17 00:00:00 2001 Message-Id: <fa736e4f89990d0fb5055bbfe34a5efe6df207d5.1517124523.git.ke...@kevinlocke.name> From: Kevin Locke <[email protected]> Date: Sun, 28 Jan 2018 00:26:08 -0700 Subject: [PATCH] Avoid postrotate error when prosody is not running When prosody is not running, /var/run/prosody/prosody.pid will not exist. This caused the postrotate script to exit with code 1 and caused logrotate to print the following error message: /etc/cron.daily/logrotate: error: error running shared postrotate script for '/var/log/prosody/prosody.log /var/log/prosody/prosody.err ' run-parts: /etc/cron.daily/logrotate exited with return code 1 Fix this by exiting with code 0 when the PID file does not exist, since reloading prosody is not required in this case. Signed-off-by: Kevin Locke <[email protected]> --- debian/prosody.logrotate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/prosody.logrotate b/debian/prosody.logrotate index c13ccd7..1869e3d 100644 --- a/debian/prosody.logrotate +++ b/debian/prosody.logrotate @@ -5,7 +5,7 @@ delaycompress create 640 prosody adm postrotate - [ -e /var/run/prosody/prosody.pid ] && /etc/init.d/prosody reload > /dev/null + [ ! -e /var/run/prosody/prosody.pid ] || /etc/init.d/prosody reload > /dev/null endscript sharedscripts missingok -- 2.15.1
--- End Message ---
--- Begin Message ---Source: prosody Source-Version: 0.10.0-2 We believe that the bug you reported is fixed in the latest version of prosody, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sergei Golovan <[email protected]> (supplier of updated prosody package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 27 Apr 2018 13:54:50 +0300 Source: prosody Binary: prosody Architecture: source amd64 Version: 0.10.0-2 Distribution: unstable Urgency: medium Maintainer: Matthew James Wild <[email protected]> Changed-By: Sergei Golovan <[email protected]> Description: prosody - Lightweight Jabber/XMPP server Closes: 827689 851519 851669 883905 888644 Changes: prosody (0.10.0-2) unstable; urgency=medium . * Move the prosody PID file to /run/prosody (closes: #883905). * Exit the logrotate postrotate script with zero status if prosody isn't running (closes: #888644). * Add /usr/local/lib/prosody/modules to a modules search path for local administrators. Remove VirtualHost example from the main config in favor of subconfigs (closes: #827689). * Copy the example snakeoil certificate to /etc/prosody/certs instead of linking it. This helps not to add prosody to the ssl-cert group which may be troubling from a security standpoint (closes: #851669). * Add a systemd unit file, don't daemonize the server, letting systemd or start-stop-daemon do that (closes: #851519). * Bump the debhelper compatibility level to 11. * Bump the standards version to 4.1.4. * Fix the package VCS headers. Checksums-Sha1: 3ba003a53ce2853e1de6054dbf7003c0aad9b5a9 2046 prosody_0.10.0-2.dsc a6e08c2f8354d14281829df99cecb0a1f60a4bc7 15100 prosody_0.10.0-2.debian.tar.xz 5bdb4066d77c3c6b13331ca9b29375ac049b7f43 46900 prosody-dbgsym_0.10.0-2_amd64.deb 9dfa7e01140ad33370e710d19f18798170a10a2f 6400 prosody_0.10.0-2_amd64.buildinfo f41d44cd0f618b9485ebffa4374351b7d8d36f41 248536 prosody_0.10.0-2_amd64.deb Checksums-Sha256: 1a87fe0fb8f685233cf36d954b0bbe13917445b2efde992e26ff8c1eb47a39e5 2046 prosody_0.10.0-2.dsc 641c7bd6a97dd65fa372fc8b74fcf36c5af2c7960013ca084b894a48a023abda 15100 prosody_0.10.0-2.debian.tar.xz c0bb5b8fcf5a75f6aa12796b82ac50018be478e36ab33312d3f1b4fb0a2ec0d6 46900 prosody-dbgsym_0.10.0-2_amd64.deb a9c272b48b516246f616ebd0e24382788aa5748d42c1660abea1060f6dced03a 6400 prosody_0.10.0-2_amd64.buildinfo cbf426399860c972f4cbceaa79d1aaca761cf7038a69bae9713fa86c3c989ab0 248536 prosody_0.10.0-2_amd64.deb Files: c46f0be64adc0dd95ce68eba63815fdf 2046 net optional prosody_0.10.0-2.dsc 957ab9bd9cdfe9dd960f6222b8220056 15100 net optional prosody_0.10.0-2.debian.tar.xz cdd492708cba5e570585e3f652c11b38 46900 debug optional prosody-dbgsym_0.10.0-2_amd64.deb a6ce4df269b6ba8e0f56045d2b32ebd4 6400 net optional prosody_0.10.0-2_amd64.buildinfo 1efc96f6616cc5ca070f0cebc6f889ca 248536 net optional prosody_0.10.0-2_amd64.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE/SYPsyDB+ShSnvc4Tyrk60tj54cFAlrjFs0ACgkQTyrk60tj 54dGiQ//UZnwJRA/SzU7D4nJw+u2CVD4BvdK6tkKKvqoXUQCtJlOIhMkFrfs8BL0 /hC8+VHKsAro2SQSZGG9DtO+R6xrQB31VH+U+JbzGshSHTk0+Nh4NpZ69u/tLmfc CKwRyIIiJiOHWGNyzL9FtW852JPbGdS6OatkfMhPHPjqYtPkedvyGjlO5uoGMhYy jcSrBVB2wB4Z4cWqX/C0cLXts96Q28BuZnCE2Z8NBcksDJgGWcyRu0cMRRxkhvkR GWz4IqTuUkDc/SJ739CuJyCbiar+Aq7W9m20gIkdu39T+ZU1DpfpQuVP1NbLXN6F z+fxzPucU/Nqx5eZPDyaUoFiDscyQ+8rGFOu74Nt3hWSvtYS60kfTD2uOkOLurIJ xVPx4JDfyx7M+SpXzY2o361qqs7kOo22ag8kTP3bxWwAWWtvlz+skg718Sujb04H Cx84jnZO9i5WHtkPRcNLlra96dL0m1/830Uhsdbb+Dj9JbbfCYh8CQmsBqd9dAgG LubV0NYTgrKoJr3p85P3UMKZgFuZHJlR7f43V/NXV4X3TRixHwAdlUltHdLbZ/r8 ab6tkNi9XAMJ2kS6HsfJHCv1zexfjYZTKF5ZYpg8IQNIoZJR90BTPtcCELALA67H DlUztTg//7ai6rglP8WZiEbovp2DTfOpaTr4eZSHdGya5JeBs8E= =DUVB -----END PGP SIGNATURE-----
--- End Message ---
