Your message dated Sun, 26 Mar 2006 13:47:56 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#350804: fixed in gmoo 0.5.6-9
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: gmoo
Version: 0.5.6-7
Severity: normal
Tags: patch


When gmoo connects to the moo server, it sends MCP authentication.
During that process, it also, erroneously, sends an empty line.

Normally, this isn't a big deal, but when using mooproxy, the newline
gets channeled through to the server, causing the already connected
player to become unidle.

The patch is trivial:


diff -ur gmoo-0.5.6/src/mcp.c gmoo-0.5.6-fixed/src/mcp.c
--- gmoo-0.5.6/src/mcp.c        2005-07-12 17:09:49.000000000 +0200
+++ gmoo-0.5.6-fixed/src/mcp.c  2005-08-02 02:51:00.459718751 +0200
@@ -57,7 +57,7 @@
     s->multilines = NULL;
 
     str = g_malloc(strlen(s->key) + 100);
-    sprintf(str, "#$#mcp authentication-key: %s version: %d.%d to: %d.%d\n",
+    sprintf(str, "#$#mcp authentication-key: %s version: %d.%d to: %d.%d",
             s->key, client_min.major, client_min.minor,
             client_max.major, client_max.minor);
     gm_world_writeln(w, str);


The problem is gm_world_writeln() appends its own newline. The newline
in the above string is thus not necessary. An alternative solution would
be to change gm_world_writeln() so that it doesn't append a newline when
the passed string is already newline terminated.


Marcel Moreaux <[EMAIL PROTECTED]>


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.8.1
Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)

Versions of packages gmoo depends on:
ii  gdk-imlib1                1.9.14-28      compatibility package for gdk-imli
ii  libc6                     2.3.5-12       GNU C Library: Shared libraries an
ii  libgdk-pixbuf2            0.22.0-11      The GdkPixBuf image library, gtk+ 
ii  libglib1.2                1.2.10-10.1    The GLib library of C routines
ii  libgtk1.2                 1.2.10-18      The GIMP Toolkit set of widgets fo
ii  libice6                   6.9.0.dfsg.1-4 Inter-Client Exchange library
ii  libperl5.8                5.8.7-10       Shared Perl library
ii  libsm6                    6.9.0.dfsg.1-4 X Window System Session Management
ii  libx11-6                  6.9.0.dfsg.1-4 X Window System protocol client li
ii  libxext6                  6.9.0.dfsg.1-4 X Window System miscellaneous exte
ii  libxi6                    6.9.0.dfsg.1-4 X Window System Input extension li
ii  libzvt2                   1.4.2-30       The GNOME zvt (zterm) widget
ii  tcl8.4                    8.4.11-1       Tcl (the Tool Command Language) v8
ii  xlibs                     6.9.0.dfsg.1-4 X Window System client libraries m
ii  zlib1g                    1:1.2.3-9      compression library - runtime

gmoo recommends no packages.

-- no debconf information


--- End Message ---
--- Begin Message ---
Source: gmoo
Source-Version: 0.5.6-9

We believe that the bug you reported is fixed in the latest version of
gmoo, which is due to be installed in the Debian FTP archive:

gmoo_0.5.6-9.diff.gz
  to pool/main/g/gmoo/gmoo_0.5.6-9.diff.gz
gmoo_0.5.6-9.dsc
  to pool/main/g/gmoo/gmoo_0.5.6-9.dsc
gmoo_0.5.6-9_powerpc.deb
  to pool/main/g/gmoo/gmoo_0.5.6-9_powerpc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul van Tilburg <[EMAIL PROTECTED]> (supplier of updated gmoo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 26 Mar 2006 22:06:01 +0200
Source: gmoo
Binary: gmoo
Architecture: source powerpc
Version: 0.5.6-9
Distribution: unstable
Urgency: low
Maintainer: Paul van Tilburg <[EMAIL PROTECTED]>
Changed-By: Paul van Tilburg <[EMAIL PROTECTED]>
Description: 
 gmoo       - a GTK+ based MOO (and MUD) Client
Closes: 350804 353614
Changes: 
 gmoo (0.5.6-9) unstable; urgency=low
 .
   * Applied patch to remove the superfluous newline during the 
mcp-authentication
     (courtesy of Marcel Moreaux <[EMAIL PROTECTED]>, closes: #350804).
   * Added Swedish translation
     (courtesy of Daniel Nylander <[EMAIL PROTECTED]>, closes: #353614).
   * Bumped standards version to 3.6.2.2.
Files: 
 f8cb0658459a1d04c5c8fa4e1d0f6adf 658 net optional gmoo_0.5.6-9.dsc
 4effa105b53459c5e89988409ab66c6e 140359 net optional gmoo_0.5.6-9.diff.gz
 f05b6f4c113f45f8261c6edc93e4fa42 181962 net optional gmoo_0.5.6-9_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEJvxaJBBhylAGQYERAieEAKCcqGVqTHo5dtV3JXnpwv1ijvQNiACfW9XW
LPtt8UjmF+PKA6wCCCsiBNY=
=f3J9
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to