Your message dated Fri, 8 Jun 2018 12:35:21 +0000
with message-id <[email protected]>
and subject line fixed in 0.85
has caused the Debian Bug report #895379,
regarding [piuparts] Create /dev/null if it doesn't exist ASAP
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
895379: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895379
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: piuparts
Version: 0.84
Severity: normal
Tags: patch

Hi holger, I've moved the creation of ${ENV}/dev/null ASAP, because in some
environments it is created as a regular file and then `apt-get update` hangs
forever.

-- 
TiN
From afbee5ef7a72bc29cc18452c34e3c8b8cd97a602 Mon Sep 17 00:00:00 2001
From: Agustin Henze <[email protected]>
Date: Tue, 10 Apr 2018 16:58:19 -0300
Subject: [PATCH 1/2] Create ${ENV}/dev/null if it doesn't exist ASAP

Signed-off-by: Agustin Henze <[email protected]>
---
 piuparts.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/piuparts.py b/piuparts.py
index 90a2851b..16df93d7 100644
--- a/piuparts.py
+++ b/piuparts.py
@@ -1134,6 +1134,8 @@ class Chroot:
         self.create_resolv_conf()
         for bindmount in settings.bindmounts:
             self.mount(bindmount, bindmount, opts="bind")
+        if not os.path.exists(self.name + '/dev/null'):
+            run(['mknod', '-m' ,'666', self.name + '/dev/null', 'c', '1', '3'])
 
     def remember_available_md5(self):
         """Keep a history of 'apt-cache dumpavail | md5sum' after initial
@@ -1416,9 +1418,6 @@ class Chroot:
                     'broken-symlink',
             ]
             ignored_tags = []
-            if not os.path.exists(self.name + '/dev/null'):
-                device = os.makedev(1, 3)
-                os.mknod(self.name + '/dev/null', 0o666, device)
             (status, output) = run(["adequate", "--root", self.name] + packages, ignore_errors=True)
             for tag in ignored_tags:
                 # ignore some tags
-- 
2.17.0

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
version: 0.85

piuparts (0.85) unstable; urgency=medium

  [ Agustin Henze ]
  * piuparts.py:
    - Add docker support, new param is introduced `--docker-image`.
      (Closes: #893731)
    - Deprecate --keep-tmpdir in favor of --keep-env (Closes: #894232)
    - Create ${ENV}/dev/ptmx path if it doesn't exist (Closes: 895380)
    - Create ${ENV}/dev/null if it doesn't exist ASAP (Closes: 895379)
  * Add `docker.io` as suggested package.
  * Reworded documentation for `--keep-env` and `--schroot` parameters.

  [ Holger Levsen ]
  * dwke.py: change logging to make relevant information more visible.
  * detect_*_issues.in: improve output.
  * report_untestable_packages.in: improve output.
  * piuparts.1.txt: improve wording for docker related changes and add
    explaination about the limitations of docker support.
  * Bump standards version to 4.1.4, no changes needed.

 -- Holger Levsen <[email protected]>  Sat, 14 Apr 2018 17:39:13 -0300


-- 
cheers,
        Holger

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to