Your message dated Fri, 22 Jun 2018 16:05:49 +0000
with message-id <[email protected]>
and subject line Bug#902112: fixed in trafficserver 7.1.3+ds-4
has caused the Debian Bug report #902112,
regarding trafficserver FTBFS on armel
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
902112: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902112
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: trafficserver
Version: 3.3.0-1
Severity: important
Tags: patch
https://buildd.debian.org/status/logs.php?pkg=trafficserver&arch=armel
...
{standard input}: Assembler messages:
{standard input}:1649: Error: selected processor does not support `dmb' in ARM
mode
{standard input}:6365: Error: selected processor does not support `dmb' in ARM
mode
The upstream fix is attached.
>From 2c0e048c8445a4d6dc70d3b93133aeae5ae0f539 Mon Sep 17 00:00:00 2001
From: Phil Sorber <[email protected]>
Date: Thu, 5 Oct 2017 13:36:43 -0600
Subject: Remove custom memory barriers from header_rewrite and replace with
std::atomic
---
plugins/header_rewrite/conditions.cc | 3 ++-
plugins/header_rewrite/lulu.h | 33 ---------------------------------
2 files changed, 2 insertions(+), 34 deletions(-)
diff --git a/plugins/header_rewrite/conditions.cc
b/plugins/header_rewrite/conditions.cc
index f2f81cbe8..b316fca1c 100644
--- a/plugins/header_rewrite/conditions.cc
+++ b/plugins/header_rewrite/conditions.cc
@@ -25,5 +25,6 @@
#include <cctype>
#include <sstream>
+#include <atomic>
#include "ts/ts.h"
@@ -175,7 +176,7 @@ ConditionAccess::eval(const Resources & /* res ATS_UNUSED
*/)
bool check = !access(_qualifier.c_str(), R_OK);
tv.tv_sec += 2;
- mb();
+ std::atomic_thread_fence(std::memory_order_seq_cst);
_next = tv.tv_sec; // I hope this is an atomic "set"...
_last = check; // This sure ought to be
}
diff --git a/plugins/header_rewrite/lulu.h b/plugins/header_rewrite/lulu.h
index 555ef2e2c..43ac22348 100644
--- a/plugins/header_rewrite/lulu.h
+++ b/plugins/header_rewrite/lulu.h
@@ -34,39 +34,6 @@ std::string getIP(sockaddr const *s_sockaddr);
char *getIP(sockaddr const *s_sockaddr, char res[INET6_ADDRSTRLEN]);
uint16_t getPort(sockaddr const *s_sockaddr);
-// Memory barriers
-#if defined(__i386__)
-#define mb() __asm__ __volatile__("lock; addl $0,0(%%esp)" : : : "memory")
-#define rmb() __asm__ __volatile__("lock; addl $0,0(%%esp)" : : : "memory")
-#define wmb() __asm__ __volatile__("" : : : "memory")
-#elif defined(__x86_64__)
-#define mb() __asm__ __volatile__("mfence" : : : "memory")
-#define rmb() __asm__ __volatile__("lfence" : : : "memory")
-#define wmb() __asm__ __volatile__("" : : : "memory")
-#elif defined(__mips__)
-#define mb() __asm__ __volatile__("sync" : : : "memory")
-#define rmb() __asm__ __volatile__("sync" : : : "memory")
-#define wmb() __asm__ __volatile__("" : : : "memory")
-#elif defined(__arm__)
-#define mb() __asm__ __volatile__("dmb" : : : "memory")
-#define rmb() __asm__ __volatile__("dmb" : : : "memory")
-#define wmb() __asm__ __volatile__("" : : : "memory")
-#elif defined(__mips__)
-#define mb() __asm__ __volatile__("sync" : : : "memory")
-#define rmb() __asm__ __volatile__("sync" : : : "memory")
-#define wmb() __asm__ __volatile__("" : : : "memory")
-#elif defined(__powerpc64__)
-#define mb() __asm__ __volatile__("sync" : : : "memory")
-#define rmb() __asm__ __volatile__("sync" : : : "memory")
-#define wmb() __asm__ __volatile__("sync" : : : "memory")
-#elif defined(__aarch64__)
-#define mb() __asm__ __volatile__("dsb sy" : : : "memory")
-#define rmb() __asm__ __volatile__("dsb ld" : : : "memory")
-#define wmb() __asm__ __volatile__("dsb st" : : : "memory")
-#else
-#error "Define barriers"
-#endif
-
extern const char PLUGIN_NAME[];
extern const char PLUGIN_NAME_DBG[];
--
2.11.0
--- End Message ---
--- Begin Message ---
Source: trafficserver
Source-Version: 7.1.3+ds-4
We believe that the bug you reported is fixed in the latest version of
trafficserver, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jean Baptiste Favre <[email protected]> (supplier of updated trafficserver
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 22 Jun 2018 17:13:53 +0200
Source: trafficserver
Binary: trafficserver trafficserver-experimental-plugins trafficserver-dev
Architecture: source amd64
Version: 7.1.3+ds-4
Distribution: unstable
Urgency: medium
Maintainer: Aron Xu <[email protected]>
Changed-By: Jean Baptiste Favre <[email protected]>
Description:
trafficserver - fast, scalable and extensible HTTP/1.1 compliant caching proxy
se
trafficserver-dev - Apache Traffic Server Software Developers Kit (SDK)
trafficserver-experimental-plugins - experimental plugins for Apache Traffic
Server
Closes: 902112
Changes:
trafficserver (7.1.3+ds-4) unstable; urgency=medium
.
* Fix FTBS on armel (Closes: #902112)
Checksums-Sha1:
ae12be76d2e8ec28a8895ba810c31fbd31d516ab 2709 trafficserver_7.1.3+ds-4.dsc
b41f996c58fbd2cd1a66b8c3ffcb47b64698b647 575556
trafficserver_7.1.3+ds-4.debian.tar.xz
db19f25c1b49296a498a3a0d51faa97eae0a5395 46516780
trafficserver-dbgsym_7.1.3+ds-4_amd64.deb
5caf470ba8624033a0ace89fa1e9c183c02ccca4 361396
trafficserver-dev_7.1.3+ds-4_amd64.deb
e3e4c490c8b48831f01c610f45e74e9c00eeb345 2412668
trafficserver-experimental-plugins-dbgsym_7.1.3+ds-4_amd64.deb
ffe28cabb15d5610ba587ee4bdf4fe19bc3f4516 297100
trafficserver-experimental-plugins_7.1.3+ds-4_amd64.deb
eef13a7db1fb34f8a517386351c10228f2db4442 14388
trafficserver_7.1.3+ds-4_amd64.buildinfo
abd61360e56acf5218a34d2c0406ff28cec3fd49 2930244
trafficserver_7.1.3+ds-4_amd64.deb
Checksums-Sha256:
f0618ae44427d74ad1c41ea64a0fa525bd45ef40afb715a8cf570038c1d303f8 2709
trafficserver_7.1.3+ds-4.dsc
3db4e263a41a5563dce53710476522d0e4999baadc5b596f01dd91ab854ebda9 575556
trafficserver_7.1.3+ds-4.debian.tar.xz
e343fb24505b4723c568a7af23b73d983d62016870b411222b7a54332869ee6d 46516780
trafficserver-dbgsym_7.1.3+ds-4_amd64.deb
5bd5ce68b579da536323b94496f16b7bee9ed55a2f0450f940b191a059744ddf 361396
trafficserver-dev_7.1.3+ds-4_amd64.deb
1c9047223e9a38d17e7c1c08332354db6738e7b874a91255a43019781462d120 2412668
trafficserver-experimental-plugins-dbgsym_7.1.3+ds-4_amd64.deb
c54721da239142847f8e6fa9474f9a3fea49512abfb8deaa8db65d6ff7d19a02 297100
trafficserver-experimental-plugins_7.1.3+ds-4_amd64.deb
b4b26556c98e3174310e9f2d08835bd8b5d6c68ca62439be330d04235da2ed69 14388
trafficserver_7.1.3+ds-4_amd64.buildinfo
72353523258193e56cda8fe99df50324dc985b87493b42eda42af8899019418b 2930244
trafficserver_7.1.3+ds-4_amd64.deb
Files:
fe856c38dc5c9af84f9778c84d36ecb8 2709 web optional trafficserver_7.1.3+ds-4.dsc
f87833c86f8a98744b3e41a1ac81a7c7 575556 web optional
trafficserver_7.1.3+ds-4.debian.tar.xz
b108bbdd3e281d27f95426e351eaa6d0 46516780 debug optional
trafficserver-dbgsym_7.1.3+ds-4_amd64.deb
b24178f07c84a4513397d8d5962856d4 361396 web optional
trafficserver-dev_7.1.3+ds-4_amd64.deb
fb4c20d39cd6b085d8ffacf9f56c128e 2412668 debug optional
trafficserver-experimental-plugins-dbgsym_7.1.3+ds-4_amd64.deb
4d88345af29fbcd66c836a0c4a988588 297100 web optional
trafficserver-experimental-plugins_7.1.3+ds-4_amd64.deb
6298b7f29f8881f5a61295068a4eedc3 14388 web optional
trafficserver_7.1.3+ds-4_amd64.buildinfo
8d95410aae14d8cb97c016dec58fcbd6 2930244 web optional
trafficserver_7.1.3+ds-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEToRbojDLTUSJBphHtN1Tas99hzcFAlstGFRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRF
ODQ1QkEyMzBDQjRENDQ4OTA2OTg0N0I0REQ1MzZBQ0Y3RDg3MzcACgkQtN1Tas99
hzeZ6w/9F6FjKlp/8Dkc8xj9DPaQ0ppUMM8mpEq+eOD1B5uJj8MZ609EZMsipfDC
3h4sM0GoHR2pJ1SHzVgQrgg5T1nm3EAL3y7MP4zv+jKqpM9VmQANpjoakSS0azoR
V4t5lYhdzTu/037X4LSn0xx8WcNB6z1z25R+jHXjmYqQk/qs6TDW6GCDzJ2xzaKM
qlKM2fTgTv8yV1yqhQ8gEriAOkQpR3ZoheAPqht92ZmVgv1lNFu/RmufTbSvPogd
PcZEwKei55IzljqoC9JiJiKyrUAZgF0B89o6jNhySMf9w9Crs/v49/DLnkx+bofN
R4iJ+vqgEnwkO4/XAp7qxLiRTVY0MLNvXrmJdhehspMg34UpIbZvmJM2Ay4uJeH7
8iUae0S159mBDNZsO/oJmMsjfW1ANSzZ5XRuTGs/N123eWJ1c+LWvD1mOA1QwLDy
q6keHOO/y7DjrI9K/7PSCExkHN+IWzMgOytfHkkWWQ+VeVbSapTI+DfBF4ZKynx0
fYSqn8Spua85ZocrBB8J4griM6mckNOWjHffImDlG8heaLxUkWi5XgPM4uDwX+rB
i0d3raEjAMklMvJEfDpAnb+EqnZOqzkugNkHLst/FIcaCoOFyIw/6nzPKMUU/eS8
RxbU4v2X5FBV3MliJLnhwp74CPcYncHkop4oRCVOS0qpqKPLiQM=
=5Ba1
-----END PGP SIGNATURE-----
--- End Message ---
