Your message dated Sat, 30 Jun 2018 08:38:07 +0000
with message-id <[email protected]>
and subject line Bug#901577: fixed in vlc 3.0.3-2
has caused the Debian Bug report #901577,
regarding vlc: Please add support for architecture "riscv64"
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
901577: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901577
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: src:vlc
Version: 3.0.1-3
Severity: normal
Tags: patch upstream
User: [email protected]
Usertags: riscv64
Hi,
vlc fails to build in riscv64:
https://buildd.debian.org/status/fetch.php?pkg=vlc&arch=riscv64&ver=3.0.3-1&stamp=1527581471&raw=0
The reason for this failure is that it needs to be linked against -latomic to be
able to work with sub-word sizes. This library is pulled in automatically when
using -pthread if needed, but presumably vlc uses -lpthread to link, which works
in most places and architectures, but not this one.
I think that this happens in this block:
https://sources.debian.org/src/vlc/3.0.3-1/configure.ac/?hl=806#L805
in which probably LIBPTHREAD="$ac_cv_search_pthread_rwlock_init" (or its use in
later parts of the compilation) gets the value "-l + pthread" instead of the
special "-pthread" needed in this case.
I can build successfully just applying the attached minimal patch to
debian/rules, which should also work fine for all arches, but maybe it would be
better to apply only to riscv64.
It would probably be better to solve this upstream, I don't know if you
can/prefer contact them or you prefer that we do it. Also not sure how likely
are they to fix the issue and how long it will take.
So we'll appreciate if you fix it in some way in Debian while it's not fixed
upstream, otherwise a big part of the archive is blocked by this package, and we
have to keep applying the patch, building the package and uploading to a special
archive for this port with every upload or binNMU to src:vlc.
Thanks and cheers.
--
Manuel A. Fernandez Montecelo <[email protected]>
diff -Nru vlc-3.0.3/debian/changelog vlc-3.0.3/debian/changelog
--- vlc-3.0.3/debian/changelog 2018-05-28 23:51:35.000000000 +0200
+++ vlc-3.0.3/debian/changelog 2018-06-08 17:41:17.000000000 +0200
@@ -1,3 +1,10 @@
+vlc (3.0.3-1+0.riscv64.1) unreleased; urgency=medium
+
+ * Non-maintainer upload.
+ * riscv64: build with -pthread
+
+ -- Manuel A. Fernandez Montecelo <[email protected]> Fri, 08 Jun 2018 15:41:17
+0000
+
vlc (3.0.3-1) unstable; urgency=medium
* New upstream release.
diff -Nru vlc-3.0.3/debian/rules vlc-3.0.3/debian/rules
--- vlc-3.0.3/debian/rules 2018-05-21 14:18:40.000000000 +0200
+++ vlc-3.0.3/debian/rules 2018-06-08 17:41:17.000000000 +0200
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
-DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
+DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed -pthread
DEB_BUILD_MAINT_OPTIONS=hardening=+all
include /usr/share/dpkg/architecture.mk
--- End Message ---
--- Begin Message ---
Source: vlc
Source-Version: 3.0.3-2
We believe that the bug you reported is fixed in the latest version of
vlc, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Ramacher <[email protected]> (supplier of updated vlc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 30 Jun 2018 10:01:23 +0200
Source: vlc
Binary: vlc libvlc-dev libvlc5 libvlccore-dev libvlccore9 libvlc-bin vlc-bin
vlc-data vlc-l10n vlc-plugin-base vlc-plugin-access-extra
vlc-plugin-video-output vlc-plugin-video-splitter vlc-plugin-visualization
vlc-plugin-skins2 vlc-plugin-qt vlc-plugin-fluidsynth vlc-plugin-jack
vlc-plugin-notify vlc-plugin-svg vlc-plugin-samba vlc-plugin-zvbi
Architecture: source
Version: 3.0.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <[email protected]>
Changed-By: Sebastian Ramacher <[email protected]>
Description:
libvlc-bin - tools for VLC's base library
libvlc-dev - development files for libvlc
libvlc5 - multimedia player and streamer library
libvlccore-dev - development files for libvlccore
libvlccore9 - base library for VLC and its modules
vlc - multimedia player and streamer
vlc-bin - binaries from VLC
vlc-data - common data for VLC
vlc-l10n - translations for VLC
vlc-plugin-access-extra - multimedia player and streamer (extra access plugins)
vlc-plugin-base - multimedia player and streamer (base plugins)
vlc-plugin-fluidsynth - FluidSynth plugin for VLC
vlc-plugin-jack - JACK audio plugins for VLC
vlc-plugin-notify - LibNotify plugin for VLC
vlc-plugin-qt - multimedia player and streamer (Qt plugin)
vlc-plugin-samba - Samba plugin for VLC
vlc-plugin-skins2 - multimedia player and streamer (Skins2 plugin)
vlc-plugin-svg - SVG plugin for VLC
vlc-plugin-video-output - multimedia player and streamer (video output plugins)
vlc-plugin-video-splitter - multimedia player and streamer (video splitter
plugins)
vlc-plugin-visualization - multimedia player and streamer (visualization
plugins)
vlc-plugin-zvbi - transitional dummy package
Closes: 901577
Changes:
vlc (3.0.3-2) unstable; urgency=medium
.
* debian/patches: Fix build on riscv64 (Closes: #901577)
Checksums-Sha1:
2055dd42cc9af25fa8248a79794886a38fe492d6 6382 vlc_3.0.3-2.dsc
30267a51cd468699060f698fa348a3d22448b407 63144 vlc_3.0.3-2.debian.tar.xz
Checksums-Sha256:
72b07c9bdd6e5fe85d05c867d2f436d4410aea6652cf1d86aeb2120911f8558f 6382
vlc_3.0.3-2.dsc
081acf3d06bce5f7a8122a8767e32b5bd2510b1b9785b95a319cae866b8c33ba 63144
vlc_3.0.3-2.debian.tar.xz
Files:
bbfc9899c33e91abb5f559f52ecb95b4 6382 video optional vlc_3.0.3-2.dsc
874f31c21617cf9bae9355cadeb794c6 63144 video optional vlc_3.0.3-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAls3OxgACgkQafL8UW6n
GZN14Q/6AiVGRzMV+GQzNqPAFbsqLhTViFGBKfHCuTcMV9pLyvKx02zEXss0wWBU
+miD2atvVXGKFDatNjXI+Yoj4HIYQrPWb6ihArfNmtT7ikxyjcp5r52DAxdbUQ1v
+KE5IjnRUFf88Sn2nddDZ8Wyi7DYvdYGWpeSOr+cBE52oBS/9ChUTOgZBybaX8ab
RBOH20gbXCoBce0BVGfxFybzI6uIUyibHEUZh0y4ZnUltQOg1YMkXGDZa7/NqwJR
Mlu7A1eSaZbsIuW2hRuX2G/jzuyhNov8WXao3INz0ObYCnEPp7pHHJa4jmdFnC3f
jCnDsZxFYCIQEE3dU0VWuBrtvUztq6vuDqhELahbwySz00X6mi+OWSvUdoSz8Ssd
ZFl4o4FaPfuA7jiOIuyxHDBuvm1Mc9Hik7fVPajxYdmQiPJje+yVFFT7kVB+Cb5M
4vVtNkqWPpP9I7z64SrZA5k/memiAZ/fBmIykvn8PraPNCGXvvyv9VkFEekyCDo3
yHXSJNEBjQpKpKcuGzIrLe6lHNqf0VU4abIi2/kcRHHnh6T9DdKCp0T/XzOMfY+W
uIpC+xe4MIgdNcoLxlOEPBW5rjYfGs/19Slc3yTKiekR3yN08mXWrHu6rj0HTPCh
qb3Ly2wrR7pxtdPG3XjZTmfzkO0JHbDJEGb3oqjRZqAfNmAGl9I=
=KVJK
-----END PGP SIGNATURE-----
--- End Message ---
