Your message dated Mon, 2 Jul 2018 11:20:54 +0800
with message-id
<CAKcpw6WcPo651C8pV9=5_dL4i_kwC10K9d+FixZZHCYV6i9e=a...@mail.gmail.com>
and subject line Re: Bug#883311: libatomic-ops: mips don't set mips3/set mips2
for mips r6
has caused the Debian Bug report #883311,
regarding libatomic-ops: mips don't set mips3/set mips2 for mips r6
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
883311: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883311
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:libatomic-ops
Version: 7.4.8-1
MIPS r6 uses different encode for ll/sc pair with r5 and previous.
So if `.set mips3' in asm, it will generate previous encode for ll/sc.
--
YunQiang Su
Index: libatomic-ops-7.4.8/src/atomic_ops/sysdeps/gcc/mips.h
===================================================================
--- libatomic-ops-7.4.8.orig/src/atomic_ops/sysdeps/gcc/mips.h
+++ libatomic-ops-7.4.8/src/atomic_ops/sysdeps/gcc/mips.h
@@ -25,11 +25,19 @@
#define AO_NO_DD_ORDERING
#if defined(_ABI64) && (_MIPS_SIM == _ABI64)
+# if defined(__mips_isa_rev) && (__mips_isa_rev >= 6)
+# define AO_MIPS_SET_ISA " \n"
+# else
# define AO_MIPS_SET_ISA " .set mips3\n"
+# endif
# define AO_MIPS_LL_1(args) " lld " args "\n"
# define AO_MIPS_SC(args) " scd " args "\n"
#else
+# if defined(__mips_isa_rev) && (__mips_isa_rev >= 6)
+# define AO_MIPS_SET_ISA " \n"
+# else
# define AO_MIPS_SET_ISA " .set mips2\n"
+# endif
# define AO_MIPS_LL_1(args) " ll " args "\n"
# define AO_MIPS_SC(args) " sc " args "\n"
# define AO_T_IS_INT
--- End Message ---
--- Begin Message ---
Ian Wienand <[email protected]> 于2018年7月2日周一 上午8:32写道：
>
> > This patch has been merged upstream, while not released with 7.6,
> > Please cherry-pick from upstream.
>
> 7.6.4 in unstable/testing appears to have this patch. Just to be
> clear, are you saying it's something critical to pull into stable?
>
Yes, this is a some old bug report.
> Thanks,
>
> -i
>
> On Mon, May 28, 2018 at 8:34 PM, YunQiang Su <[email protected]> wrote:
> > On Sat, 2 Dec 2017 15:29:56 +0800 YunQiang Su <[email protected]> wrote:
> >> Package: src:libatomic-ops
> >> Version: 7.4.8-1
> >>
> >> MIPS r6 uses different encode for ll/sc pair with r5 and previous.
> >> So if `.set mips3' in asm, it will generate previous encode for ll/sc.
> >
> > This patch has been merged upstream, while not released with 7.6,
> > Please cherry-pick from upstream.
> >
> > https://github.com/ivmai/libatomic_ops/pull/33
> >
> >>
> >> --
> >> YunQiang Su
--
YunQiang Su
--- End Message ---
