Your message dated Fri, 06 Jul 2018 23:49:23 +0000
with message-id <[email protected]>
and subject line Bug#882057: fixed in sbuild 0.77.0-1
has caused the Debian Bug report #882057,
regarding sbuild: Patches for some issues when building for ubuntu 14.04
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
882057: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882057
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: sbuild
Version: 0.73.0-4
Severity: normal
Hi. I tried to sbuild packages for ubuntu 14.04 (ubuntu chroot, sbuild
running on debian/sid), and ran into a few issues. Attached patches fix
some of those issues. The commit logs describe the issues and solutions.
Thanks!
>From a7e5edbfe55b096c991c31e595b8da4071194058 Mon Sep 17 00:00:00 2001
From: Dima Kogan <[email protected]>
Date: Sat, 18 Nov 2017 01:41:59 -0800
Subject: [PATCH 1/2] I now detect more directly if the source wasn't yet
unpacked
In check_space() we look at $self->get('DSC Dir')==undef to determine if the
source was unpacked, and if defined($self->get('DSC Dir')), we do stuff with the
source. I am observing that that this is set independently of the source being
unpacked, so now I actually look at the directory to make this determination
---
lib/Sbuild/Build.pm | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm
index 9a767a20..ece9b332 100644
--- a/lib/Sbuild/Build.pm
+++ b/lib/Sbuild/Build.pm
@@ -2674,15 +2674,17 @@ sub check_space {
my $sum = 0;
my $dscdir = $self->get('DSC Dir');
+ my $build_dir = $self->get('Build Dir');
+ my $pkgbuilddir = "$build_dir/$dscdir";
- # if the source package was not yet unpacked, then DSC Dir is undefined
- # and we will not attempt to compute the required space
- if (!defined $dscdir) {
+ # if the source package was not yet unpacked, we will not attempt to compute
+ # the required space.
+ unless( defined $dscdir && -d $dscdir)
+ {
return -1;
}
- my $build_dir = $self->get('Build Dir');
- my $pkgbuilddir = "$build_dir/$dscdir";
+
my ($space, $spacenum);
# get the required space for the unpacked source package in the chroot
--
2.14.1
>From 258865a74c5abf3a03a5a3dafe2d2911b4e5d6f7 Mon Sep 17 00:00:00 2001
From: Dima Kogan <[email protected]>
Date: Sat, 18 Nov 2017 01:45:01 -0800
Subject: [PATCH 2/2] dose3 failures no longer mask the
--build-deps-failed-commands
The code logic had a bug where if dose3 fails, the commands do not run. No
longer.
---
lib/Sbuild/Build.pm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm
index ece9b332..7e96e40d 100644
--- a/lib/Sbuild/Build.pm
+++ b/lib/Sbuild/Build.pm
@@ -940,11 +940,12 @@ sub run_fetch_install_packages {
failstage => "run-build-failed-commands");
}
} elsif($self->get('Pkg Fail Stage') eq 'install-deps' ) {
+ my $could_not_explain = undef;
+
if (defined $self->get_conf('BD_UNINSTALLABLE_EXPLAINER')
&& $self->get_conf('BD_UNINSTALLABLE_EXPLAINER') ne '') {
if (!$self->explain_bd_uninstallable()) {
- Sbuild::Exception::Build->throw(error => "Failed to explain bd-uninstallable",
- failstage => "explain-bd-uninstallable");
+ $could_not_explain = 1;
}
}
@@ -952,6 +953,11 @@ sub run_fetch_install_packages {
Sbuild::Exception::Build->throw(error => "Failed to execute build-deps-failed-commands",
failstage => "run-build-deps-failed-commands");
}
+
+ if( $could_not_explain ) {
+ Sbuild::Exception::Build->throw(error => "Failed to explain bd-uninstallable",
+ failstage => "explain-bd-uninstallable");
+ }
}
}
--
2.14.1
--- End Message ---
--- Begin Message ---
Source: sbuild
Source-Version: 0.77.0-1
We believe that the bug you reported is fixed in the latest version of
sbuild, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Johannes 'josch' Schauer <[email protected]> (supplier of updated sbuild package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 06 Jul 2018 23:11:45 +0200
Source: sbuild
Binary: libsbuild-perl sbuild sbuild-debian-developer-setup buildd
Architecture: source
Version: 0.77.0-1
Distribution: unstable
Urgency: medium
Maintainer: sbuild maintainers <[email protected]>
Changed-By: Johannes 'josch' Schauer <[email protected]>
Description:
buildd - Daemon for automatically building Debian binary packages from Deb
libsbuild-perl - Library for building Debian binary packages from Debian
sources
sbuild - Tool for building Debian binary packages from Debian sources
sbuild-debian-developer-setup - Convenience script to set up an sbuild
environment for Debian Dev
Closes: 837188 858899 861762 863718 865432 866006 866402 867180 868657 870451
871968 882057 886257 888710 891588 891590 893228 898946 899688 900916 901167
901360 901372 901725 901727 901730
Changes:
sbuild (0.77.0-1) unstable; urgency=medium
.
* New upstream release.
* debian/control: move "exim4 | mail-transport-agent" from Recommends to
Suggests (closes: #863718)
* Set maintainer address to [email protected] (closes: #899688)
* lib/Sbuild/Build.pm: filter out foreign essential and multiarch foreign
packages before passing them to dose3 (closes: #865432)
* man/sbuild.1.in: pre- and post-build-commands are run as non-root (closes:
#900916)
* Add null resolver which does not install, upgrade or remove any packages
(closes: #858899)
* lib/Sbuild/ResolverBase.pm: also print kernel version (closes: #866402)
* lib/Sbuild/Build.pm: install (cross-)build-essential, manual depends and
build depends with a single dummy package (closes: #871968)
* lib/Sbuild/Build.pm: dump .dsc content before extracting it (closes:
#901727)
* Add config variables that allow sbuild to fail if lintian, piuparts or
autopkgtest fail (closes: #891590)
* lib/Sbuild/ResolverBase.pm: run dpkg-scanpackages with -m to allow
multiple architectures of the same package (closes: #886257)
* lib/Sbuild/Build.pm: additional Lintian reasons info and warn (closes:
#893228)
* man/sbuild.1.in: fix typo (closes: #891588)
* lib/Sbuild/Build.pm: also cope with special characters when filtering the
log (closes: #901730)
* Add new log filtering for /build/pkg-minimal-XXX/resolver-YYY:
<<RESOLVERDIR>> (closes: #901725)
* lib/Sbuild/Build.pm: only run autopkgtest if debian/tests/control exists
(closes: #901167)
* lib/Sbuild/Options.pm: --make-binNMU implies --no-arch-all (closes:
#898946)
* etc/sbuild-update-all: set executable bit (closes: #870451)
* lib/Sbuild/ChrootSetup.pm: If BUILD_PATH is set, use it instead of /build
(closes: #868657)
* lib/Sbuild/ResolverBase.pm: clean /var/cache/apt/archive/*.deb after
package installation (closes: #861762)
* bin/sbuild-createchroot: also check exit status of schroot (closes:
#866006)
* Replace httpredir.debian.org with deb.debian.org (closes: #901372)
* lib/Sbuild/ChrootSetup.pm: run groupadd instead of copying entry from host
(closes: #867180)
* man/sbuild-createchroot.8.in: fix outdated path in text description
(closes: #901360)
* bin/sbuild-createchroot: error out early when the target directory exists
and is not empty (closes: #888710)
* Remove support for signing the dummy archive (closes: #837188)
* I now detect more directly if the source wasn't yet unpacked (closes:
#882057)
* debian/control: replace priority:extra by optional
* debian/copyright: use secure copyright format uri
* debian/copyright: fix some outdated information now that sbuild lives on
salsa
* debian/control: update vcs-git and vcs-browser to salsa
* debian/control: fix my name
* debian/control: depend on real cron as first alternative before virtual
cron-daemon
* debian/control: add alternative default-mta before mail-transport-agent
* debian/sbuild.postinst: avoid recursive chown
Checksums-Sha1:
f4ac1186fe3e638eaff11eb17453dea012879379 2455 sbuild_0.77.0-1.dsc
952cb60f0ab42efc8b5819a46d40447a15380ed3 198484 sbuild_0.77.0.orig.tar.xz
a0166f582ff6b6d6ef79961a9f85b9d237c37868 50680 sbuild_0.77.0-1.debian.tar.xz
47e826e507645311612c6a171cee7b21e1e3fd64 6547 sbuild_0.77.0-1_amd64.buildinfo
Checksums-Sha256:
27847d6a7475aa3d655c264c19e7126c7a974d81d55760447d6032c8647e55a4 2455
sbuild_0.77.0-1.dsc
695464692d76065cdcd9e402efafdab4a4bb3621e15cf2953d4833c41314f824 198484
sbuild_0.77.0.orig.tar.xz
7dc5bfbe1ccda7b72e13f0bc3472f2f95368dea544a7b852792b9740d701488d 50680
sbuild_0.77.0-1.debian.tar.xz
eeef01de053b119809900e1e90cc0dea8131e37d3e5d9524c429f42c26fd35f9 6547
sbuild_0.77.0-1_amd64.buildinfo
Files:
7627741589304394346bf086962eb385 2455 devel optional sbuild_0.77.0-1.dsc
4c2473f06733535ab826f45b9daf1054 198484 devel optional
sbuild_0.77.0.orig.tar.xz
5daca0b65b8fc73d303bd5b4fb73ab97 50680 devel optional
sbuild_0.77.0-1.debian.tar.xz
917c16f919c07dabc1fc2efe81fb00e6 6547 devel optional
sbuild_0.77.0-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAls/+zEACgkQ8sulx4+9
g+Gopg//YqQW37lraloPK4jemfyfuCTGynN0cs4WRkz3NZgpRUK7NNxzid1bP1e3
2BYpaybM+PGE+1Mgvm+4N2zBubSV7dnp05PVrI2xUano7JnDHtK0tNJTki+KrJ78
BgaU+hh1fWOMTTroEAUSzJ+l9un3Bb/QOhZTkpQ/AIoYsVecaOAxhKkwYAUkXEHW
odFeolkFi2NZqEockACRfMrNiKU3EqDjFdvxo/2Gq1LayKcduE2/4UgxTtOu29/f
sO1FPITbyT/BNNGcy6VBWLE1cBaphbyTE2IJIPCPNtNfXqRqi13QmAXqyRS64Hts
kEgSIRxvQTMjP66QuTzEif2FEpybrzlC+mDnrmoe+nBqc3IDYWBUFQMggqDLwQLR
JnhU+LkikUDOk/w/lhts1Aw4HgMn6x8nK2rdjRk0wzmUYcOM1LsHMC5fOyX84Z6M
BomdMyJCx304gXvEqKHbd1xWQku7A7LNFJEv0y7m/MkPM4DDesYYMg6lnEgqEtBs
giQcBUUY5MTX3PWOFH2cPlBLM4uEuOgnI+dEzruwPf/EpXs8ZZ5ICnvzMhOZ1RFi
rUR1HPyUtHsLpswOASyDa+39iNg6OmnYTvDCagrwGOzbmQg4QaPvL6sC0zqtLsmg
Zs5QAZFV3I4Vtn2R4PemHYb44E/a6LF+VBoMLJaGy2nRTge30Jo=
=d99y
-----END PGP SIGNATURE-----
--- End Message ---
