Your message dated Wed, 29 Aug 2018 11:34:00 +0200
with message-id <[email protected]>
and subject line Bug fixed in new upstream version
has caused the Debian Bug report #889648,
regarding Typo in glibmm/threads.h causes FTBFS with gcc 8.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
889648: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889648
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libglibmm-2.4-dev
Version: 2.54.1-3
Severity: normal
There is a typo in the glibmm/threads.h header file, a missing & in the
GPrivate::gobj() method.
It has so far not caused that many issues, but if gcc-8 is used for
compiling the typo starts generating FTBFS errors for software
including the header, also if the GPrivate::gobj() is not used.
The bug is fixed upstream in the 2.54 branch:
https://github.com/GNOME/glibmm/commit/37d57ae
Patch attached (this is the patch used in Fedora).
Mattias
From 37d57ae9572b7d74aa385a30313eceae7f2d3fce Mon Sep 17 00:00:00 2001
From: Kjell Ahlstedt <[email protected]>
Date: Wed, 20 Dec 2017 20:00:32 +0100
Subject: [PATCH] Glib::Threads::Private: Fix gobj()
Bug 791711
---
glib/src/threads.hg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/glib/src/threads.hg b/glib/src/threads.hg
index 86d7a17b62f4..c82a6130bbeb 100644
--- a/glib/src/threads.hg
+++ b/glib/src/threads.hg
@@ -628,7 +628,7 @@ public:
*/
inline void replace(T* data);
- GPrivate* gobj() { return gobject_; }
+ GPrivate* gobj() { return &gobject_; }
private:
GPrivate gobject_;
--
2.14.3
diff -urN glibmm-2.54.1-old/glib/glibmm/threads.h glibmm-2.54.1/glib/glibmm/threads.h
--- glibmm-2.54.1-old/glib/glibmm/threads.h 2018-02-02 16:44:05.000000000 +0100
+++ glibmm-2.54.1/glib/glibmm/threads.h 2018-02-02 16:47:04.000000000 +0100
@@ -657,7 +657,7 @@
*/
inline void replace(T* data);
- GPrivate* gobj() { return gobject_; }
+ GPrivate* gobj() { return &gobject_; }
private:
GPrivate gobject_;
smime.p7s
Description: S/MIME cryptographic signature
--- End Message ---
--- Begin Message ---
Version: 2.56.0-1
This bug was fixed when updating to the 2.56.0 release since it was
fixed upstream.
This was however not mentioned in the debian changelog, so it was not
closed automatically. I therefore close it manually.
The bug is still present on some architecture in Debian unstable where
it is now causing other packages to FTBFS, since the 2.56.0 version has
not been built successfully on all architectures due to insufficient
Build-Requires. See:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907474
Mattias
signature.asc
Description: This is a digitally signed message part
--- End Message ---
