Your message dated Wed, 29 Aug 2018 20:35:58 +0100
with message-id <[email protected]>
and subject line Re: Bug#886239: librsvg: please make the build reproducible
has caused the Debian Bug report #886239,
regarding librsvg: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
886239: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886239
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: librsvg
Version: 2.40.20-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: buildpath
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that librsvg could not be built reproducibly.
This is due to the binary including the absolute build path so that
it can find test data.
Patch attached that simply uses a relative source directory instead.
Another solution might be to Build-Depend on fonts-liberation and
specify /path/to/LiberationSans.ttf manually. Or even to specify the
test data path via an environment variable.
(Given it encodes the absolute *build* path, it's clearly not "meant"
to work outside of build-time as this won't exist at runtime.)
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2018-01-03 12:02:22.170730036
+0000
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2018-01-03
+
+--- librsvg-2.40.20.orig/rsvg-cairo-draw.c
++++ librsvg-2.40.20/rsvg-cairo-draw.c
+@@ -398,7 +398,7 @@ set_font_options_for_testing (PangoConte
+ static void
+ create_font_config_for_testing (RsvgCairoRender *render)
+ {
+- const char *font_path = SRCDIR
"/tests/resources/LiberationSans-Regular.ttf";
++ const char *font_path = "resources/LiberationSans-Regular.ttf";
+
+ if (render->font_config_for_testing != NULL)
+ return;
--- a/debian/patches/series 2018-01-03 11:24:31.096515077 +0000
--- b/debian/patches/series 2018-01-03 11:59:57.854019875 +0000
@@ -1,3 +1,4 @@
10_rsvg-gz.patch
disable-new-failing-test.patch
Skip-known-failing-tests-on-32-bit-architectures-at-build.patch
+reproducible-build.patch
--- End Message ---
--- Begin Message ---
Version: 2.44.1-1
On Wed, 29 Aug 2018 at 18:12:35 +0100, Simon McVittie wrote:
> On Wed, 03 Jan 2018 at 12:51:35 +0000, Simon McVittie wrote:
> > It should probably use g_test_build_filename() now that that exists
> > (relative to $G_TEST_SRCDIR or $G_TEST_BUILDDIR as appropriate, falling
> > back to dirname(argv[0]) for both if unspecified).
>
> This appears to have been done in the version that I'll be uploading
> to experimental soon.
--- End Message ---
