Your message dated Wed, 29 Aug 2018 21:04:33 +0000
with message-id <[email protected]>
and subject line Bug#872188: fixed in hddemux 0.4-1
has caused the Debian Bug report #872188,
regarding hddemux: Fix upstream makefile for compiler portability
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
872188: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872188
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: hddemux
Version: 0.3-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu artful ubuntu-patch
Hi Daniel,
The hddemux package was failing to build in Ubuntu, because of a pair of
incompatibilities with Ubuntu's compiler defaults:
- The .c file was listed on the gcc command line after the libraries it
depends on, resulting in a linker error because Ubuntu uses
-Wl,--as-needed by default
(https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-needed)
- The _GNU_SOURCE define caused gcc to use the GNU version of strerror_r(),
which (reasonably, AFAICS from the manpage) resulted in a warning that
the return value was discarded (-Wunused-result). Using _POSIX_C_SOURCE
instead works around this by using the XSI version of strerror_r(), whose
result can more reasonably be ignored.
I've applied the attached patch in Ubuntu to fix both of these issues.
Build logs showing the failure can be found at:
https://launchpad.net/ubuntu/+source/hddemux/0.3-1
FWIW I have not been able to reproduce the build failure on Debian, despite
the fact that Debian unstable has matching upstream versions of gcc and
glibc to Ubuntu. So this is not a serious FTBFS bug in Debian today, though
it seems that could change at any point.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru hddemux-0.3/debian/patches/compiler-flags.patch
hddemux-0.3/debian/patches/compiler-flags.patch
--- hddemux-0.3/debian/patches/compiler-flags.patch 1969-12-31
16:00:00.000000000 -0800
+++ hddemux-0.3/debian/patches/compiler-flags.patch 2017-08-14
20:50:36.000000000 -0700
@@ -0,0 +1,26 @@
+Description: pass correct compiler flags
+ hddemux is built with compiler options that are incompatible with both
+ -Wl,--as-needed and -Werror=unused-result, both of which are on by default
+ in Ubuntu. Fix the order of options on the compiler commandline for
+ -Wl,--as-needed, and use the XSI version of stderr_r() instead of the GNU
+ version for -Werror=unused-result.
+Author: Steve Langasek <[email protected]>
+Index: hddemux-0.3/Makefile
+===================================================================
+--- hddemux-0.3.orig/Makefile
++++ hddemux-0.3/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -D_GNU_SOURCE -g -O3
++CFLAGS += -D_POSIX_C_SOURCE=200112L -g -O3
+
+ CFLAGS += $(shell pkg-config --cflags libuv)
+ CFLAGS += $(shell pkg-config --cflags libsystemd)
+@@ -8,7 +8,7 @@
+ all: hddemux hddemux.1
+
+ hddemux: hddemux.c
+- gcc $(CFLAGS) $(LDFLAGS) -std=c11 -pedantic -Wall -Werror -o $@ $<
++ gcc $(CFLAGS) $< $(LDFLAGS) -std=c11 -pedantic -Wall -Werror -o $@
+
+ hddemux.1: hddemux.1.md
+ pandoc -s -f markdown -t man -o $@ $<
diff -Nru hddemux-0.3/debian/patches/series hddemux-0.3/debian/patches/series
--- hddemux-0.3/debian/patches/series 1969-12-31 16:00:00.000000000 -0800
+++ hddemux-0.3/debian/patches/series 2017-08-14 18:16:49.000000000 -0700
@@ -0,0 +1 @@
+compiler-flags.patch
--- End Message ---
--- Begin Message ---
Source: hddemux
Source-Version: 0.4-1
We believe that the bug you reported is fixed in the latest version of
hddemux, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Kahn Gillmor <[email protected]> (supplier of updated hddemux
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 29 Aug 2018 16:52:12 -0400
Source: hddemux
Binary: hddemux
Architecture: source
Version: 0.4-1
Distribution: unstable
Urgency: medium
Maintainer: Daniel Kahn Gillmor <[email protected]>
Changed-By: Daniel Kahn Gillmor <[email protected]>
Description:
hddemux - HTTP/1.x and DNS demultiplexer
Closes: 872188 906471
Changes:
hddemux (0.4-1) unstable; urgency=medium
.
* new upstream release
- Closes: #906471, #872188
- yes, i can actually count to 16 in hex
- added a simple, totally incomplete test suite
- fix makefile for --Wl,--as-needed (addresses)
- actually verify whether the loop closes correctly
- use UV_* symbols instead of libuv-internal UV__*
- add real test suite
* move to dh 11
* Standards-Version: bump to 4.2.1 (no changes needed)
* use Rules-Requires-Root: no
* move to salsa
* use DEP-14 branch naming
* add autopkgtest
* handle upstream test suite
Checksums-Sha1:
ea6c3a9c3079de7cc2d1134410c4d5b06fd52b64 1501 hddemux_0.4-1.dsc
2be59da506a29ac66c386e025c5bc18498997c8f 33148 hddemux_0.4.orig.tar.gz
7848ac3b594e28dc796fdcf73dd56ec0254abdf5 5504 hddemux_0.4-1.debian.tar.xz
d1f8bf3bcb036ecd8b93cefd84c1619deab219a9 8002 hddemux_0.4-1_amd64.buildinfo
Checksums-Sha256:
703a21f8089cb193404112a6e71f0082ab2229f1ce9ddf5c1f8fab4d50cb4adf 1501
hddemux_0.4-1.dsc
1601916407cb151a2bc435ae49ef46a277defe671eb2c292cb5a9a09bc02a0af 33148
hddemux_0.4.orig.tar.gz
a55218fbf27c023ec3bc084f4eeaa1a099015c76cd32de9d79af7e9056a656d2 5504
hddemux_0.4-1.debian.tar.xz
61156bcfd021716aea970b194db539522d2fcc92d469787ad7f11d5108c0d4b4 8002
hddemux_0.4-1_amd64.buildinfo
Files:
490e3413cd24ebdc1c6d89288008fcb3 1501 net optional hddemux_0.4-1.dsc
c00a448cef17dc3f4329e0cdda89e0f6 33148 net optional hddemux_0.4.orig.tar.gz
0f001a26ec93bb2fafe3fbdf5f963b8c 5504 net optional hddemux_0.4-1.debian.tar.xz
3c69fe2392ca630b5734fa261bf0baae 8002 net optional
hddemux_0.4-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQTTaP514aqS9uSbmdJsHx7ezFD6UwUCW4cJegAKCRBsHx7ezFD6
U++nAP9N0pSS1P2GruDgYwAqcpaDk/aHZmamWYrzF7wCXZwuPAEA58liK9OibeAx
GNAjvtWvylCS6D+Uo7+zPbpGnacJDg0=
=wlj8
-----END PGP SIGNATURE-----
--- End Message ---
