Your message dated Mon, 8 Oct 2018 10:37:15 +0200
with message-id
<CAFX5sbyLusrnX_2ave8fsgsHKGMLnC=Xkv833_AnSnCi=pz...@mail.gmail.com>
and subject line Fixed in 4.2.6-1
has caused the Debian Bug report #858950,
regarding Turba does not obey restrictions defined in Horde permission system
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
858950: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858950
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: php-horde-turba
Version: 4.2.2-3
Severity: normal
Tags: patch
Scenario: Suppose you have a 'localldap' contacts source which is
read-only. Also suppose you have set for this source only 'Read' and 'Show'
permissions to 'All Authenticated Users', using the Horde permission
system, available under 'Adminsitration' menu.
Symptoms: Turba will show 'New contact > in localldap' menu option and will
also allow one to fill out the new contact form for this source. However,
when the user click the 'Add' button, Turba will show this error message
'There was an error adding the new contact. Contact your system
administrator for further help.' in that red square box.
There seems to be a typo in line 431 of
/usr/share/horde/turba/lib/Turba.php; The argument of the 'create' function
is '$source' but it should be '$sourceId', as I could confirm by inspecting
the Turba.php file in the package available in Debian stretch repositories,
which ships the version 4.2.18-1 of Turba.
Attached is a minimal patch that solves the problem.
Regards,
Leonardo Bruno
-- System Information:
Debian Release: 8.7
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages php-horde-turba depends on:
ii php-horde 5.2.1+debian0-2+deb8u3
ii php-horde-auth 2.1.5-5
ii php-horde-content 2.0.4-4
ii php-horde-core 2.15.0+debian0-1+deb8u1
ii php-horde-data 2.1.0-5
ii php-horde-date 2.0.12-5
ii php-horde-dav 1.1.0-1
ii php-horde-exception 2.0.4-4
ii php-horde-form 2.0.8-2
ii php-horde-group 2.0.4-4
ii php-horde-history 2.3.1-4
ii php-horde-icalendar 2.0.9-4
ii php-horde-mail 2.4.0-4
ii php-horde-mime 2.4.5-3
ii php-horde-nls 2.0.4-2
ii php-horde-perms 2.1.2-4
ii php-horde-prefs 2.7.0-3
ii php-horde-serialize 2.0.2-5
ii php-horde-share 2.0.5-4
ii php-horde-support 2.1.1-4
ii php-horde-url 2.2.3-4
ii php-horde-util 2.5.1-5
ii php-horde-vfs 2.2.0-4
ii php-horde-view 2.0.4-4
ii php5-cli 5.6.30+dfsg-0+deb8u1
ii php5-common 5.6.30+dfsg-0+deb8u1
ii php5-json 1.3.6-1
Versions of packages php-horde-turba recommends:
ii php-horde-activesync 2.19.2-2
ii php-horde-db 2.1.4-3
ii php-horde-imsp 2.0.5-2
ii php-horde-kolab-format 2.0.5-4
ii php-horde-kolab-storage 2.1.1-3
ii php-horde-ldap 2.2.0-4
ii php-horde-openxchange 1.0.0-2
ii php-horde-service-facebook 2.0.6-2
php-horde-turba suggests no packages.
-- no debconf information
--- /usr/share/horde/turba/lib/Turba.php 2017-03-28 19:59:32.622397620 -0300
+++ /usr/share/horde/turba/lib/Turba_correct.php 2017-03-28 20:00:00.382397620 -0300
@@ -431,7 +431,7 @@
foreach ($in as $sourceId => $source) {
try {
- $driver = $factory->create($source);
+ $driver = $factory->create($sourceId);
if ($driver->hasPermission($permission) &&
(empty($options['require_add']) || $driver->canAdd())) {
$out[$sourceId] = $source;
--- End Message ---
--- Begin Message ---
Version: 4.2.6-1
Already fixed.
--
Mathieu Parent
--- End Message ---
